recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Give embedded image files with transparency a checkered background

Summary:
Have a consistent rendering experience between File page and file embedded in a task for PNG image files with an alpha channel:
Show a checkered background on the embedded image instead of a white background; show full contrast when hovering over the embedded image.

Closes T15473

Test Plan:
See steps in T15473 - compare an image file embedded in a task before and after applying this patch.

- test in Task description
- test in Task comment
- test in Task comment inside something weird like a table

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15473

Differential Revision: https://we.phorge.it/D25294

Andre Klapper 324470e3 327ac921

+7 -5
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '76ed87e3', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => 'f3d35ae0', 12 + 'core.pkg.css' => '8abf4250', 13 13 'core.pkg.js' => '2eeda9e0', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '525f9a1d', ··· 172 172 'rsrc/css/phui/phui-pager.css' => 'd022c7ad', 173 173 'rsrc/css/phui/phui-pinboard-view.css' => '1f08f5d8', 174 174 'rsrc/css/phui/phui-policy-section-view.css' => '139fdc64', 175 - 'rsrc/css/phui/phui-property-list-view.css' => '5adf7078', 175 + 'rsrc/css/phui/phui-property-list-view.css' => '118db252', 176 176 'rsrc/css/phui/phui-remarkup-preview.css' => '91767007', 177 177 'rsrc/css/phui/phui-segment-bar-view.css' => '5166b370', 178 178 'rsrc/css/phui/phui-spacing.css' => 'b05cadc3', ··· 875 875 'phui-pager-css' => 'd022c7ad', 876 876 'phui-pinboard-view-css' => '1f08f5d8', 877 877 'phui-policy-section-view-css' => '139fdc64', 878 - 'phui-property-list-view-css' => '5adf7078', 878 + 'phui-property-list-view-css' => '118db252', 879 879 'phui-remarkup-preview-css' => '91767007', 880 880 'phui-segment-bar-view-css' => '5166b370', 881 881 'phui-spacing-css' => 'b05cadc3',
+4 -2
webroot/rsrc/css/phui/phui-property-list-view.css
··· 204 204 } 205 205 206 206 207 - .document-engine-image img { 207 + .document-engine-image img, 208 + .phabricator-remarkup-embed-image img { 208 209 margin: 20px auto; 209 210 background: url('/rsrc/image/checker_light.png'); 210 211 max-width: 100%; 211 212 } 212 213 213 - .device-desktop .document-engine-image img:hover { 214 + .device-desktop .document-engine-image img:hover, 215 + .device-desktop .phabricator-remarkup-embed-image img:hover { 214 216 background: url('/rsrc/image/checker_dark.png'); 215 217 } 216 218