recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Use %B for Harbormaster build log updates as well

Summary: So I derped and missed the %s inside the `UPDATE` query (previously only fixing the `INSERT` query). This changes `%s` to `%B` for the update logic as well.

Test Plan: Patched it in production and saw the offending build run all the way through without UTF8-related exceptions.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11669

James Rhodes 32488687 e6fb1dc1

+1 -1
+1 -1
src/applications/harbormaster/storage/build/HarbormasterBuildLog.php
··· 133 133 queryfx( 134 134 $conn, 135 135 'UPDATE harbormaster_buildlogchunk '. 136 - 'SET chunk = CONCAT(chunk, %s), size = LENGTH(CONCAT(chunk, %s))'. 136 + 'SET chunk = CONCAT(chunk, %B), size = LENGTH(CONCAT(chunk, %B))'. 137 137 'WHERE id = %d', 138 138 $content, 139 139 $content,