recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix rendering issue for LDAP configuration provider transactions

Summary: Fixes T4290. At least one of the fields (`realname`) may have a list of items, and `strlen(array('first', 'last'))` produces the warning and stack trace in T4290.

Test Plan:
- Edited `realname` from an array value to an array value.
- Hit error.
- Applied patch.
- No more error.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4290

Differential Revision: https://secure.phabricator.com/D7905

epriestley 324ee4e4 1cb8f0b3

+1 -1
+1 -1
src/applications/auth/provider/PhabricatorAuthProviderLDAP.php
··· 361 361 $label); 362 362 } 363 363 364 - if (!strlen($old)) { 364 + if ($old === null || $old === '') { 365 365 return pht( 366 366 '%s set the "%s" value to "%s".', 367 367 $xaction->renderHandleLink($author_phid),