recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix lightbox downloads for embeded images and a warning

Summary:
I refactored this recently and accidentally dropped the download URI.

Also fix a warning with, e.g., files named `README`.

Test Plan: Clicked a thumb, clicked "Download", got a file.

Reviewers: chad, btrahan, dctrwatson

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7341

epriestley 32dca4b5 95c2b03f

+2 -1
+1 -1
src/applications/differential/view/DifferentialChangesetDetailView.php
··· 47 47 48 48 public function getFileIcon($filename) { 49 49 $path_info = pathinfo($filename); 50 - $extension = $path_info['extension']; 50 + $extension = idx($path_info, 'extension'); 51 51 switch ($extension) { 52 52 case 'psd': 53 53 case 'ai':
+1
src/applications/files/remarkup/PhabricatorRemarkupRuleEmbedFile.php
··· 103 103 'meta' => array( 104 104 'phid' => $file->getPHID(), 105 105 'uri' => $file->getBestURI(), 106 + 'dUri' => $file->getDownloadURI(), 106 107 'viewable' => true, 107 108 ), 108 109 ),