@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Convert missing commit page to newPage
Summary: Minor conversion.
Test Plan: Fake a missing commit. View same layout.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15608
+7
-8
+7
-8
src/applications/diffusion/controller/DiffusionCommitController.php
+7
-8
src/applications/diffusion/controller/DiffusionCommitController.php
···
57
57
'Failed to load the commit because the commit has not been '.
58
58
'parsed yet.'));
59
59
60
-
return $this->buildApplicationPage(
61
-
array(
62
-
$crumbs,
63
-
$error,
64
-
),
65
-
array(
66
-
'title' => pht('Commit Still Parsing'),
67
-
));
60
+
$title = pht('Commit Still Parsing');
61
+
62
+
return $this->newPage()
63
+
->setTitle($title)
64
+
->setCrumbs($crumbs)
65
+
->appendChild($error);
66
+
68
67
}
69
68
70
69
$audit_requests = $commit->getAudits();