recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix call to non-existing newWorkCommands() in NuanceItemType

Summary:
rPe1b8532e2478395bd1f36baecb998adeef5bea3d introduced an implementation of `newWorkCommands()` in the child class `NuanceFormItemType` which is called in parent `NuanceItemType::buildWorkCommands()` without being defined in that parent class.
Thus define `newWorkCommands()` as an abstract class in parent class `NuanceItemType` and add an implementation returning null in the other child class `NuanceGitHubEventItemType` to make static code analyzers happy.

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25655

Andre Klapper 3349c3be cb5a72b5

+6
+4
src/applications/nuance/item/NuanceGitHubEventItemType.php
··· 20 20 return $this->newRawEvent($item)->getEventFullTitle(); 21 21 } 22 22 23 + protected function newWorkCommands(NuanceItem $item) { 24 + return array(); 25 + } 26 + 23 27 public function canUpdateItems() { 24 28 return true; 25 29 }
+2
src/applications/nuance/item/NuanceItemType.php
··· 6 6 private $viewer; 7 7 private $controller; 8 8 9 + abstract protected function newWorkCommands(NuanceItem $item); 10 + 9 11 public function setViewer(PhabricatorUser $viewer) { 10 12 $this->viewer = $viewer; 11 13 return $this;