recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Extend Config to full-width

Summary:
Ref T13362. Some applications moved to fixed-width a while ago but I was generally unsatisfied with where they ended up and have been pushing them back to full-width.

Push Config back to full-width. Some of the subpages end up a little weird, but this provides more space to work with to make some improvements, like makign `maniphest.statuses` more legible in the UI>

Test Plan: Grepped for `setFixed(`, updated each page in `/config/`. Browsed each controller, saw workable full-width UIs.

Maniphest Tasks: T13362

Differential Revision: https://secure.phabricator.com/D20925

epriestley 33c534f9 1667acfa

+39 -57
+2 -3
src/applications/config/controller/PhabricatorConfigAllController.php
··· 64 64 65 65 $content = id(new PHUITwoColumnView()) 66 66 ->setHeader($header) 67 - ->setNavigation($nav) 68 - ->setFixed(true) 69 - ->setMainColumn($view); 67 + ->setFooter($view); 70 68 71 69 return $this->newPage() 72 70 ->setTitle($title) 73 71 ->setCrumbs($crumbs) 72 + ->setNavigation($nav) 74 73 ->appendChild($content); 75 74 76 75 }
+2 -3
src/applications/config/controller/PhabricatorConfigApplicationController.php
··· 18 18 19 19 $content = id(new PHUITwoColumnView()) 20 20 ->setHeader($header) 21 - ->setNavigation($nav) 22 - ->setFixed(true) 23 - ->setMainColumn($apps_list); 21 + ->setFooter($apps_list); 24 22 25 23 $crumbs = $this->buildApplicationCrumbs() 26 24 ->addTextCrumb($title) ··· 29 27 return $this->newPage() 30 28 ->setTitle($title) 31 29 ->setCrumbs($crumbs) 30 + ->setNavigation($nav) 32 31 ->appendChild($content); 33 32 } 34 33
+2 -3
src/applications/config/controller/PhabricatorConfigCacheController.php
··· 33 33 34 34 $content = id(new PHUITwoColumnView()) 35 35 ->setHeader($header) 36 - ->setNavigation($nav) 37 - ->setFixed(true) 38 - ->setMainColumn($page); 36 + ->setFooter($page); 39 37 40 38 return $this->newPage() 41 39 ->setTitle($title) 42 40 ->setCrumbs($crumbs) 41 + ->setNavigation($nav) 43 42 ->appendChild($content); 44 43 } 45 44
+2 -3
src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php
··· 26 26 27 27 $content = id(new PHUITwoColumnView()) 28 28 ->setHeader($header) 29 - ->setNavigation($nav) 30 - ->setFixed(true) 31 - ->setMainColumn($status); 29 + ->setFooter($status); 32 30 33 31 return $this->newPage() 34 32 ->setTitle($title) 35 33 ->setCrumbs($crumbs) 34 + ->setNavigation($nav) 36 35 ->appendChild($content); 37 36 } 38 37
+2 -3
src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php
··· 28 28 29 29 $content = id(new PHUITwoColumnView()) 30 30 ->setHeader($header) 31 - ->setNavigation($nav) 32 - ->setFixed(true) 33 - ->setMainColumn($status); 31 + ->setFooter($status); 34 32 35 33 return $this->newPage() 36 34 ->setTitle($title) 37 35 ->setCrumbs($crumbs) 36 + ->setNavigation($nav) 38 37 ->appendChild($content); 39 38 } 40 39
+6 -6
src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php
··· 32 32 33 33 $content = id(new PHUITwoColumnView()) 34 34 ->setHeader($header) 35 - ->setNavigation($nav) 36 - ->setFixed(true) 37 - ->setMainColumn(array( 38 - $repo_status, 39 - $repo_errors, 40 - )); 35 + ->setFooter( 36 + array( 37 + $repo_status, 38 + $repo_errors, 39 + )); 41 40 42 41 return $this->newPage() 43 42 ->setTitle($title) 44 43 ->setCrumbs($crumbs) 44 + ->setNavigation($nav) 45 45 ->appendChild($content); 46 46 } 47 47
+2 -3
src/applications/config/controller/PhabricatorConfigClusterSearchController.php
··· 26 26 27 27 $content = id(new PHUITwoColumnView()) 28 28 ->setHeader($header) 29 - ->setNavigation($nav) 30 - ->setFixed(true) 31 - ->setMainColumn($search_status); 29 + ->setFooter($search_status); 32 30 33 31 return $this->newPage() 34 32 ->setTitle($title) 35 33 ->setCrumbs($crumbs) 34 + ->setNavigation($nav) 36 35 ->appendChild($content); 37 36 } 38 37
-2
src/applications/config/controller/PhabricatorConfigController.php
··· 7 7 } 8 8 9 9 public function buildSideNavView($filter = null, $for_app = false) { 10 - 11 - 12 10 $guide_href = new PhutilURI('/guides/'); 13 11 $nav = new AphrontSideNavFilterView(); 14 12 $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
+2 -3
src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php
··· 167 167 168 168 $content = id(new PHUITwoColumnView()) 169 169 ->setHeader($header) 170 - ->setNavigation($nav) 171 - ->setFixed(true) 172 - ->setMainColumn($view); 170 + ->setFooter($view); 173 171 174 172 return $this->newPage() 175 173 ->setTitle($title) 176 174 ->setCrumbs($crumbs) 175 + ->setNavigation($nav) 177 176 ->appendChild($content); 178 177 } 179 178
+2 -3
src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php
··· 142 142 143 143 $content = id(new PHUITwoColumnView()) 144 144 ->setHeader($header) 145 - ->setNavigation($nav) 146 - ->setFixed(true) 147 - ->setMainColumn($body); 145 + ->setFooter($body); 148 146 149 147 return $this->newPage() 150 148 ->setTitle($title) 151 149 ->setCrumbs($crumbs) 150 + ->setNavigation($nav) 152 151 ->appendChild($content); 153 152 } 154 153
+3 -3
src/applications/config/controller/PhabricatorConfigEditController.php
··· 237 237 238 238 $view = id(new PHUITwoColumnView()) 239 239 ->setHeader($header) 240 - ->setNavigation($nav) 241 - ->setFixed(true) 242 - ->setMainColumn(array( 240 + ->setFooter( 241 + array( 243 242 $error_view, 244 243 $form_box, 245 244 $status_items, ··· 250 249 return $this->newPage() 251 250 ->setTitle($title) 252 251 ->setCrumbs($crumbs) 252 + ->setNavigation($nav) 253 253 ->appendChild($view); 254 254 } 255 255
+2 -3
src/applications/config/controller/PhabricatorConfigGroupController.php
··· 36 36 37 37 $content = id(new PHUITwoColumnView()) 38 38 ->setHeader($header) 39 - ->setNavigation($nav) 40 - ->setFixed(true) 41 - ->setMainColumn($view); 39 + ->setFooter($view); 42 40 43 41 return $this->newPage() 44 42 ->setTitle($title) 45 43 ->setCrumbs($crumbs) 44 + ->setNavigation($nav) 46 45 ->appendChild($content); 47 46 } 48 47
+2 -3
src/applications/config/controller/PhabricatorConfigHistoryController.php
··· 36 36 37 37 $content = id(new PHUITwoColumnView()) 38 38 ->setHeader($header) 39 - ->setNavigation($nav) 40 - ->setFixed(true) 41 - ->setMainColumn($timeline); 39 + ->setFooter($timeline); 42 40 43 41 return $this->newPage() 44 42 ->setTitle($title) 45 43 ->setCrumbs($crumbs) 44 + ->setNavigation($nav) 46 45 ->appendChild($content); 47 46 } 48 47
+2 -3
src/applications/config/controller/PhabricatorConfigIssueListController.php
··· 59 59 60 60 $content = id(new PHUITwoColumnView()) 61 61 ->setHeader($header) 62 - ->setNavigation($nav) 63 - ->setFixed(true) 64 - ->setMainColumn($issue_list); 62 + ->setFooter($issue_list); 65 63 66 64 return $this->newPage() 67 65 ->setTitle($title) 68 66 ->setCrumbs($crumbs) 67 + ->setNavigation($nav) 69 68 ->appendChild($content); 70 69 } 71 70
+2 -3
src/applications/config/controller/PhabricatorConfigIssueViewController.php
··· 47 47 48 48 $content = id(new PHUITwoColumnView()) 49 49 ->setHeader($header) 50 - ->setNavigation($nav) 51 - ->setFixed(true) 52 - ->setMainColumn($content); 50 + ->setFooter($content); 53 51 54 52 return $this->newPage() 55 53 ->setTitle($title) 56 54 ->setCrumbs($crumbs) 55 + ->setNavigation($nav) 57 56 ->appendChild($content); 58 57 } 59 58
+2 -3
src/applications/config/controller/PhabricatorConfigListController.php
··· 22 22 23 23 $content = id(new PHUITwoColumnView()) 24 24 ->setHeader($header) 25 - ->setNavigation($nav) 26 - ->setFixed(true) 27 - ->setMainColumn($core_list); 25 + ->setFooter($core_list); 28 26 29 27 return $this->newPage() 30 28 ->setTitle($title) 31 29 ->setCrumbs($crumbs) 30 + ->setNavigation($nav) 32 31 ->appendChild($content); 33 32 } 34 33
+2 -3
src/applications/config/controller/PhabricatorConfigModuleController.php
··· 28 28 29 29 $content = id(new PHUITwoColumnView()) 30 30 ->setHeader($header) 31 - ->setNavigation($nav) 32 - ->setFixed(true) 33 - ->setMainColumn($view); 31 + ->setFooter($view); 34 32 35 33 return $this->newPage() 36 34 ->setTitle($title) 37 35 ->setCrumbs($crumbs) 36 + ->setNavigation($nav) 38 37 ->appendChild($content); 39 38 } 40 39
+2 -4
src/applications/config/controller/PhabricatorConfigVersionController.php
··· 23 23 24 24 $content = id(new PHUITwoColumnView()) 25 25 ->setHeader($header) 26 - ->setNavigation($nav) 27 - ->setFixed(true) 28 - ->setMainColumn($view); 26 + ->setFooter($view); 29 27 30 28 return $this->newPage() 31 29 ->setTitle($title) 32 30 ->setCrumbs($crumbs) 31 + ->setNavigation($nav) 33 32 ->appendChild($content); 34 - 35 33 } 36 34 37 35 public function renderModuleStatus($viewer) {