@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Create new databases with appropriate collation
Summary: Ref T1191. We don't create new databases with appropriate collation yet.
Test Plan:
Created a new database and saw it issue:
```
>>> [10] <query> CREATE DATABASE IF NOT EXISTS `phabricator2_testo` COLLATE utf8mb4_bin
```
Reviewers: btrahan, hach-que
Reviewed By: hach-que
Subscribers: epriestley
Maniphest Tasks: T1191
Differential Revision: https://secure.phabricator.com/D10632
+6
-2
+6
-2
src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php
+6
-2
src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php
···
109
109
}
110
110
111
111
public function createDatabase($fragment) {
112
+
$info = $this->getCharsetInfo();
113
+
list($charset, $collate_text, $collate_sort) = $info;
114
+
112
115
queryfx(
113
116
$this->getConn(null),
114
-
'CREATE DATABASE IF NOT EXISTS %T COLLATE utf8_general_ci',
115
-
$this->getDatabaseName($fragment));
117
+
'CREATE DATABASE IF NOT EXISTS %T COLLATE %Q',
118
+
$this->getDatabaseName($fragment),
119
+
$collate_text);
116
120
}
117
121
118
122
public function createTable($fragment, $table, array $cols) {