@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix for Phragment ZIP controller
Summary: This applies a minor fix for the Phragment ZIP controller where it would raise missing index errors when attempting to map deleted fragments to file PHIDs (since deleted fragments no longer have files).
Test Plan: Tested this patch on a live server and saw the issue go away.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley
CC: Korvin, epriestley, aran
Differential Revision: https://secure.phabricator.com/D8243
+3
+3
src/applications/phragment/controller/PhragmentZIPController.php
+3
src/applications/phragment/controller/PhragmentZIPController.php
···
85
85
$files = mpull($files, null, 'getPHID');
86
86
foreach ($mappings as $path => $file_phid) {
87
87
if (!isset($files[$file_phid])) {
88
+
// The path is most likely pointing to a deleted fragment, which
89
+
// hence no longer has a file associated with it.
88
90
unset($mappings[$path]);
91
+
continue;
89
92
}
90
93
$mappings[$path] = $files[$file_phid];
91
94
}