@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.search"
Summary:
Fixes T13386. See PHI1391. These constraints largely exist already, but are not yet exposed to Conduit.
Also, tweak some keys to support the underlying query.
Test Plan: Ran `differential.revision.search` queries with the new constraints.
Maniphest Tasks: T13386
Differential Revision: https://secure.phabricator.com/D20730
+21
-5
+18
src/applications/differential/query/DifferentialRevisionSearchEngine.php
+18
src/applications/differential/query/DifferentialRevisionSearchEngine.php
···
51
51
$map['createdEnd']);
52
52
}
53
53
54
+
if ($map['modifiedStart'] || $map['modifiedEnd']) {
55
+
$query->withUpdatedEpochBetween(
56
+
$map['modifiedStart'],
57
+
$map['modifiedEnd']);
58
+
}
59
+
54
60
return $query;
55
61
}
56
62
···
100
106
->setKey('createdEnd')
101
107
->setDescription(
102
108
pht('Find revisions created at or before a particular time.')),
109
+
id(new PhabricatorSearchDateField())
110
+
->setLabel(pht('Modified After'))
111
+
->setKey('modifiedStart')
112
+
->setIsHidden(true)
113
+
->setDescription(
114
+
pht('Find revisions modified at or after a particular time.')),
115
+
id(new PhabricatorSearchDateField())
116
+
->setLabel(pht('Modified Before'))
117
+
->setKey('modifiedEnd')
118
+
->setIsHidden(true)
119
+
->setDescription(
120
+
pht('Find revisions modified at or before a particular time.')),
103
121
);
104
122
}
105
123
+3
-5
src/applications/differential/storage/DifferentialRevision.php
+3
-5
src/applications/differential/storage/DifferentialRevision.php
···
112
112
'repositoryPHID' => 'phid?',
113
113
),
114
114
self::CONFIG_KEY_SCHEMA => array(
115
-
'key_phid' => null,
116
-
'phid' => array(
117
-
'columns' => array('phid'),
118
-
'unique' => true,
119
-
),
120
115
'authorPHID' => array(
121
116
'columns' => array('authorPHID', 'status'),
122
117
),
···
130
125
// edge table.
131
126
'key_status' => array(
132
127
'columns' => array('status', 'phid'),
128
+
),
129
+
'key_modified' => array(
130
+
'columns' => array('dateModified'),
133
131
),
134
132
),
135
133
) + parent::getConfiguration();