@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue where setting a recurrence end date on a Calendar event without one could fatal
Summary: Ref T11816. The underlying format of recurrence end dates swapped around a bit and we now try to compare `null` to a valid date if you're setting it for the first time.
Test Plan:
- On a new event, set a recurrence end date.
- Then, removed a recurrence end date.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11816
Differential Revision: https://secure.phabricator.com/D17150
+8
+8
src/applications/calendar/xaction/PhabricatorCalendarEventDateTransaction.php
+8
src/applications/calendar/xaction/PhabricatorCalendarEventDateTransaction.php
···
23
23
}
24
24
25
25
public function getTransactionHasEffect($object, $old, $new) {
26
+
// If either value is `null` (for example, when setting a recurring event
27
+
// end date for the first time) and the other value is not `null`, this
28
+
// transaction has an effect.
29
+
$has_null = (($old === null) || ($new === null));
30
+
if ($has_null) {
31
+
return ($old !== $new);
32
+
}
33
+
26
34
$editor = $this->getEditor();
27
35
28
36
$actor = $this->getActor();