@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When cancelling an edit of an inline with content, don't hide the inline
Summary: See PHI1753. This condition got rewritten for suggested edits and accidentally inverted.
Test Plan:
- Create a comment, type text, save draft, edit comment, cancel.
- Before: comment hides itself.
- After: comment properly cancels into pre-edit draft state.
Differential Revision: https://secure.phabricator.com/D21286
+7
-7
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
13
13
'core.pkg.js' => '845355f4',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => '5c459f92',
16
-
'differential.pkg.js' => '2b4a7014',
16
+
'differential.pkg.js' => '218fda21',
17
17
'diffusion.pkg.css' => '42c75c37',
18
18
'diffusion.pkg.js' => 'a98c0bf7',
19
19
'maniphest.pkg.css' => '35995d6d',
···
381
381
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => '0116d3e8',
382
382
'rsrc/js/application/diff/DiffChangeset.js' => '39dcf2c3',
383
383
'rsrc/js/application/diff/DiffChangesetList.js' => 'cc2c5de5',
384
-
'rsrc/js/application/diff/DiffInline.js' => '008b6a15',
384
+
'rsrc/js/application/diff/DiffInline.js' => '511a1315',
385
385
'rsrc/js/application/diff/DiffPathView.js' => '8207abf9',
386
386
'rsrc/js/application/diff/DiffTreeView.js' => '5d83623b',
387
387
'rsrc/js/application/differential/behavior-diff-radios.js' => '925fe8cd',
···
778
778
'phabricator-dashboard-css' => '5a205b9d',
779
779
'phabricator-diff-changeset' => '39dcf2c3',
780
780
'phabricator-diff-changeset-list' => 'cc2c5de5',
781
-
'phabricator-diff-inline' => '008b6a15',
781
+
'phabricator-diff-inline' => '511a1315',
782
782
'phabricator-diff-path-view' => '8207abf9',
783
783
'phabricator-diff-tree-view' => '5d83623b',
784
784
'phabricator-drag-and-drop-file-upload' => '4370900d',
···
919
919
'unhandled-exception-css' => '9ecfc00d',
920
920
),
921
921
'requires' => array(
922
-
'008b6a15' => array(
923
-
'javelin-dom',
924
-
),
925
922
'0116d3e8' => array(
926
923
'javelin-behavior',
927
924
'javelin-dom',
···
1395
1392
'506aa3f4' => array(
1396
1393
'javelin-behavior',
1397
1394
'javelin-stratcom',
1395
+
'javelin-dom',
1396
+
),
1397
+
'511a1315' => array(
1398
1398
'javelin-dom',
1399
1399
),
1400
1400
'5202e831' => array(
+1
-1
webroot/rsrc/js/application/diff/DiffInline.js
+1
-1
webroot/rsrc/js/application/diff/DiffInline.js
···
863
863
864
864
// If this was an empty box and we typed some text and then hit cancel,
865
865
// don't show the empty concrete inline.
866
-
if (!this._isVoidContentState(this._originalState)) {
866
+
if (this._isVoidContentState(this._originalState)) {
867
867
this.setInvisible(true);
868
868
} else {
869
869
this.setInvisible(false);