@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Revert the global "not imported yet" warning in Diffusion until we have better support
Summary:
Partially reverts D8903. This was hacky to begin with, but completely breaks if the filetree is enabled (`$view` is not an array).
Just toss it until we have a more structured way to insert it into the document properly. I don't think it's especially important (the Herald warning is way more important).
Test Plan: Multiple users reported that stuff is no longer broken.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D8914
-42
-42
src/applications/diffusion/controller/DiffusionController.php
-42
src/applications/diffusion/controller/DiffusionController.php
···
40
40
}
41
41
}
42
42
43
-
public function buildApplicationPage($view, array $options) {
44
-
if ($this->diffusionRequest) {
45
-
$drequest = $this->getDiffusionRequest();
46
-
$repository = $drequest->getRepository();
47
-
$error_view = $this->buildRepositoryWarning($repository);
48
-
49
-
$views = array();
50
-
$not_inserted = true;
51
-
foreach ($view as $view_object_or_array) {
52
-
$views[] = $view_object_or_array;
53
-
if ($not_inserted &&
54
-
$view_object_or_array instanceof PhabricatorCrumbsView) {
55
-
$views[] = $error_view;
56
-
$not_inserted = false;
57
-
}
58
-
}
59
-
} else {
60
-
$views = $view;
61
-
}
62
-
63
-
return parent::buildApplicationPage($views, $options);
64
-
}
65
-
66
43
public function buildCrumbs(array $spec = array()) {
67
44
$crumbs = $this->buildApplicationCrumbs();
68
45
$crumb_list = $this->buildCrumbList($spec);
···
258
235
->appendChild($body);
259
236
}
260
237
261
-
private function buildRepositoryWarning(PhabricatorRepository $repository) {
262
-
$error_view = null;
263
-
$title = null;
264
-
if ($repository->isImporting()) {
265
-
$title = pht('This repository is still importing.');
266
-
$body = pht('Things may not work properly until the import finishes.');
267
-
} else if (!$repository->isTracked()) {
268
-
$title = pht('This repository is not tracked.');
269
-
$body = pht(
270
-
'Things may not work properly until tracking is enabled and '.
271
-
'importing finishes.');
272
-
}
273
-
274
-
if ($title) {
275
-
$error_view = $this->renderStatusMessage($title, $body);
276
-
}
277
-
278
-
return $error_view;
279
-
}
280
238
}