@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Delete some commit dead parsing code
Summary: Ref T13552. Neither "$hashes" or "$user" are used, and constructing them has no side effects.
Test Plan: Searched for these symbols.
Maniphest Tasks: T13552
Differential Revision: https://secure.phabricator.com/D21441
-8
-8
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
-8
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
···
63
63
$commit = $this->commit;
64
64
$author = $ref->getAuthor();
65
65
$committer = $ref->getCommitter();
66
-
$hashes = $ref->getHashes();
67
66
$has_committer = (bool)strlen($committer);
68
67
69
68
$viewer = PhabricatorUser::getOmnipotentUser();
···
136
135
137
136
$author_phid = $data->getCommitDetail('authorPHID');
138
137
$committer_phid = $data->getCommitDetail('committerPHID');
139
-
140
-
$user = new PhabricatorUser();
141
-
if ($author_phid) {
142
-
$user = $user->loadOneWhere(
143
-
'phid = %s',
144
-
$author_phid);
145
-
}
146
138
147
139
if ($author_phid != $commit->getAuthorPHID()) {
148
140
$commit->setAuthorPHID($author_phid);