recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix caching for synthetic inline comments

Test Plan: Looked at diff with several different lint errors, saw correct messages in their inline comments.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3827

vrana 3688ac74 1163598a

+3 -2
+2 -1
src/applications/differential/storage/DifferentialInlineComment.php
··· 126 126 127 127 128 128 public function getMarkupFieldKey($field) { 129 - return 'DI:'.$this->getID(); 129 + // We can't use ID because synthetic comments don't have it. 130 + return 'DI:'.PhabricatorHash::digest($this->getContent()); 130 131 } 131 132 132 133 public function newMarkupEngine($field) {
+1 -1
src/infrastructure/markup/PhabricatorMarkupInterface.php
··· 47 47 * "{$phid}:{$field}" 48 48 * 49 49 * @param string Field name. 50 - * @return string Cache key. 50 + * @return string Cache key up to 125 characters. 51 51 * 52 52 * @task markup 53 53 */