recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse()

Summary:
Fix PHP 8.1 strlen(null) in DiffusionView linkBrowse().

Fixes T15542

Test Plan:
# Go into a diff (eg https://my.phorge.site/D1234)
# Click on the Revision Contents - History tab
# Click on a base link (the short git revision ID)

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15542

Differential Revision: https://we.phorge.it/D25340

Steve Campbell 3703588e fb822ba8

+1 -1
+1 -1
src/applications/diffusion/view/DiffusionView.php
··· 71 71 $display_name = idx($details, 'name'); 72 72 unset($details['name']); 73 73 74 - if (strlen($display_name)) { 74 + if (phutil_nonempty_string($display_name)) { 75 75 $display_name = phutil_tag( 76 76 'span', 77 77 array(