@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Minor tweaks to pre/inline style for inline comments in HTML mail
Summary:
Ref T10694.
- Shift margins/padding around so inlines with multiple paragraphs get reasonable spacing.
- Add `text-decoration: none` to the "View Inline" link to kill the underline.
Test Plan: {F1265342}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10694
Differential Revision: https://secure.phabricator.com/D15863
+16
-4
+11
-1
src/applications/differential/editor/DifferentialTransactionEditor.php
+11
-1
src/applications/differential/editor/DifferentialTransactionEditor.php
···
1385
1385
$header = pht('INLINE COMMENTS');
1386
1386
1387
1387
$section_text = "\n".$section->getPlaintext();
1388
-
$section_html = $section->getHTML();
1388
+
1389
+
$style = array(
1390
+
'margin: 12px 0;',
1391
+
);
1392
+
1393
+
$section_html = phutil_tag(
1394
+
'div',
1395
+
array(
1396
+
'style' => implode(' ', $style),
1397
+
),
1398
+
$section->getHTML());
1389
1399
1390
1400
$body->addPlaintextSection($header, $section_text, false);
1391
1401
$body->addHTMLSection($header, $section_html);
+5
-3
src/applications/differential/mail/DifferentialInlineCommentMailView.php
+5
-3
src/applications/differential/mail/DifferentialInlineCommentMailView.php
···
201
201
202
202
if ($is_html) {
203
203
$style = array(
204
-
'padding: 8px 12px;',
204
+
'margin: 8px 0;',
205
+
'padding: 0 12px;',
205
206
);
206
207
207
208
if ($is_quote) {
···
249
250
}
250
251
251
252
$attributes = array(
252
-
'style' => 'padding: 0; margin: 0;',
253
+
'style' => 'padding: 0; margin: 8px;',
253
254
);
254
255
255
256
$engine = PhabricatorMarkupEngine::newMarkupEngine(array())
···
461
462
if ($link_href) {
462
463
$link_style = array(
463
464
'float: right;',
465
+
'text-decoration: none;',
464
466
);
465
467
466
468
$link = phutil_tag(
···
477
479
$style = array(
478
480
'color: #74777d;',
479
481
'background: #eff2f4;',
480
-
'padding: 4px 8px;',
482
+
'padding: 6px 8px;',
481
483
'overflow: hidden;',
482
484
);
483
485