recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't explicitly name abstract base classes

Summary: Ref T5655. It is superfluous to include "base" in the name of an abstract base class. Furthermore, it is not done consistently within the code base.

Test Plan: Ran `arc unit`.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D9989

Joshua Spence 37106c1b 76ed7d1a

+11 -11
+6 -6
src/__phutil_library_map__.php
··· 1835 1835 'PhabricatorNotificationTestController' => 'applications/notification/controller/PhabricatorNotificationTestController.php', 1836 1836 'PhabricatorOAuthClientAuthorization' => 'applications/oauthserver/storage/PhabricatorOAuthClientAuthorization.php', 1837 1837 'PhabricatorOAuthClientAuthorizationQuery' => 'applications/oauthserver/query/PhabricatorOAuthClientAuthorizationQuery.php', 1838 - 'PhabricatorOAuthClientBaseController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientBaseController.php', 1838 + 'PhabricatorOAuthClientController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientController.php', 1839 1839 'PhabricatorOAuthClientDeleteController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientDeleteController.php', 1840 1840 'PhabricatorOAuthClientEditController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php', 1841 1841 'PhabricatorOAuthClientListController' => 'applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php', ··· 4644 4644 'PhabricatorPolicyInterface', 4645 4645 ), 4646 4646 'PhabricatorOAuthClientAuthorizationQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 4647 - 'PhabricatorOAuthClientBaseController' => 'PhabricatorOAuthServerController', 4648 - 'PhabricatorOAuthClientDeleteController' => 'PhabricatorOAuthClientBaseController', 4649 - 'PhabricatorOAuthClientEditController' => 'PhabricatorOAuthClientBaseController', 4650 - 'PhabricatorOAuthClientListController' => 'PhabricatorOAuthClientBaseController', 4651 - 'PhabricatorOAuthClientViewController' => 'PhabricatorOAuthClientBaseController', 4647 + 'PhabricatorOAuthClientController' => 'PhabricatorOAuthServerController', 4648 + 'PhabricatorOAuthClientDeleteController' => 'PhabricatorOAuthClientController', 4649 + 'PhabricatorOAuthClientEditController' => 'PhabricatorOAuthClientController', 4650 + 'PhabricatorOAuthClientListController' => 'PhabricatorOAuthClientController', 4651 + 'PhabricatorOAuthClientViewController' => 'PhabricatorOAuthClientController', 4652 4652 'PhabricatorOAuthResponse' => 'AphrontResponse', 4653 4653 'PhabricatorOAuthServerAccessToken' => 'PhabricatorOAuthServerDAO', 4654 4654 'PhabricatorOAuthServerAuthController' => 'PhabricatorAuthController',
+1 -1
src/applications/oauthserver/controller/client/PhabricatorOAuthClientBaseController.php src/applications/oauthserver/controller/client/PhabricatorOAuthClientController.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorOAuthClientBaseController 3 + abstract class PhabricatorOAuthClientController 4 4 extends PhabricatorOAuthServerController { 5 5 6 6 private $clientPHID;
+1 -1
src/applications/oauthserver/controller/client/PhabricatorOAuthClientDeleteController.php
··· 1 1 <?php 2 2 3 3 final class PhabricatorOAuthClientDeleteController 4 - extends PhabricatorOAuthClientBaseController { 4 + extends PhabricatorOAuthClientController { 5 5 6 6 public function processRequest() { 7 7 $request = $this->getRequest();
+1 -1
src/applications/oauthserver/controller/client/PhabricatorOAuthClientEditController.php
··· 1 1 <?php 2 2 3 3 final class PhabricatorOAuthClientEditController 4 - extends PhabricatorOAuthClientBaseController { 4 + extends PhabricatorOAuthClientController { 5 5 6 6 public function processRequest() { 7 7 $request = $this->getRequest();
+1 -1
src/applications/oauthserver/controller/client/PhabricatorOAuthClientListController.php
··· 1 1 <?php 2 2 3 3 final class PhabricatorOAuthClientListController 4 - extends PhabricatorOAuthClientBaseController { 4 + extends PhabricatorOAuthClientController { 5 5 6 6 private $queryKey; 7 7
+1 -1
src/applications/oauthserver/controller/client/PhabricatorOAuthClientViewController.php
··· 1 1 <?php 2 2 3 3 final class PhabricatorOAuthClientViewController 4 - extends PhabricatorOAuthClientBaseController { 4 + extends PhabricatorOAuthClientController { 5 5 6 6 public function processRequest() { 7 7 $request = $this->getRequest();