@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Revert D2542
Summary: Not required after D2730.
Test Plan: `arc diff` with invalid reviewer in commit message.
Reviewers: nh
Reviewed By: nh
CC: aran, epriestley
Differential Revision: https://secure.phabricator.com/D2733
+3
-16
+1
-2
src/applications/conduit/method/differential/ConduitAPI_differential_parsecommitmessage_Method.php
+1
-2
src/applications/conduit/method/differential/ConduitAPI_differential_parsecommitmessage_Method.php
···
69
69
$field = $aux_fields[$field_key];
70
70
try {
71
71
$fields[$field_key] = $field->parseValueFromCommitMessage($field_value);
72
+
$field->setValueFromParsedCommitMessage($fields[$field_key]);
72
73
} catch (DifferentialFieldParseException $ex) {
73
74
$field_label = $field->renderLabelForCommitMessage();
74
75
$errors[] = "Error parsing field '{$field_label}': ".$ex->getMessage();
75
-
$fields[$field_key] = $ex->getPartialParse();
76
76
}
77
-
$field->setValueFromParsedCommitMessage($fields[$field_key]);
78
77
}
79
78
80
79
if (!$is_partial) {
-10
src/applications/differential/field/exception/DifferentialFieldParseException.php
-10
src/applications/differential/field/exception/DifferentialFieldParseException.php
···
18
18
19
19
final class DifferentialFieldParseException extends Exception {
20
20
21
-
private $partialParse;
22
-
23
-
public function __construct($message, $partial_parse = null) {
24
-
parent::__construct($message);
25
-
$this->partialParse = $partial_parse;
26
-
}
27
-
28
-
public function getPartialParse() {
29
-
return $this->partialParse;
30
-
}
31
21
}
+1
-2
src/applications/differential/field/specification/DifferentialFieldSpecification.php
+1
-2
src/applications/differential/field/specification/DifferentialFieldSpecification.php
···
768
768
? "users and mailing lists"
769
769
: "users";
770
770
throw new DifferentialFieldParseException(
771
-
"Commit message references nonexistent {$what}: {$invalid}.",
772
-
array_unique($results));
771
+
"Commit message references nonexistent {$what}: {$invalid}.");
773
772
}
774
773
775
774
return array_unique($results);
+1
-2
src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php
+1
-2
src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php
···
149
149
}
150
150
$invalid = implode(', ', $invalid);
151
151
throw new DifferentialFieldParseException(
152
-
"Commit message references nonexistent {$what}: {$invalid}.",
153
-
$task_phids);
152
+
"Commit message references nonexistent {$what}: {$invalid}.");
154
153
}
155
154
156
155
return $task_phids;