+1 -1

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

reviewed

··· 46 46 'diffusion-audit-'.$commit->getPHID(), 47 47 pht( 48 48 'Commit %s', 49 49 - 'r'.$repository->getCallsign().$commit->getCommitIdentifier()), 49 49 + $commit->getMonogram()), 50 50 ); 51 51 } 52 52

+11 -10

src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php

reviewed

··· 222 222 return $list; 223 223 } 224 224 225 225 - private function loadRepos($callsigns) { 226 226 - $callsigns = $this->parseList($callsigns); 227 227 - if (!$callsigns) { 225 225 + private function loadRepos($identifiers) { 226 226 + $identifiers = $this->parseList($identifiers); 227 227 + if (!$identifiers) { 228 228 return null; 229 229 } 230 230 231 231 - $repos = id(new PhabricatorRepositoryQuery()) 231 231 + $query = id(new PhabricatorRepositoryQuery()) 232 232 ->setViewer($this->getViewer()) 233 233 - ->withCallsigns($callsigns) 234 234 - ->execute(); 235 235 - $repos = mpull($repos, null, 'getCallsign'); 233 233 + ->withIdentifiers($identifiers); 234 234 + 235 235 + $repos = $query->execute(); 236 236 237 237 - foreach ($callsigns as $sign) { 238 238 - if (empty($repos[$sign])) { 237 237 + $map = $query->getIdentifierMap(); 238 238 + foreach ($identifiers as $identifier) { 239 239 + if (empty($map[$identifier])) { 239 240 throw new PhutilArgumentUsageException( 240 240 - pht('No such repository with callsign "%s"!', $sign)); 241 241 + pht('No repository "%s" exists!', $identifier)); 241 242 } 242 243 } 243 244

+1 -4

src/applications/diffusion/herald/HeraldCommitAdapter.php

reviewed

··· 130 130 } 131 131 132 132 public function getHeraldName() { 133 133 - return 134 134 - 'r'. 135 135 - $this->repository->getCallsign(). 136 136 - $this->commit->getCommitIdentifier(); 133 133 + return $this->commit->getMonogram(); 137 134 } 138 135 139 136 public function loadAffectedPaths() {

+1 -1

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

reviewed

··· 112 112 } else if ($object instanceof DifferentialDiff) { 113 113 $diff_names[] = $object->getID(); 114 114 } else if ($object instanceof PhabricatorRepository) { 115 115 - $repository_names[] = 'r'.$object->getCallsign(); 115 115 + $repository_names[] = $object->getMonogram(); 116 116 } else if ($object instanceof PhabricatorRepositoryCommit) { 117 117 $repository = $object->getRepository(); 118 118 $commit_names[] = $repository->formatCommitName(

+1 -1

src/applications/owners/controller/PhabricatorOwnersPathsController.php

reviewed

··· 83 83 } 84 84 } 85 85 86 86 - $repos = mpull($repos, 'getCallsign', 'getPHID'); 86 86 + $repos = mpull($repos, 'getMonogram', 'getPHID'); 87 87 asort($repos); 88 88 89 89 $template = new AphrontTypeaheadTemplateView();

+3 -3

src/applications/releeph/controller/product/ReleephProductCreateController.php

reviewed

··· 121 121 122 122 foreach ($repos as $repo_id => $repo) { 123 123 $repo_name = $repo->getName(); 124 124 - $callsign = $repo->getCallsign(); 125 125 - $choices[$repo->getPHID()] = "r{$callsign} ({$repo_name})"; 124 124 + $display = $repo->getDisplayName(); 125 125 + $choices[$repo->getPHID()] = "{$display} ({$repo_name})"; 126 126 } 127 127 128 128 - ksort($choices); 128 128 + asort($choices); 129 129 return $choices; 130 130 } 131 131

+1 -1

src/applications/releeph/differential/DifferentialReleephRequestFieldSpecification.php

reviewed

··· 372 372 'part of a Releeph branch, but also has %d path change(s) not '. 373 373 'part of a Releeph branch!', 374 374 $commit->getCommitIdentifier(), 375 375 - $repo->getCallsign(), 375 375 + $repo->getDisplayName(), 376 376 count($in_branch), 377 377 count($ex_branch)); 378 378 phlog($error);

+2 -2

src/applications/releeph/query/ReleephProductSearchEngine.php

reviewed

··· 114 114 phutil_tag( 115 115 'a', 116 116 array( 117 117 - 'href' => '/diffusion/'.$repo->getCallsign().'/', 117 117 + 'href' => $repo->getURI(), 118 118 ), 119 119 - 'r'.$repo->getCallsign())); 119 119 + $repo->getMonogram())); 120 120 121 121 $list->addItem($item); 122 122 }