recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Support logged-out access to more Harbormaster controllers

Summary:
Fixes T13145. The list controllers properly support public access already, but some of the view/detail controllers did not.

Allow logged-out users to browse builds, buildables, plans, etc., provided they can see the corresponding objects.

Test Plan: As a logged-out user, browsed around builds, build plans, logs, etc., without hitting any login pages.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13145

Differential Revision: https://secure.phabricator.com/D19459

epriestley 376ea1dd 5bcca675

+40 -2
+4
src/applications/harbormaster/controller/HarbormasterBuildLogDownloadController.php
··· 3 3 final class HarbormasterBuildLogDownloadController 4 4 extends HarbormasterController { 5 5 6 + public function shouldAllowPublic() { 7 + return true; 8 + } 9 + 6 10 public function handleRequest(AphrontRequest $request) { 7 11 $request = $this->getRequest(); 8 12 $viewer = $request->getUser();
+4
src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php
··· 3 3 final class HarbormasterBuildLogRenderController 4 4 extends HarbormasterController { 5 5 6 + public function shouldAllowPublic() { 7 + return true; 8 + } 9 + 6 10 public function handleRequest(AphrontRequest $request) { 7 11 $viewer = $this->getViewer(); 8 12
+4
src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php
··· 3 3 final class HarbormasterBuildLogViewController 4 4 extends HarbormasterController { 5 5 6 + public function shouldAllowPublic() { 7 + return true; 8 + } 9 + 6 10 public function handleRequest(AphrontRequest $request) { 7 11 $viewer = $this->getViewer(); 8 12
+4
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
··· 3 3 final class HarbormasterBuildViewController 4 4 extends HarbormasterController { 5 5 6 + public function shouldAllowPublic() { 7 + return true; 8 + } 9 + 6 10 public function handleRequest(AphrontRequest $request) { 7 11 $request = $this->getRequest(); 8 12 $viewer = $request->getUser();
+4 -2
src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
··· 3 3 final class HarbormasterBuildableViewController 4 4 extends HarbormasterController { 5 5 6 + public function shouldAllowPublic() { 7 + return true; 8 + } 9 + 6 10 public function handleRequest(AphrontRequest $request) { 7 11 $viewer = $this->getViewer(); 8 12 ··· 349 353 350 354 return array($lint, $unit); 351 355 } 352 - 353 - 354 356 355 357 }
+4
src/applications/harbormaster/controller/HarbormasterLintMessagesController.php
··· 3 3 final class HarbormasterLintMessagesController 4 4 extends HarbormasterController { 5 5 6 + public function shouldAllowPublic() { 7 + return true; 8 + } 9 + 6 10 public function handleRequest(AphrontRequest $request) { 7 11 $viewer = $this->getViewer(); 8 12
+4
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
··· 2 2 3 3 final class HarbormasterPlanViewController extends HarbormasterPlanController { 4 4 5 + public function shouldAllowPublic() { 6 + return true; 7 + } 8 + 5 9 public function handleRequest(AphrontRequest $request) { 6 10 $viewer = $this->getViewer(); 7 11 $id = $request->getURIData('id');
+4
src/applications/harbormaster/controller/HarbormasterStepViewController.php
··· 3 3 final class HarbormasterStepViewController 4 4 extends HarbormasterPlanController { 5 5 6 + public function shouldAllowPublic() { 7 + return true; 8 + } 9 + 6 10 public function handleRequest(AphrontRequest $request) { 7 11 $viewer = $this->getViewer(); 8 12 $id = $request->getURIData('id');
+4
src/applications/harbormaster/controller/HarbormasterUnitMessageListController.php
··· 3 3 final class HarbormasterUnitMessageListController 4 4 extends HarbormasterController { 5 5 6 + public function shouldAllowPublic() { 7 + return true; 8 + } 9 + 6 10 public function handleRequest(AphrontRequest $request) { 7 11 $viewer = $this->getViewer(); 8 12
+4
src/applications/harbormaster/controller/HarbormasterUnitMessageViewController.php
··· 3 3 final class HarbormasterUnitMessageViewController 4 4 extends HarbormasterController { 5 5 6 + public function shouldAllowPublic() { 7 + return true; 8 + } 9 + 6 10 public function handleRequest(AphrontRequest $request) { 7 11 $viewer = $this->getViewer(); 8 12