@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with mentioning revisions on the new EditEngine code
Summary:
Ref T12020. Ref T11114. If we continue here on a mention, we try to generate `$old`, which requires reviewers to be attached. They won't be for simple codepaths like mentions.
Instead, just bail early: we don't need to do anything anyway since we can't possibly find any more errors with zero transactions.
Test Plan: Mentioned a revision on a task.
Reviewers: chad, avivey
Reviewed By: avivey
Maniphest Tasks: T11114, T12020
Differential Revision: https://secure.phabricator.com/D17059
+7
+7
src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
+7
src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
···
286
286
$actor = $this->getActor();
287
287
$errors = array();
288
288
289
+
if (!$xactions) {
290
+
// If we aren't applying new reviewer transactions, just bail. We need
291
+
// reviewers to be attached to the revision continue validation, and
292
+
// they won't always be (for example, when mentioning a revision).
293
+
return $errors;
294
+
}
295
+
289
296
$author_phid = $object->getAuthorPHID();
290
297
$config_self_accept_key = 'differential.allow-self-accept';
291
298
$allow_self_accept = PhabricatorEnv::getEnvConfig($config_self_accept_key);