@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
[Redesign] Make ObjectBox Header conditional
Summary: Ref T8099. In cases like dashboards, we don't always want a header with ObjectBox. This makes it optional.
Test Plan: Review a tab panel, see no weird lines.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D12920
+2
-1
+2
-1
src/view/phui/PHUIObjectBoxView.php
+2
-1
src/view/phui/PHUIObjectBoxView.php
···
159
159
$header_color = $this->headerColor;
160
160
}
161
161
162
+
$header = null;
162
163
if ($this->header) {
163
164
$header = $this->header;
164
165
$header->setHeaderColor($header_color);
165
-
} else {
166
+
} else if ($this->headerText) {
166
167
$header = id(new PHUIHeaderView())
167
168
->setHeader($this->headerText)
168
169
->setHeaderColor($header_color);