@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't reset message if missing Room Title in New Conpherence Room
Summary: Fixes T9000, sets a variable.
Test Plan: Try to make a new room without a title, but with a message.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T9000
Differential Revision: https://secure.phabricator.com/D13754
+6
-4
+6
-4
src/applications/conpherence/controller/ConpherenceNewRoomController.php
+6
-4
src/applications/conpherence/controller/ConpherenceNewRoomController.php
···
7
7
8
8
$title = pht('New Room');
9
9
$e_title = true;
10
+
$v_message = null;
10
11
$validation_exception = null;
11
12
12
13
$conpherence = ConpherenceThread::initializeNewRoom($user);
···
35
36
->setTransactionType(PhabricatorTransactions::TYPE_JOIN_POLICY)
36
37
->setNewValue($request->getStr('joinPolicy'));
37
38
38
-
$message = $request->getStr('message');
39
-
if ($message) {
39
+
$v_message = $request->getStr('message');
40
+
if (strlen($v_message)) {
40
41
$message_xactions = $editor->generateTransactionsFromText(
41
42
$user,
42
43
$conpherence,
43
-
$message);
44
+
$v_message);
44
45
$xactions = array_merge($xactions, $message_xactions);
45
46
}
46
47
···
121
122
id(new PhabricatorRemarkupControl())
122
123
->setUser($user)
123
124
->setName('message')
124
-
->setLabel(pht('First Message')));
125
+
->setLabel(pht('First Message'))
126
+
->setValue($v_message));
125
127
126
128
$dialog->appendChild($form);
127
129