@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Resolve deleted packages properly as having no mailable members
Summary:
Fixes T13648. If a package recipient has been destroyed, this query currently fails to return an expanded recipient value.
Instead, make sure all input PHIDs get an output. For destroyed packages, the output will just be an empty list.
Test Plan:
- Added a package to a revision as a reviewer.
- Destroyed the package.
- Commented on the revision.
- Processed the publishing worker with `bin/worker execute`.
- Before: fatal after expanding the destroyed package.
- After: clean publish.
Maniphest Tasks: T13648
Differential Revision: https://secure.phabricator.com/D21707
+10
+10
src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php
+10
src/applications/metamta/query/PhabricatorMetaMTAMemberQuery.php
···
60
60
}
61
61
$package_map[$package->getPHID()] = $package_owners;
62
62
}
63
+
64
+
// See T13648. We may have packages that no longer exist or can't be
65
+
// loaded (for example, because they have been destroyed). Give them
66
+
// empty entries in the map so we return a mapping for all input PHIDs.
67
+
68
+
foreach ($package_phids as $package_phid) {
69
+
if (!isset($package_map[$package_phid])) {
70
+
$package_map[$package_phid] = array();
71
+
}
72
+
}
63
73
}
64
74
65
75
$results = array();