@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Modernize documentation links

Summary:
- Point them at the new Diviner.
- Make them a little less cumbersome to write.

Test Plan: Found almost all of these links in the UI and clicked them.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D8553

+32 -34
+1 -1
src/aphront/console/plugin/DarkConsoleXHProfPlugin.php
··· 43 43 $profile_uri = $data['profileURI']; 44 44 45 45 if (!DarkConsoleXHProfPluginAPI::isProfilerAvailable()) { 46 - $href = PhabricatorEnv::getDoclink('article/Installation_Guide.html'); 46 + $href = PhabricatorEnv::getDoclink('Installation Guide'); 47 47 $install_guide = phutil_tag( 48 48 'a', 49 49 array(
+1 -1
src/applications/audit/application/PhabricatorApplicationAudit.php
··· 15 15 } 16 16 17 17 public function getHelpURI() { 18 - return PhabricatorEnv::getDoclink('article/Audit_User_Guide.html'); 18 + return PhabricatorEnv::getDoclink('Audit User Guide'); 19 19 } 20 20 21 21 public function getEventListeners() {
+1 -2
src/applications/conduit/application/PhabricatorApplicationConduit.php
··· 15 15 } 16 16 17 17 public function getHelpURI() { 18 - return PhabricatorEnv::getDoclink( 19 - 'article/Conduit_Technical_Documentation.html'); 18 + return PhabricatorEnv::getDoclink('Conduit Technical Documentation'); 20 19 } 21 20 22 21 public function getShortDescription() {
+1 -1
src/applications/config/check/PhabricatorSetupCheckDaemons.php
··· 13 13 14 14 if (!$task_daemon) { 15 15 $doc_href = PhabricatorEnv::getDocLink( 16 - 'article/Managing_Daemons_with_phd.html'); 16 + 'Managing Daemons with phd'); 17 17 18 18 $summary = pht( 19 19 'You must start the Phabricator daemons to send email, rebuild '.
+1 -2
src/applications/config/option/PhabricatorSecurityConfigOptions.php
··· 12 12 } 13 13 14 14 public function getOptions() { 15 - $support_href = PhabricatorEnv::getDoclink( 16 - 'article/feedback.html'); 15 + $support_href = PhabricatorEnv::getDoclink('Give Feedback! Get Support!'); 17 16 18 17 return array( 19 18 $this->newOption('security.alternate-file-domain', 'string', null)
+1 -1
src/applications/differential/application/PhabricatorApplicationDifferential.php
··· 15 15 } 16 16 17 17 public function getHelpURI() { 18 - return PhabricatorEnv::getDoclink('article/Differential_User_Guide.html'); 18 + return PhabricatorEnv::getDoclink('Differential User Guide'); 19 19 } 20 20 21 21 public function getFactObjectsForAnalysis() {
+1 -2
src/applications/differential/controller/DifferentialDiffCreateController.php
··· 41 41 } 42 42 43 43 $form = new AphrontFormView(); 44 - $arcanist_href = PhabricatorEnv::getDoclink( 45 - 'article/Arcanist_User_Guide.html'); 44 + $arcanist_href = PhabricatorEnv::getDoclink('Arcanist User Guide'); 46 45 $arcanist_link = phutil_tag( 47 46 'a', 48 47 array(
+1 -1
src/applications/diffusion/application/PhabricatorApplicationDiffusion.php
··· 15 15 } 16 16 17 17 public function getHelpURI() { 18 - return PhabricatorEnv::getDoclink('article/Diffusion_User_Guide.html'); 18 + return PhabricatorEnv::getDoclink('Diffusion User Guide'); 19 19 } 20 20 21 21 public function getFactObjectsForAnalysis() {
+1 -1
src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
··· 107 107 EOT 108 108 , 109 109 PhabricatorEnv::getDoclink( 110 - 'article/User_Guide_UTF-8_and_Character_Encoding.html')); 110 + 'User Guide: UTF-8 and Character Encoding')); 111 111 } 112 112 113 113 }
+1 -1
src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php
··· 91 91 ->setValue($v_hosting); 92 92 93 93 $doc_href = PhabricatorEnv::getDoclink( 94 - 'article/Diffusion_User_Guide_Repository_Hosting.html'); 94 + 'Diffusion User Guide: Repository Hosting'); 95 95 96 96 $form = id(new AphrontFormView()) 97 97 ->setUser($user)
+2 -2
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
··· 769 769 } 770 770 } 771 771 772 - $doc_href = PhabricatorEnv::getDocLink( 773 - 'article/Managing_Daemons_with_phd.html'); 772 + $doc_href = PhabricatorEnv::getDocLink('Managing Daemons with phd'); 773 + 774 774 $daemon_instructions = pht( 775 775 'Use %s to start daemons. See %s.', 776 776 phutil_tag('tt', array(), 'bin/phd start'),
+1 -1
src/applications/diffusion/controller/DiffusionRepositoryNewController.php
··· 27 27 } 28 28 29 29 $doc_href = PhabricatorEnv::getDoclink( 30 - 'article/Diffusion_User_Guide_Repository_Hosting.html'); 30 + 'Diffusion User Guide: Repository Hosting'); 31 31 32 32 $doc_link = phutil_tag( 33 33 'a',
+1 -1
src/applications/files/controller/PhabricatorFileUploadController.php
··· 94 94 } 95 95 96 96 $doc_href = PhabricatorEnv::getDocLink( 97 - 'article/Configuring_File_Upload_Limits.html'); 97 + 'Configuring File Upload Limits'); 98 98 $doc_link = phutil_tag( 99 99 'a', 100 100 array(
+1 -1
src/applications/herald/application/PhabricatorApplicationHerald.php
··· 19 19 } 20 20 21 21 public function getHelpURI() { 22 - return PhabricatorEnv::getDoclink('article/Herald_User_Guide.html'); 22 + return PhabricatorEnv::getDoclink('Herald User Guide'); 23 23 } 24 24 25 25 public function getFlavorText() {
+1 -1
src/applications/home/controller/PhabricatorHomeMainController.php
··· 324 324 325 325 require_celerity_resource('phabricator-jump-nav'); 326 326 327 - $doc_href = PhabricatorEnv::getDocLink('article/Jump_Nav_User_Guide.html'); 327 + $doc_href = PhabricatorEnv::getDocLink('Jump Nav User Guide'); 328 328 $doc_link = phutil_tag( 329 329 'a', 330 330 array(
+1 -1
src/applications/oauthserver/controller/clientauthorization/PhabricatorOAuthClientAuthorizationListController.php
··· 47 47 $updated = phabricator_datetime($authorization->getDateModified(), 48 48 $current_user); 49 49 $scope_doc_href = PhabricatorEnv::getDoclink( 50 - 'article/Using_the_Phabricator_OAuth_Server.html#scopes'); 50 + 'Using the Phabricator OAuth Server'); 51 51 $row = array( 52 52 phutil_tag( 53 53 'a',
+1 -1
src/applications/owners/application/PhabricatorApplicationOwners.php
··· 19 19 } 20 20 21 21 public function getHelpURI() { 22 - return PhabricatorEnv::getDoclink('article/Owners_Tool_User_Guide.html'); 22 + return PhabricatorEnv::getDoclink('Owners Tool User Guide'); 23 23 } 24 24 25 25 public function getFlavorText() {
+1 -1
src/applications/phame/application/PhabricatorApplicationPhame.php
··· 19 19 } 20 20 21 21 public function getHelpURI() { 22 - return PhabricatorEnv::getDoclink('article/Phame_User_Guide.html'); 22 + return PhabricatorEnv::getDoclink('Phame User Guide'); 23 23 } 24 24 25 25 public function getApplicationGroup() {
+1 -2
src/applications/pholio/view/PholioInlineCommentEditView.php
··· 96 96 $formatting = phutil_tag( 97 97 'a', 98 98 array( 99 - 'href' => PhabricatorEnv::getDoclink( 100 - 'article/Remarkup_Reference.html'), 99 + 'href' => PhabricatorEnv::getDoclink('Remarkup Reference'), 101 100 'tabindex' => '-1', 102 101 'target' => '_blank', 103 102 ),
+1 -2
src/applications/pholio/view/PholioInlineCommentSaveView.php
··· 84 84 $formatting = phutil_tag( 85 85 'a', 86 86 array( 87 - 'href' => PhabricatorEnv::getDoclink( 88 - 'article/Remarkup_Reference.html'), 87 + 'href' => PhabricatorEnv::getDoclink('Remarkup Reference'), 89 88 'tabindex' => '-1', 90 89 'target' => '_blank', 91 90 ),
+1 -1
src/applications/phriction/application/PhabricatorApplicationPhriction.php
··· 15 15 } 16 16 17 17 public function getHelpURI() { 18 - return PhabricatorEnv::getDoclink('article/Phriction_User_Guide.html'); 18 + return PhabricatorEnv::getDoclink('Phriction User Guide'); 19 19 } 20 20 21 21 public function getTitleGlyph() {
+1 -1
src/applications/search/engine/PhabricatorJumpNavHandler.php
··· 4 4 5 5 public static function getJumpResponse(PhabricatorUser $viewer, $jump) { 6 6 $jump = trim($jump); 7 - $help_href = PhabricatorEnv::getDocLink('article/Jump_Nav_User_Guide.html'); 7 + $help_href = PhabricatorEnv::getDocLink('Jump Nav User Guide'); 8 8 9 9 $patterns = array( 10 10 '/^help/i' => 'uri:'.$help_href,
+1 -1
src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
··· 86 86 'a', 87 87 array( 88 88 'href' => PhabricatorEnv::getDoclink( 89 - 'article/User_Guide_Configuring_an_External_Editor.html'), 89 + 'User Guide: Configuring an External Editor'), 90 90 ), 91 91 pht('User Guide: Configuring an External Editor')); 92 92
+1 -1
src/applications/slowvote/application/PhabricatorApplicationSlowvote.php
··· 19 19 } 20 20 21 21 public function getHelpURI() { 22 - return PhabricatorEnv::getDoclink('article/Slowvote_User_Guide.html'); 22 + return PhabricatorEnv::getDoclink('Slowvote User Guide'); 23 23 } 24 24 25 25 public function getFlavorText() {
+6 -2
src/infrastructure/env/PhabricatorEnv.php
··· 336 336 * 337 337 * @task read 338 338 */ 339 - public static function getDoclink($resource) { 340 - return 'http://www.phabricator.com/docs/phabricator/'.$resource; 339 + public static function getDoclink($resource, $type = 'article') { 340 + $uri = new PhutilURI('https://secure.phabricator.com/diviner/find/'); 341 + $uri->setQueryParam('name', $resource); 342 + $uri->setQueryParam('type', $type); 343 + $uri->setQueryParam('jump', true); 344 + return (string)$uri; 341 345 } 342 346 343 347
+1 -2
src/view/form/control/PhabricatorRemarkupControl.php
··· 87 87 $actions['help'] = array( 88 88 'tip' => pht('Help'), 89 89 'align' => 'right', 90 - 'href' => PhabricatorEnv::getDoclink( 91 - 'article/Remarkup_Reference.html'), 90 + 'href' => PhabricatorEnv::getDoclink('Remarkup Reference'), 92 91 ); 93 92 94 93 $actions[] = array(