@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve UX for customizing EditEngine forms a little bit
Summary:
Ref T10004. Tweaks some of the UX a little to be more intuitive/inviting?
- Button says "Configure Form" instead of "Actions".
- Root list is less "developer-ey" and more "explain what this is for-ey".
Test Plan:
{F1028928}
{F1028929}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10004
Differential Revision: https://secure.phabricator.com/D14808
+72
-4
+8
src/applications/maniphest/editor/ManiphestEditEngine.php
+8
src/applications/maniphest/editor/ManiphestEditEngine.php
···
9
9
return pht('Maniphest Tasks');
10
10
}
11
11
12
+
public function getSummaryHeader() {
13
+
return pht('Configure Maniphest Task Forms');
14
+
}
15
+
16
+
public function getSummaryText() {
17
+
return pht('Configure how users create and edit tasks.');
18
+
}
19
+
12
20
public function getEngineApplicationClass() {
13
21
return 'PhabricatorManiphestApplication';
14
22
}
+8
src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php
+8
src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php
···
9
9
return pht('Owners Packages');
10
10
}
11
11
12
+
public function getSummaryHeader() {
13
+
return pht('Configure Owners Package Forms');
14
+
}
15
+
16
+
public function getSummaryText() {
17
+
return pht('Configure forms for creating and editing packages in Owners.');
18
+
}
19
+
12
20
public function getEngineApplicationClass() {
13
21
return 'PhabricatorOwnersApplication';
14
22
}
+8
src/applications/paste/editor/PhabricatorPasteEditEngine.php
+8
src/applications/paste/editor/PhabricatorPasteEditEngine.php
···
9
9
return pht('Pastes');
10
10
}
11
11
12
+
public function getSummaryHeader() {
13
+
return pht('Configure Paste Forms');
14
+
}
15
+
16
+
public function getSummaryText() {
17
+
return pht('Configure creation and editing forms in Paste.');
18
+
}
19
+
12
20
public function getEngineApplicationClass() {
13
21
return 'PhabricatorPasteApplication';
14
22
}
+8
src/applications/phame/editor/PhameBlogEditEngine.php
+8
src/applications/phame/editor/PhameBlogEditEngine.php
···
13
13
return 'PhabricatorPhameApplication';
14
14
}
15
15
16
+
public function getSummaryHeader() {
17
+
return pht('Configure Phame Blog Forms');
18
+
}
19
+
20
+
public function getSummaryText() {
21
+
return pht('Configure how blogs in Phame are created and edited.');
22
+
}
23
+
16
24
protected function newEditableObject() {
17
25
return PhameBlog::initializeNewBlog($this->getViewer());
18
26
}
+23
-2
src/applications/transactions/editengine/PhabricatorEditEngine.php
+23
-2
src/applications/transactions/editengine/PhabricatorEditEngine.php
···
225
225
}
226
226
227
227
228
+
/**
229
+
* Return a human-readable header describing what this engine is used to do,
230
+
* like "Configure Maniphest Task Forms".
231
+
*
232
+
* @return string Human-readable description of the engine.
233
+
* @task text
234
+
*/
235
+
abstract public function getSummaryHeader();
236
+
237
+
238
+
/**
239
+
* Return a human-readable summary of what this engine is used to do.
240
+
*
241
+
* @return string Human-readable description of the engine.
242
+
* @task text
243
+
*/
244
+
abstract public function getSummaryText();
245
+
246
+
247
+
248
+
228
249
/* -( Edit Engine Configuration )------------------------------------------ */
229
250
230
251
···
1010
1031
1011
1032
$action_button = id(new PHUIButtonView())
1012
1033
->setTag('a')
1013
-
->setText(pht('Actions'))
1034
+
->setText(pht('Configure Form'))
1014
1035
->setHref('#')
1015
-
->setIconFont('fa-bars')
1036
+
->setIconFont('fa-gear')
1016
1037
->setDropdownMenu($action_view);
1017
1038
1018
1039
return $action_button;
+10
src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
+10
src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditEngine.php
···
30
30
return pht('Edit Configurations');
31
31
}
32
32
33
+
public function getSummaryHeader() {
34
+
return pht('Configure Forms for Configuring Forms');
35
+
}
36
+
37
+
public function getSummaryText() {
38
+
return pht(
39
+
'Change how forms in other applications are created and edited. '.
40
+
'Advanced!');
41
+
}
42
+
33
43
public function getEngineApplicationClass() {
34
44
return 'PhabricatorTransactionsApplication';
35
45
}
+7
-2
src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php
+7
-2
src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php
···
65
65
$engine_key = $engine->getEngineKey();
66
66
$query_uri = "/transactions/editengine/{$engine_key}/";
67
67
68
+
$application = $engine->getApplication();
69
+
$app_icon = $application->getFontIcon();
70
+
68
71
$item = id(new PHUIObjectItemView())
69
-
->setHeader($engine->getEngineName())
70
-
->setHref($query_uri);
72
+
->setHeader($engine->getSummaryHeader())
73
+
->setHref($query_uri)
74
+
->setStatusIcon($app_icon)
75
+
->addAttribute($engine->getSummaryText());
71
76
72
77
$list->addItem($item);
73
78
}