@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make it easier to ignore setup issues
Summary:
Ref T4331. Ref T5968. Users sometimes have trouble figuring out how to ignore issues. The option is a bit hard to spot, especially if you aren't familiar with interfaces yet.
Make it a button on the issue page itself instead.
Test Plan:
Normal issue:
{F199225}
Ignored issue:
{F199226}
Fatal issue:
{F199227}
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T4331, T5968
Differential Revision: https://secure.phabricator.com/D10420
+100
-26
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
44
44
'rsrc/css/application/config/config-options.css' => '7fedf08b',
45
45
'rsrc/css/application/config/config-template.css' => '25d446d6',
46
46
'rsrc/css/application/config/config-welcome.css' => 'b0d16200',
47
-
'rsrc/css/application/config/setup-issue.css' => '69e640e7',
47
+
'rsrc/css/application/config/setup-issue.css' => '8f852bc0',
48
48
'rsrc/css/application/conpherence/menu.css' => 'e1e0fdf1',
49
49
'rsrc/css/application/conpherence/message-pane.css' => '11a393ca',
50
50
'rsrc/css/application/conpherence/notification.css' => '04a6e10a',
···
811
811
'releeph-preview-branch' => 'b7a6f4a5',
812
812
'releeph-request-differential-create-dialog' => '8d8b92cd',
813
813
'releeph-request-typeahead-css' => '667a48ae',
814
-
'setup-issue-css' => '69e640e7',
814
+
'setup-issue-css' => '8f852bc0',
815
815
'sprite-apps-css' => 'd5baed0f',
816
816
'sprite-apps-large-css' => '20ec0cc0',
817
817
'sprite-conpherence-css' => '3b4a0487',
+1
-1
src/applications/config/check/PhabricatorSetupCheckDaemons.php
+1
-1
src/applications/config/check/PhabricatorSetupCheckDaemons.php
···
23
23
'The Phabricator daemons are not running, so Phabricator will not '.
24
24
'be able to perform background processing (including sending email, '.
25
25
'rebuilding search indexes, importing commits, cleaning up old data, '.
26
-
'running builds, etc.).'.
26
+
'and running builds).'.
27
27
"\n\n".
28
28
'Use %s to start daemons. See %s for more information.',
29
29
phutil_tag('tt', array(), 'bin/phd start'),
+1
-1
src/applications/config/controller/PhabricatorConfigIgnoreController.php
+1
-1
src/applications/config/controller/PhabricatorConfigIgnoreController.php
+1
-13
src/applications/config/controller/PhabricatorConfigIssueListController.php
+1
-13
src/applications/config/controller/PhabricatorConfigIssueListController.php
···
55
55
->addAttribute($issue->getSummary());
56
56
if (!$issue->getIsIgnored()) {
57
57
$item->setBarColor('yellow');
58
-
$item->addAction(
59
-
id(new PHUIListItemView())
60
-
->setIcon('fa-eye-slash')
61
-
->setWorkflow(true)
62
-
->setName(pht('Ignore'))
63
-
->setHref('/config/ignore/'.$issue->getIssueKey().'/'));
64
58
$list->addItem($item);
65
59
} else {
66
-
$item->addIcon('none', pht('Ignored'));
60
+
$item->addIcon('fa-eye-slash', pht('Ignored'));
67
61
$item->setDisabled(true);
68
-
$item->addAction(
69
-
id(new PHUIListItemView())
70
-
->setIcon('fa-eye')
71
-
->setWorkflow(true)
72
-
->setName(pht('Unignore'))
73
-
->setHref('/config/unignore/'.$issue->getIssueKey().'/'));
74
62
$item->setBarColor('none');
75
63
$ignored_items[] = $item;
76
64
}
+76
-8
src/applications/config/view/PhabricatorSetupIssueView.php
+76
-8
src/applications/config/view/PhabricatorSetupIssueView.php
···
107
107
108
108
}
109
109
110
-
$next = phutil_tag(
111
-
'div',
112
-
array(
113
-
'class' => 'setup-issue-next',
114
-
),
115
-
pht('To continue, resolve this problem and reload the page.'));
110
+
$actions = array();
111
+
if (!$issue->getIsFatal()) {
112
+
if ($issue->getIsIgnored()) {
113
+
$actions[] = javelin_tag(
114
+
'a',
115
+
array(
116
+
'href' => '/config/unignore/'.$issue->getIssueKey().'/',
117
+
'sigil' => 'workflow',
118
+
'class' => 'button grey',
119
+
),
120
+
pht('Unignore Setup Issue'));
121
+
} else {
122
+
$actions[] = javelin_tag(
123
+
'a',
124
+
array(
125
+
'href' => '/config/ignore/'.$issue->getIssueKey().'/',
126
+
'sigil' => 'workflow',
127
+
'class' => 'button grey',
128
+
),
129
+
pht('Ignore Setup Issue'));
130
+
}
131
+
132
+
$actions[] = javelin_tag(
133
+
'a',
134
+
array(
135
+
'href' => '/config/issue/'.$issue->getIssueKey().'/',
136
+
'class' => 'button grey',
137
+
'style' => 'float: right',
138
+
),
139
+
pht('Reload Page'));
140
+
}
141
+
142
+
if ($actions) {
143
+
$actions = phutil_tag(
144
+
'div',
145
+
array(
146
+
'class' => 'setup-issue-actions',
147
+
),
148
+
$actions);
149
+
}
150
+
151
+
if ($issue->getIsIgnored()) {
152
+
$status = phutil_tag(
153
+
'div',
154
+
array(
155
+
'class' => 'setup-issue-status',
156
+
),
157
+
pht(
158
+
'This issue is currently ignored, and does not show a global '.
159
+
'warning.'));
160
+
$next = null;
161
+
} else {
162
+
$status = null;
163
+
$next = phutil_tag(
164
+
'div',
165
+
array(
166
+
'class' => 'setup-issue-next',
167
+
),
168
+
pht('To continue, resolve this problem and reload the page.'));
169
+
}
116
170
117
171
$name = phutil_tag(
118
172
'div',
···
121
175
),
122
176
$issue->getName());
123
177
178
+
$head = phutil_tag(
179
+
'div',
180
+
array(
181
+
'class' => 'setup-issue-head',
182
+
),
183
+
array($name, $status));
184
+
185
+
$tail = phutil_tag(
186
+
'div',
187
+
array(
188
+
'class' => 'setup-issue-tail',
189
+
),
190
+
array($actions, $next));
191
+
124
192
$issue = phutil_tag(
125
193
'div',
126
194
array(
127
195
'class' => 'setup-issue',
128
196
),
129
197
array(
130
-
$name,
198
+
$head,
131
199
$description,
132
-
$next,
200
+
$tail,
133
201
));
134
202
135
203
$debug_info = phutil_tag(
+19
-1
webroot/rsrc/css/application/config/setup-issue.css
+19
-1
webroot/rsrc/css/application/config/setup-issue.css
···
87
87
background-repeat: repeat-x;
88
88
}
89
89
90
+
.setup-issue-tail {
91
+
margin-top: 12px;
92
+
}
93
+
94
+
.setup-issue-status {
95
+
padding: 12px;
96
+
background: #f3f3f3;
97
+
color: #666666;
98
+
border-bottom: 1px solid #dfdfdf;
99
+
font-style: italic;
100
+
}
101
+
102
+
.setup-issue-actions {
103
+
padding: 12px;
104
+
background: #f3f3f3;
105
+
border-top: 1px solid #dfdfdf;
106
+
overflow: hidden;
107
+
}
108
+
90
109
.setup-issue-next {
91
110
padding: 12px;
92
111
border-top: 1px solid #BFCFDA;
···
94
113
text-align: center;
95
114
font-size: 15px;
96
115
color: #2980b9;
97
-
margin-top: 12px;
98
116
}
99
117
100
118
.setup-issue-config {