@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make the "attach_inlines" parameter to "differential.createcomment" a no-op
Summary: Ref T13513. See that task for some discussion. This prepares to lift "loadUnsubmittedInlineComments(...)" into shared code.
Test Plan: Grepped for callers, found none in the upstream. This is a backward compatibilty break. See T13513.
Maniphest Tasks: T13513
Differential Revision: https://secure.phabricator.com/D21225
+2
-11
+2
-11
src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
+2
-11
src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php
···
94
94
->setContent($content));
95
95
}
96
96
97
-
if ($request->getValue('attach_inlines')) {
98
-
$type_inline = DifferentialTransaction::TYPE_INLINE;
99
-
$inlines = DifferentialTransactionQuery::loadUnsubmittedInlineComments(
100
-
$viewer,
101
-
$revision);
102
-
foreach ($inlines as $inline) {
103
-
$xactions[] = id(new DifferentialTransaction())
104
-
->setTransactionType($type_inline)
105
-
->attachComment($inline);
106
-
}
107
-
}
97
+
// NOTE: The legacy "attach_inlines" flag is now ignored and has no
98
+
// effect. See T13513.
108
99
109
100
// NOTE: The legacy "silent" flag is now ignored and has no effect. See
110
101
// T13042.