@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Update Macro Edit for new UI

Summary: Updates Edit/Create page for Macro to new headers

Test Plan: Create Macro, Edit Macro

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15568

authored by

Chad Little and committed by
chad
399b23d6 1f107b8f

+21 -9
+21 -9
src/applications/macro/controller/PhabricatorMacroEditController.php
··· 233 233 $crumbs = $this->buildApplicationCrumbs(); 234 234 235 235 if ($macro->getID()) { 236 - $title = pht('Edit Image Macro'); 236 + $title = pht('Edit Macro: %s', $macro->getName()); 237 237 $crumb = pht('Edit Macro'); 238 + $header_icon = 'fa-pencil'; 238 239 239 - $crumbs->addTextCrumb(pht('Macro "%s"', $macro->getName()), $view_uri); 240 + $crumbs->addTextCrumb(pht('Macro: %s', $macro->getName()), $view_uri); 240 241 } else { 241 242 $title = pht('Create Image Macro'); 242 243 $crumb = pht('Create Macro'); 244 + $header_icon = 'fa-plus-square'; 243 245 } 244 246 245 247 $crumbs->addTextCrumb($crumb, $request->getRequestURI()); 248 + $crumbs->setBorder(true); 246 249 247 250 $upload = null; 248 251 if ($macro->getID()) { ··· 267 270 268 271 $upload = id(new PHUIObjectBoxView()) 269 272 ->setHeaderText(pht('Upload New File')) 273 + ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) 270 274 ->setForm($upload_form); 271 275 } 272 276 273 277 $form_box = id(new PHUIObjectBoxView()) 274 - ->setHeaderText($title) 278 + ->setHeaderText(pht('Macro')) 275 279 ->setFormErrors($errors) 280 + ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) 276 281 ->setForm($form); 277 282 278 - return $this->buildApplicationPage( 279 - array( 280 - $crumbs, 283 + $header = id(new PHUIHeaderView()) 284 + ->setHeader($title) 285 + ->setHeaderIcon($header_icon); 286 + 287 + $view = id(new PHUITwoColumnView()) 288 + ->setHeader($header) 289 + ->setFooter(array( 281 290 $form_box, 282 291 $upload, 283 - ), 284 - array( 285 - 'title' => $title, 286 292 )); 293 + 294 + return $this->newPage() 295 + ->setTitle($title) 296 + ->setCrumbs($crumbs) 297 + ->appendChild($view); 298 + 287 299 } 288 300 289 301 }