recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversion

Summary:
I converted this call incorrectly in D16092. We should pass the `PhutilURI` object, not the string version of it.

Specifically, this resulted in hitting an error like this if a replica needed synchronization:

```
[2016-08-11 21:22:37] EXCEPTION: (InvalidArgumentException) Argument 1 passed to DiffusionCommandEngine::setURI() must be an instance of PhutilURI, string given, called in...
#0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/diffusion/protocol/DiffusionCommandEngine.php:52]
#1 DiffusionCommandEngine::setURI(string) called at [<phabricator>/src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php:601]
...
```

Test Plan: Clusterized an observed repository, demoted a node, ran `bin/repository update Rxxx` to update, saw no typehint fatal.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16390

epriestley 39d4e21e 5e3efca0

+1 -1
+1 -1
src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
··· 598 598 ->setArgv($argv) 599 599 ->setSudoAsDaemon(true) 600 600 ->setCredentialPHID($repository->getCredentialPHID()) 601 - ->setURI($repository->getRemoteURI()) 601 + ->setURI($repository->getRemoteURIObject()) 602 602 ->newFuture(); 603 603 604 604 $future->setCWD($local_path);