@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conduit API: Add constraint descriptions to phriction.content.search
Summary: I was initially confused about `phids` versus `documentPHIDs`; maybe the missing description would have helped.
Test Plan: Go to http://phorge.localhost/conduit/method/phriction.content.search/, look at the table below "This API endpoint supports these constraints:", see two descriptions which were missing before.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26327
+9
-2
+9
-2
src/applications/phriction/query/PhrictionContentSearchEngine.php
+9
-2
src/applications/phriction/query/PhrictionContentSearchEngine.php
···
34
34
id(new PhabricatorPHIDsSearchField())
35
35
->setKey('documentPHIDs')
36
36
->setAliases(array('document', 'documents', 'documentPHID'))
37
-
->setLabel(pht('Documents')),
37
+
->setLabel(pht('Documents'))
38
+
->setDescription(
39
+
pht(
40
+
'Search for documents with specific PHIDs.')),
38
41
id(new PhabricatorIDsSearchField())
39
42
->setKey('versions')
40
-
->setAliases(array('version')),
43
+
->setAliases(array('version'))
44
+
->setLabel(pht('Versions'))
45
+
->setDescription(
46
+
pht(
47
+
'Search for documents with specific versions.')),
41
48
);
42
49
}
43
50