recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Render all Removed Comments a little more docile

Summary:
This small restyle makes any Removed Comment a little less
prominent than normal ones, with the goal of decreasing a
bit your in-page distractions and increase your individual
productivity in your business by at least 250 milliseconds
every 48 hours of hard work in front of your monitor.

| Before | After |
|---------------------|---------------------|
| {F274834,size=full} | {F274835,size=full} |

This implementation (which is called "Kasper on Diet")
contains these specific changes for Removed Comments:

- user icon visibility: reduced by ~50% (-> Kasper)
- black "trash" icon: reduced by ~50% (-> Diet)
- texts: visibility reduced by ~50%
- vertical padding: reduced from 16px down to 4px

Note that if your Phorge is under the Serious Business Mode,
it seems it is still technically possible to manually
activate the "Decaying Curse" proposal mentioned in the Task.

Closes T15192

Test Plan:
- Add a Comment "I love Phorge"
- Add a Comment "I love Phabricator"
- Mark the second Comment as Removed
- Call a person at your desk
- Plug that person to an eyeball tracker

If the general attention focuses first on a normal Comment and then
on the Removed Comment, this change works perfectly.

Reviewers: O1 Blessed Committers, Cigaryno, avivey

Reviewed By: O1 Blessed Committers, Cigaryno, avivey

Subscribers: speck, tobiaswiese, Matthew, Cigaryno

Tags: #comments

Maniphest Tasks: T15192

Differential Revision: https://we.phorge.it/D25096

Valerio Bozzolan 3a8ee271 524579fe

+29 -4
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => '0e3cf785', 11 11 'conpherence.pkg.js' => '020aebcf', 12 - 'core.pkg.css' => 'bb377509', 12 + 'core.pkg.css' => '6590cb9f', 13 13 'core.pkg.js' => '66c49ca1', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => '609e63d4', ··· 178 178 'rsrc/css/phui/phui-spacing.css' => 'b05cadc3', 179 179 'rsrc/css/phui/phui-status.css' => '293b5dad', 180 180 'rsrc/css/phui/phui-tag-view.css' => 'fb811341', 181 - 'rsrc/css/phui/phui-timeline-view.css' => '2d32d7a9', 181 + 'rsrc/css/phui/phui-timeline-view.css' => 'cc554a79', 182 182 'rsrc/css/phui/phui-two-column-view.css' => 'f96d319f', 183 183 'rsrc/css/phui/workboards/phui-workboard-color.css' => '3a1c21ff', 184 184 'rsrc/css/phui/workboards/phui-workboard.css' => '74fc9d98', ··· 880 880 'phui-status-list-view-css' => '293b5dad', 881 881 'phui-tag-view-css' => 'fb811341', 882 882 'phui-theme-css' => '35883b37', 883 - 'phui-timeline-view-css' => '2d32d7a9', 883 + 'phui-timeline-view-css' => 'cc554a79', 884 884 'phui-two-column-view-css' => 'f96d319f', 885 885 'phui-workboard-color-css' => '3a1c21ff', 886 886 'phui-workboard-view-css' => '74fc9d98',
+1 -1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
··· 539 539 case PhabricatorTransactions::TYPE_COMMENT; 540 540 $comment = $this->getComment(); 541 541 if ($comment && $comment->getIsRemoved()) { 542 - return 'black'; 542 + return 'grey'; 543 543 } 544 544 break; 545 545 case PhabricatorTransactions::TYPE_EDGE:
+5
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
··· 493 493 $xaction->getComment() && 494 494 $xaction->getComment()->getIsRemoved(); 495 495 496 + // Make designers happy to make CSS customizations 497 + if ($has_removed_comment) { 498 + $event->addClass('phui-timeline-shell-removed'); 499 + } 500 + 496 501 if ($xaction->getCommentVersion() > 1 && !$has_removed_comment) { 497 502 $event->setIsEdited(true); 498 503 }
+20
webroot/rsrc/css/phui/phui-timeline-view.css
··· 189 189 overflow-x: auto; 190 190 } 191 191 192 + /* 193 + * Start Customization for removed comments 194 + * https://we.phorge.it/T15192 195 + */ 196 + 192 197 .phui-timeline-core-content .comment-deleted { 193 198 font-style: italic; 194 199 } 200 + .phui-timeline-shell-removed .phui-timeline-image { 201 + opacity: 0.5; 202 + } 203 + .phui-timeline-shell-removed, 204 + .phui-timeline-shell-removed a, 205 + .phui-timeline-shell-removed .phui-timeline-title { 206 + color:#888; /* grey */ 207 + } 208 + .phui-timeline-shell-removed 209 + .phui-timeline-major-event 210 + .phui-timeline-content .phui-timeline-core-content { 211 + padding:4px 16px; /* reduce vertical space from 16px */ 212 + } 213 + 214 + /* End Customization for removed comments */ 195 215 196 216 .device .phui-timeline-event-view { 197 217 min-height: 23px;