recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Preserve "Space" UI control value when editing Passphrase credentials

Summary: Fixes T9568. We just weren't setting this properly so it would default away from the proper value.

Test Plan:
- Edited a credential in a non-default space, edit form populated properly.
- Changed "Space", introduced an error, saved form, got error with sticky value for "Space" properly.
- Saved form with new space value.
- Created a new credential.

Reviewers: chad

Reviewed By: chad

Subscribers: revi

Maniphest Tasks: T9568

Differential Revision: https://secure.phabricator.com/D14278

epriestley 3a91e648 ac7edf54

+1
+1
src/applications/passphrase/controller/PassphraseCredentialEditController.php
··· 249 249 id(new AphrontFormPolicyControl()) 250 250 ->setName('viewPolicy') 251 251 ->setPolicyObject($credential) 252 + ->setSpacePHID($v_space) 252 253 ->setCapability(PhabricatorPolicyCapability::CAN_VIEW) 253 254 ->setPolicies($policies)) 254 255 ->appendControl(