recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Conduit: Convert nearly all unstable methods to stable

Summary:
All these "unstable" Conduit API methods have had this status for at least ten years now.
Thus in reality they are neither new, nor subject to any planned changes, nor have they actually been "unstable" over the last years.

Thus remove the `getMethodStatus()` functions returning `METHOD_STATUS_UNSTABLE` from them.
Per their parent class, `getMethodStatus()` returns `METHOD_STATUS_STABLE` when not overwritten.

Exclude `NuanceConduitAPIMethod` from this patch, as that application is a prototype and thus unstable.

Closes T16313

Test Plan:
Go to one of those endpoints, e.g. http://phorge.localhost/conduit/method/macro.creatememe/, and do not see anymore
`Stability - Unstable Method: This method is new and unstable. Its interface is subject to change.`

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16313

Differential Revision: https://we.phorge.it/D26440

Andre Klapper 3aa4c91a 426a7f95

-44
-4
src/applications/auth/conduit/PhabricatorAuthConduitAPIMethod.php
··· 7 7 PhabricatorAuthApplication::class); 8 8 } 9 9 10 - public function getMethodStatus() { 11 - return self::METHOD_STATUS_UNSTABLE; 12 - } 13 - 14 10 public function getMethodStatusDescription() { 15 11 return pht('These methods are recently introduced and subject to change.'); 16 12 }
-4
src/applications/diffusion/conduit/DiffusionGetLintMessagesConduitAPIMethod.php
··· 7 7 return 'diffusion.getlintmessages'; 8 8 } 9 9 10 - public function getMethodStatus() { 11 - return self::METHOD_STATUS_UNSTABLE; 12 - } 13 - 14 10 public function getMethodDescription() { 15 11 return pht('Get lint messages for existing code.'); 16 12 }
-4
src/applications/diffusion/conduit/DiffusionLookSoonConduitAPIMethod.php
··· 7 7 return 'diffusion.looksoon'; 8 8 } 9 9 10 - public function getMethodStatus() { 11 - return self::METHOD_STATUS_UNSTABLE; 12 - } 13 - 14 10 public function getMethodDescription() { 15 11 return pht( 16 12 'Advises this server to look for new commits in a repository as soon '.
-4
src/applications/diffusion/conduit/DiffusionUpdateCoverageConduitAPIMethod.php
··· 7 7 return 'diffusion.updatecoverage'; 8 8 } 9 9 10 - public function getMethodStatus() { 11 - return self::METHOD_STATUS_UNSTABLE; 12 - } 13 - 14 10 public function getMethodDescription() { 15 11 return pht('Publish coverage information for a repository.'); 16 12 }
-4
src/applications/feed/conduit/FeedQueryConduitAPIMethod.php
··· 6 6 return 'feed.query'; 7 7 } 8 8 9 - public function getMethodStatus() { 10 - return self::METHOD_STATUS_UNSTABLE; 11 - } 12 - 13 9 public function getMethodDescription() { 14 10 return pht('Query the feed for stories'); 15 11 }
-4
src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php
··· 6 6 return 'macro.creatememe'; 7 7 } 8 8 9 - public function getMethodStatus() { 10 - return self::METHOD_STATUS_UNSTABLE; 11 - } 12 - 13 9 public function getMethodDescription() { 14 10 return pht('Generate a meme.'); 15 11 }
-4
src/applications/phrequent/conduit/PhrequentPopConduitAPIMethod.php
··· 10 10 return pht('Stop tracking time on an object by popping it from the stack.'); 11 11 } 12 12 13 - public function getMethodStatus() { 14 - return self::METHOD_STATUS_UNSTABLE; 15 - } 16 - 17 13 protected function defineParamTypes() { 18 14 return array( 19 15 'objectPHID' => 'phid',
-4
src/applications/phrequent/conduit/PhrequentPushConduitAPIMethod.php
··· 12 12 'pushing it on the tracking stack.'); 13 13 } 14 14 15 - public function getMethodStatus() { 16 - return self::METHOD_STATUS_UNSTABLE; 17 - } 18 - 19 15 protected function defineParamTypes() { 20 16 return array( 21 17 'objectPHID' => 'required phid',
-4
src/applications/phrequent/conduit/PhrequentTrackingConduitAPIMethod.php
··· 11 11 return pht('Returns current objects being tracked in Phrequent.'); 12 12 } 13 13 14 - public function getMethodStatus() { 15 - return self::METHOD_STATUS_UNSTABLE; 16 - } 17 - 18 14 protected function defineParamTypes() { 19 15 return array(); 20 16 }
-4
src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php
··· 6 6 return 'remarkup.process'; 7 7 } 8 8 9 - public function getMethodStatus() { 10 - return self::METHOD_STATUS_UNSTABLE; 11 - } 12 - 13 9 public function getMethodDescription() { 14 10 return pht('Process text through remarkup.'); 15 11 }
-4
src/applications/tokens/conduit/TokenConduitAPIMethod.php
··· 7 7 PhabricatorTokensApplication::class); 8 8 } 9 9 10 - public function getMethodStatus() { 11 - return self::METHOD_STATUS_UNSTABLE; 12 - } 13 - 14 10 /** 15 11 * @param array<PhabricatorToken> $tokens 16 12 */