@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue in legalpad when signing with a registered email address
Summary: If you're logged out and try to sign a document with a registered email address, we don't handle telling you to login correctly.
Test Plan: Tried to sign with a registered address, got a helpful dialog instead of a fatal.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D12544
+5
-1
+5
-1
src/applications/legalpad/controller/LegalpadDocumentSignController.php
+5
-1
src/applications/legalpad/controller/LegalpadDocumentSignController.php
···
22
22
return new Aphront404Response();
23
23
}
24
24
25
-
list($signer_phid, $signature_data) = $this->readSignerInformation(
25
+
$information = $this->readSignerInformation(
26
26
$document,
27
27
$request);
28
+
if ($information instanceof AphrontResponse) {
29
+
return $information;
30
+
}
31
+
list($signer_phid, $signature_data) = $information;
28
32
29
33
$signature = null;
30
34