@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add the rest of the "Debug/Developer" config group.
Summary:
- Adds the rest of the group as per T2255.
- Adds a pht() around the `$developer_warning` in `PhabricatorStandardPageView`.
Test Plan:
- Viewed new config options.
- Triggered a fake warning to make sure I didn't break error callouts.
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T2255
Differential Revision: https://secure.phabricator.com/D4333
authored by
Ricky Elrod
and committed by
epriestley
3b3808c4
f84e0ca5
+57
-3
+54
-1
src/applications/config/option/PhabricatorDeveloperConfigOptions.php
+54
-1
src/applications/config/option/PhabricatorDeveloperConfigOptions.php
···
86
86
"data to look at eventually). In development, it may be useful to ".
87
87
"set it to 1 in order to debug performance problems.\n\n".
88
88
"NOTE: You must install XHProf for profiling to work.")),
89
+
$this->newOption('phabricator.show-stack-traces', 'bool', false)
90
+
->setOptions(
91
+
array(
92
+
pht('Hide stack traces'),
93
+
pht('Show stack traces'),
94
+
))
95
+
->setSummary(pht("Show stack traces when unhandled exceptions occur."))
96
+
->setDescription(
97
+
pht(
98
+
"When unhandled exceptions occur, stack traces are hidden by ".
99
+
"default. You can enable traces for development to make it easier ".
100
+
"to debug problems.")),
101
+
$this->newOption('phabricator.show-error-callout', 'bool', false)
102
+
->setOptions(
103
+
array(
104
+
pht('Hide error callout'),
105
+
pht('Show error callout'),
106
+
))
107
+
->setSummary(pht("Show error callout."))
108
+
->setDescription(
109
+
pht(
110
+
"Shows an error callout if a page generated PHP errors, warnings ".
111
+
"or notices. This makes it harder to miss problems while ".
112
+
"developing Phabricator. A callout is simply a red error at the ".
113
+
"top of the page.")),
114
+
$this->newOption('celerity.force-disk-reads', 'bool', false)
115
+
->setOptions(
116
+
array(
117
+
pht("Don't force disk reads"),
118
+
pht('Force disk reads'),
119
+
))
120
+
->setSummary(pht("Force Celerity to read from disk on every request."))
121
+
->setDescription(
122
+
pht(
123
+
"In a development environment, it is desirable to force static ".
124
+
"resources (CSS and JS) to be read from disk on every request, so ".
125
+
"that edits to them appear when you reload the page even if you ".
126
+
"haven't updated the resource maps. This setting ensures requests ".
127
+
"will be verified against the state on disk. Generally, you ".
128
+
"should leave this off in production (caching behavior and ".
129
+
"performance improve with it off) but turn it on in development. ".
130
+
"(These settings are the defaults.)")),
131
+
$this->newOption('celerity.minify', 'bool', false)
132
+
->setOptions(
133
+
array(
134
+
pht("Don't minify static resources."),
135
+
pht('Minify static resources.'),
136
+
))
137
+
->setSummary(pht("Minify static Celerity resources."))
138
+
->setDescription(
139
+
pht(
140
+
"Minify static resources by removing whitespace and comments. You ".
141
+
"should enable this in production, but disable it in ".
142
+
"development.")),
89
143
);
90
144
}
91
-
92
145
}
+3
-2
src/view/page/PhabricatorStandardPageView.php
+3
-2
src/view/page/PhabricatorStandardPageView.php
···
280
280
DarkConsoleErrorLogPluginAPI::getErrors()) {
281
281
$developer_warning =
282
282
'<div class="aphront-developer-error-callout">'.
283
-
'This page raised PHP errors. Find them in DarkConsole '.
284
-
'or the error log.'.
283
+
pht(
284
+
'This page raised PHP errors. Find them in DarkConsole '.
285
+
'or the error log.').
285
286
'</div>';
286
287
}
287
288