@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Rename the Differential "hasBroadcast" flag to "shouldBroadcast"
Summary:
Depends on D19282. Ref T13110. I want to introduce "Changes Planned + Still A Draft" and "Abandoned + Still A Draft" states, at a minimum.
I think the "hasBroadcast" flag is effectively identical to a hypothetical "stillADraft" flag, so rename it to "shouldBroadcast" to better match its intended behavior.
This just changes labels, not any behavior.
Test Plan: Grepped for `hasBroadcast` and `HAS_BROADCAST`.
Maniphest Tasks: T13110
Differential Revision: https://secure.phabricator.com/D19283
+9
-7
+2
-2
src/applications/differential/editor/DifferentialTransactionEditor.php
+2
-2
src/applications/differential/editor/DifferentialTransactionEditor.php
···
1597
1597
$was_draft = $this->wasDraft;
1598
1598
1599
1599
if (!$object->isDraft() && ($was_draft || $is_new)) {
1600
-
if (!$object->getHasBroadcast()) {
1600
+
if (!$object->getShouldBroadcast()) {
1601
1601
// Mark this as the first broadcast we're sending about the revision
1602
1602
// so mail can generate specially.
1603
1603
$this->firstBroadcast = true;
1604
1604
1605
1605
$object
1606
-
->setHasBroadcast(true)
1606
+
->setShouldBroadcast(true)
1607
1607
->save();
1608
1608
}
1609
1609
}
+7
-5
src/applications/differential/storage/DifferentialRevision.php
+7
-5
src/applications/differential/storage/DifferentialRevision.php
···
59
59
60
60
const PROPERTY_CLOSED_FROM_ACCEPTED = 'wasAcceptedBeforeClose';
61
61
const PROPERTY_DRAFT_HOLD = 'draft.hold';
62
-
const PROPERTY_HAS_BROADCAST = 'draft.broadcast';
62
+
const PROPERTY_SHOULD_BROADCAST = 'draft.broadcast';
63
63
const PROPERTY_LINES_ADDED = 'lines.added';
64
64
const PROPERTY_LINES_REMOVED = 'lines.removed';
65
65
const PROPERTY_BUILDABLES = 'buildables';
···
717
717
return $this->setProperty(self::PROPERTY_DRAFT_HOLD, $hold);
718
718
}
719
719
720
-
public function getHasBroadcast() {
721
-
return $this->getProperty(self::PROPERTY_HAS_BROADCAST, false);
720
+
public function getShouldBroadcast() {
721
+
return $this->getProperty(self::PROPERTY_SHOULD_BROADCAST, false);
722
722
}
723
723
724
-
public function setHasBroadcast($has_broadcast) {
725
-
return $this->setProperty(self::PROPERTY_HAS_BROADCAST, $has_broadcast);
724
+
public function setShouldBroadcast($should_broadcast) {
725
+
return $this->setProperty(
726
+
self::PROPERTY_SHOULD_BROADCAST,
727
+
$should_broadcast);
726
728
}
727
729
728
730
public function setAddedLineCount($count) {