@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue where certain configurations could fail to publish revision feed stories
Summary: See PHI292. This is just a generalization of D18851: feed stories have the same issue as mail. Don't hide "requested a review" in either mail or feed.
Test Plan:
- Enable prototypes.
- No harbormaster builds.
- Create a revision.
- Pre-patch: no feed story.
- Post-patch: feed story.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18886
+7
-6
+7
-6
src/applications/differential/storage/DifferentialTransaction.php
+7
-6
src/applications/differential/storage/DifferentialTransaction.php
···
100
100
return true;
101
101
}
102
102
break;
103
+
case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
104
+
// Don't hide the initial "X requested review: ..." transaction from
105
+
// mail or feed even when it occurs during creation. We need this
106
+
// transaction to survive so we'll generate mail and feed stories when
107
+
// revisions immediately leave the draft state. See T13035 for
108
+
// discussion.
109
+
return false;
103
110
}
104
111
105
112
return parent::shouldHide();
···
110
117
case DifferentialRevisionReviewersTransaction::TRANSACTIONTYPE:
111
118
// Don't hide the initial "X added reviewers: ..." transaction during
112
119
// object creation from mail. See T12118 and PHI54.
113
-
return false;
114
-
case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
115
-
// Don't hide the initial "X requested review: ..." transaction from
116
-
// mail even when it occurs during creation. We need this transaction
117
-
// to survive so we'll generate mail when revisions immediately leave
118
-
// the draft state. See T13035 for discussion.
119
120
return false;
120
121
}
121
122