@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Correct a zero-based month tooltip on burnup charts
Summary: See PHI1017. This is a trivial fix even though these burnups are headed toward a grisly fate.
Test Plan: Moused over some January datapoints, saw "1" instead of "0".
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D19967
+15
-11
+8
-8
resources/celerity/map.php
+8
-8
resources/celerity/map.php
···
395
395
'rsrc/js/application/herald/PathTypeahead.js' => 'ad486db3',
396
396
'rsrc/js/application/herald/herald-rule-editor.js' => '0922e81d',
397
397
'rsrc/js/application/maniphest/behavior-batch-selector.js' => 'cffd39b4',
398
-
'rsrc/js/application/maniphest/behavior-line-chart.js' => '3e9da12d',
398
+
'rsrc/js/application/maniphest/behavior-line-chart.js' => 'c8147a20',
399
399
'rsrc/js/application/maniphest/behavior-list-edit.js' => 'c687e867',
400
400
'rsrc/js/application/maniphest/behavior-subpriorityeditor.js' => '8400307c',
401
401
'rsrc/js/application/owners/OwnersPathEditor.js' => '2a8b62d9',
···
614
614
'javelin-behavior-icon-composer' => '38a6cedb',
615
615
'javelin-behavior-launch-icon-composer' => 'a17b84f1',
616
616
'javelin-behavior-lightbox-attachments' => 'c7e748bf',
617
-
'javelin-behavior-line-chart' => '3e9da12d',
617
+
'javelin-behavior-line-chart' => 'c8147a20',
618
618
'javelin-behavior-linked-container' => '74446546',
619
619
'javelin-behavior-maniphest-batch-selector' => 'cffd39b4',
620
620
'javelin-behavior-maniphest-list-editor' => 'c687e867',
···
1200
1200
'javelin-vector',
1201
1201
'javelin-dom',
1202
1202
),
1203
-
'3e9da12d' => array(
1204
-
'javelin-behavior',
1205
-
'javelin-dom',
1206
-
'javelin-vector',
1207
-
'phui-chart-css',
1208
-
),
1209
1203
'3eed1f2b' => array(
1210
1204
'javelin-behavior',
1211
1205
'javelin-stratcom',
···
1949
1943
'javelin-util',
1950
1944
'phuix-icon-view',
1951
1945
'phabricator-busy',
1946
+
),
1947
+
'c8147a20' => array(
1948
+
'javelin-behavior',
1949
+
'javelin-dom',
1950
+
'javelin-vector',
1951
+
'phui-chart-css',
1952
1952
),
1953
1953
'c9749dcd' => array(
1954
1954
'javelin-install',
+3
-2
src/applications/maniphest/controller/ManiphestReportController.php
+3
-2
src/applications/maniphest/controller/ManiphestReportController.php
···
74
74
$table = new ManiphestTransaction();
75
75
$conn = $table->establishConnection('r');
76
76
77
-
$joins = '';
78
-
$create_joins = '';
79
77
if ($project_phid) {
80
78
$joins = qsprintf(
81
79
$conn,
···
91
89
PhabricatorEdgeConfig::TABLE_NAME_EDGE,
92
90
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
93
91
$project_phid);
92
+
} else {
93
+
$joins = qsprintf($conn, '');
94
+
$create_joins = qsprintf($conn, '');
94
95
}
95
96
96
97
$data = queryfx_all(
+4
-1
webroot/rsrc/js/application/maniphest/behavior-line-chart.js
+4
-1
webroot/rsrc/js/application/maniphest/behavior-line-chart.js
···
107
107
.attr('cy', function(d) { return y(d.count); })
108
108
.on('mouseover', function(d) {
109
109
var d_y = d.date.getFullYear();
110
-
var d_m = d.date.getMonth();
110
+
111
+
// NOTE: Javascript months are zero-based. See PHI1017.
112
+
var d_m = d.date.getMonth() + 1;
113
+
111
114
var d_d = d.date.getDate();
112
115
113
116
div