recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Implement PhabricatorApplicationTransactionInterface on PhabricatorUser

Summary: Right now, "Publish" workers for user profile edits (title / blub) can get gummed up in the daemons. Implement the interfaces and provide a Query so they can go through.

Test Plan:
- Made a profile "Title" edit.
- Used `bin/worker execute --id <id>` to see task fail.
- Applied patch.
- Saw task work.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D13213

epriestley 3bb7f362 1a091e52

+37 -1
+3
src/__phutil_library_map__.php
··· 2246 2246 'PhabricatorPeopleRenameController' => 'applications/people/controller/PhabricatorPeopleRenameController.php', 2247 2247 'PhabricatorPeopleSearchEngine' => 'applications/people/query/PhabricatorPeopleSearchEngine.php', 2248 2248 'PhabricatorPeopleTestDataGenerator' => 'applications/people/lipsum/PhabricatorPeopleTestDataGenerator.php', 2249 + 'PhabricatorPeopleTransactionQuery' => 'applications/people/query/PhabricatorPeopleTransactionQuery.php', 2249 2250 'PhabricatorPeopleUserFunctionDatasource' => 'applications/people/typeahead/PhabricatorPeopleUserFunctionDatasource.php', 2250 2251 'PhabricatorPeopleUserPHIDType' => 'applications/people/phid/PhabricatorPeopleUserPHIDType.php', 2251 2252 'PhabricatorPeopleWelcomeController' => 'applications/people/controller/PhabricatorPeopleWelcomeController.php', ··· 5696 5697 'PhabricatorPeopleRenameController' => 'PhabricatorPeopleController', 5697 5698 'PhabricatorPeopleSearchEngine' => 'PhabricatorApplicationSearchEngine', 5698 5699 'PhabricatorPeopleTestDataGenerator' => 'PhabricatorTestDataGenerator', 5700 + 'PhabricatorPeopleTransactionQuery' => 'PhabricatorApplicationTransactionQuery', 5699 5701 'PhabricatorPeopleUserFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource', 5700 5702 'PhabricatorPeopleUserPHIDType' => 'PhabricatorPHIDType', 5701 5703 'PhabricatorPeopleWelcomeController' => 'PhabricatorPeopleController', ··· 6234 6236 'PhabricatorCustomFieldInterface', 6235 6237 'PhabricatorDestructibleInterface', 6236 6238 'PhabricatorSSHPublicKeyInterface', 6239 + 'PhabricatorApplicationTransactionInterface', 6237 6240 ), 6238 6241 'PhabricatorUserBlurbField' => 'PhabricatorUserCustomField', 6239 6242 'PhabricatorUserConfigOptions' => 'PhabricatorApplicationConfigOptions',
+10
src/applications/people/query/PhabricatorPeopleTransactionQuery.php
··· 1 + <?php 2 + 3 + final class PhabricatorPeopleTransactionQuery 4 + extends PhabricatorApplicationTransactionQuery { 5 + 6 + public function getTemplateApplicationTransaction() { 7 + return new PhabricatorUserTransaction(); 8 + } 9 + 10 + }
+24 -1
src/applications/people/storage/PhabricatorUser.php
··· 13 13 PhabricatorPolicyInterface, 14 14 PhabricatorCustomFieldInterface, 15 15 PhabricatorDestructibleInterface, 16 - PhabricatorSSHPublicKeyInterface { 16 + PhabricatorSSHPublicKeyInterface, 17 + PhabricatorApplicationTransactionInterface { 17 18 18 19 const SESSION_TABLE = 'phabricator_session'; 19 20 const NAMETOKEN_TABLE = 'user_nametoken'; ··· 1211 1212 1212 1213 public function getSSHKeyDefaultName() { 1213 1214 return 'id_rsa_phabricator'; 1215 + } 1216 + 1217 + 1218 + /* -( PhabricatorApplicationTransactionInterface )------------------------- */ 1219 + 1220 + 1221 + public function getApplicationTransactionEditor() { 1222 + return new PhabricatorUserProfileEditor(); 1223 + } 1224 + 1225 + public function getApplicationTransactionObject() { 1226 + return $this; 1227 + } 1228 + 1229 + public function getApplicationTransactionTemplate() { 1230 + return new PhabricatorUserTransaction(); 1231 + } 1232 + 1233 + public function willRenderTimeline( 1234 + PhabricatorApplicationTransactionView $timeline, 1235 + AphrontRequest $request) { 1236 + return $timeline; 1214 1237 } 1215 1238 1216 1239 }