@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add a Stacked view for PropertyList
Summary: Turns a Property List into a stacked view like on tablet/mobile. Useful for where text is longer.
Test Plan:
Test a Herald Transcript page
{F148438}
{F148439}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D8891
+27
-7
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
return array(
8
8
'names' =>
9
9
array(
10
-
'core.pkg.css' => '9e7cce62',
10
+
'core.pkg.css' => 'b39b2afb',
11
11
'core.pkg.js' => '417722ff',
12
12
'darkconsole.pkg.js' => 'ca8671ce',
13
13
'differential.pkg.css' => '8a064eb7',
···
138
138
'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
139
139
'rsrc/css/phui/phui-object-item-list-view.css' => '8b459abe',
140
140
'rsrc/css/phui/phui-pinboard-view.css' => '4b346c2a',
141
-
'rsrc/css/phui/phui-property-list-view.css' => 'dbf53b12',
141
+
'rsrc/css/phui/phui-property-list-view.css' => 'c4d44192',
142
142
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
143
143
'rsrc/css/phui/phui-spacing.css' => '042804d6',
144
144
'rsrc/css/phui/phui-status.css' => '2f562399',
···
760
760
'phui-object-box-css' => 'ce92d8ec',
761
761
'phui-object-item-list-view-css' => '8b459abe',
762
762
'phui-pinboard-view-css' => '4b346c2a',
763
-
'phui-property-list-view-css' => 'dbf53b12',
763
+
'phui-property-list-view-css' => 'c4d44192',
764
764
'phui-remarkup-preview-css' => '19ad512b',
765
765
'phui-spacing-css' => '042804d6',
766
766
'phui-status-list-view-css' => '2f562399',
+1
src/applications/herald/controller/HeraldTranscriptController.php
+1
src/applications/herald/controller/HeraldTranscriptController.php
+12
-1
src/view/phui/PHUIPropertyListView.php
+12
-1
src/view/phui/PHUIPropertyListView.php
···
8
8
private $invokedWillRenderEvent;
9
9
private $actionList;
10
10
private $classes = array();
11
+
private $stacked;
11
12
12
13
const ICON_SUMMARY = 'pl-summary';
13
14
const ICON_TESTPLAN = 'pl-testplan';
···
23
24
24
25
public function setActionList(PhabricatorActionListView $list) {
25
26
$this->actionList = $list;
27
+
return $this;
28
+
}
29
+
30
+
public function setStacked($stacked) {
31
+
$this->stacked = $stacked;
26
32
return $this;
27
33
}
28
34
···
158
164
array($value, ' '));
159
165
}
160
166
167
+
$stacked = '';
168
+
if ($this->stacked) {
169
+
$stacked = 'phui-property-list-stacked';
170
+
}
171
+
161
172
$list = phutil_tag(
162
173
'dl',
163
174
array(
164
-
'class' => 'phui-property-list-properties',
175
+
'class' => 'phui-property-list-properties '.$stacked,
165
176
),
166
177
$items);
167
178
+11
-3
webroot/rsrc/css/phui/phui-property-list-view.css
+11
-3
webroot/rsrc/css/phui/phui-property-list-view.css
···
55
55
margin-bottom: 4px;
56
56
}
57
57
58
-
.device .phui-property-list-key {
59
-
padding-left: 8px;
58
+
.device .phui-property-list-key,
59
+
.phui-property-list-properties.phui-property-list-stacked
60
+
.phui-property-list-key {
61
+
padding-left: 12px;
62
+
text-align: left;
63
+
margin-left: 0;
64
+
width: 100%;
60
65
}
61
66
62
67
.phui-property-list-value {
···
71
76
margin-bottom: 4px;
72
77
}
73
78
74
-
.device .phui-property-list-value {
79
+
.device .phui-property-list-value,
80
+
.phui-property-list-properties.phui-property-list-stacked
81
+
.phui-property-list-value {
75
82
padding-left: 16px;
76
83
margin-bottom: 8px;
84
+
width: 100%;
77
85
}
78
86
79
87
.phui-property-list-section-header {