@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use new "%R" escape for csprintf() to produce slightly nicer clone/checkout commands
Summary: Fixes T4175. In cases where the arguments have only always-safe characters, we can produce a more human-readable URI.
Test Plan: Looked at some repositories.
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Maniphest Tasks: T4175
Differential Revision: https://secure.phabricator.com/D8100
+3
-3
+3
-3
src/applications/diffusion/controller/DiffusionRepositoryController.php
+3
-3
src/applications/diffusion/controller/DiffusionRepositoryController.php
···
551
551
switch ($repository->getVersionControlSystem()) {
552
552
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
553
553
$command = csprintf(
554
-
'git clone %s',
554
+
'git clone %R',
555
555
$uri);
556
556
break;
557
557
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
558
558
$command = csprintf(
559
-
'hg clone %s',
559
+
'hg clone %R',
560
560
$uri);
561
561
break;
562
562
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
563
563
$command = csprintf(
564
-
'svn checkout %s %s',
564
+
'svn checkout %R %R',
565
565
$uri,
566
566
$repository->getCloneName());
567
567
break;