@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix paging fatal with flagged objects
Summary: Fixes T13331. Just adds a generic `withIDs()` method to `PhabricatorFlagQuery`.
Test Plan: Flagged > 100 objects, observed fatal attempting to page. Next page loads as expected after fix.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T13331
Differential Revision: https://secure.phabricator.com/D20642
+13
+13
src/applications/flag/query/PhabricatorFlagQuery.php
+13
src/applications/flag/query/PhabricatorFlagQuery.php
···
6
6
const GROUP_COLOR = 'color';
7
7
const GROUP_NONE = 'none';
8
8
9
+
private $ids;
9
10
private $ownerPHIDs;
10
11
private $types;
11
12
private $objectPHIDs;
···
14
15
15
16
private $needHandles;
16
17
private $needObjects;
18
+
19
+
public function withIDs(array $ids) {
20
+
$this->ids = $ids;
21
+
return $this;
22
+
}
17
23
18
24
public function withOwnerPHIDs(array $owner_phids) {
19
25
$this->ownerPHIDs = $owner_phids;
···
125
131
126
132
protected function buildWhereClause(AphrontDatabaseConnection $conn) {
127
133
$where = array();
134
+
135
+
if ($this->ids !== null) {
136
+
$where[] = qsprintf(
137
+
$conn,
138
+
'flag.id IN (%Ld)',
139
+
$this->ids);
140
+
}
128
141
129
142
if ($this->ownerPHIDs) {
130
143
$where[] = qsprintf(