+1 -1

scripts/symbols/generate_php_symbols.php

reviewed

··· 98 98 } 99 99 } 100 100 101 101 - function print_symbol($file, $type, $token, $context=null) { 101 101 + function print_symbol($file, $type, $token, $context = null) { 102 102 $parts = array( 103 103 $context ? $context->getConcreteString() : '', 104 104 // variable tokens are `$name`, not just `name`, so strip the $ off of

+2 -1

src/aphront/configuration/AphrontDefaultApplicationConfiguration.php

reviewed

··· 306 306 array( 307 307 'uri' => $uri, 308 308 'external' => $external, 309 309 - )); 309 309 + ), 310 310 + ); 310 311 } 311 312 312 313 }

+2 -1

src/aphront/console/plugin/DarkConsoleRequestPlugin.php

reviewed

··· 47 47 if (isset($mask[$key])) { 48 48 $rows[] = array( 49 49 $key, 50 50 - phutil_tag('em', array(), '(Masked)')); 50 50 + phutil_tag('em', array(), '(Masked)'), 51 51 + ); 51 52 } else { 52 53 $rows[] = array( 53 54 $key,

+2 -1

src/aphront/response/AphrontFileResponse.php

reviewed

··· 82 82 if ($this->allowOrigins) { 83 83 $headers[] = array( 84 84 'Access-Control-Allow-Origin', 85 85 - implode(',', $this->allowOrigins)); 85 85 + implode(',', $this->allowOrigins), 86 86 + ); 86 87 } 87 88 88 89 $headers = array_merge(parent::getHeaders(), $headers);

+10 -5

src/aphront/response/AphrontResponse.php

reviewed

··· 109 109 if ($this->cacheable) { 110 110 $headers[] = array( 111 111 'Expires', 112 112 - $this->formatEpochTimestampForHTTPHeader(time() + $this->cacheable)); 112 112 + $this->formatEpochTimestampForHTTPHeader(time() + $this->cacheable), 113 113 + ); 113 114 } else { 114 115 $headers[] = array( 115 116 'Cache-Control', 116 116 - 'private, no-cache, no-store, must-revalidate'); 117 117 + 'private, no-cache, no-store, must-revalidate', 118 118 + ); 117 119 $headers[] = array( 118 120 'Pragma', 119 119 - 'no-cache'); 121 121 + 'no-cache', 122 122 + ); 120 123 $headers[] = array( 121 124 'Expires', 122 122 - 'Sat, 01 Jan 2000 00:00:00 GMT'); 125 125 + 'Sat, 01 Jan 2000 00:00:00 GMT', 126 126 + ); 123 127 } 124 128 125 129 if ($this->lastModified) { 126 130 $headers[] = array( 127 131 'Last-Modified', 128 128 - $this->formatEpochTimestampForHTTPHeader($this->lastModified)); 132 132 + $this->formatEpochTimestampForHTTPHeader($this->lastModified), 133 133 + ); 129 134 } 130 135 131 136 // IE has a feature where it may override an explicit Content-Type

+2 -1

src/applications/audit/query/PhabricatorCommitSearchEngine.php

reviewed

··· 82 82 array( 83 83 $auditor_phids, 84 84 $commit_author_phids, 85 85 - $repository_phids)); 85 85 + $repository_phids, 86 86 + )); 86 87 87 88 $handles = id(new PhabricatorHandleQuery()) 88 89 ->setViewer($this->requireViewer())

+2 -1

src/applications/auth/controller/PhabricatorAuthValidateController.php

reviewed

··· 22 22 array( 23 23 pht( 24 24 'Login validation is missing expected parameter ("%s").', 25 25 - 'phusr'))); 25 25 + 'phusr'), 26 26 + )); 26 27 } 27 28 28 29 $expect_phusr = $request->getStr('expect');

+1 -1

src/applications/auth/provider/PhabricatorAuthProvider.php

reviewed

··· 243 243 $image_uri, 244 244 array( 245 245 'name' => $name, 246 246 - 'canCDN' => true 246 246 + 'canCDN' => true, 247 247 )); 248 248 unset($unguarded); 249 249

+2 -1

src/applications/calendar/__tests__/CalendarTimeUtilTestCase.php

reviewed

··· 55 55 'Wednesday', 56 56 'Thursday', 57 57 'Friday', 58 58 - 'Saturday'); 58 58 + 'Saturday', 59 59 + ); 59 60 } 60 61 61 62 }

+2 -1

src/applications/calendar/controller/PhabricatorCalendarViewController.php

reviewed

··· 103 103 phutil_tag( 104 104 'a', 105 105 array( 106 106 - 'href' => $login_uri), 106 106 + 'href' => $login_uri, 107 107 + ), 107 108 pht('Log in')))); 108 109 } 109 110

+6 -3

src/applications/calendar/util/CalendarTimeUtil.php

reviewed

··· 24 24 25 25 return array( 26 26 'start_epoch' => $start_day->format('U'), 27 27 - 'end_epoch' => $end_day->format('U')); 27 27 + 'end_epoch' => $end_day->format('U'), 28 28 + ); 28 29 } 29 30 30 31 public static function getCalendarWeekTimestamps( ··· 56 57 } 57 58 return array( 58 59 'today' => $objects['today'], 59 59 - 'epoch_stamps' => $timestamps); 60 60 + 'epoch_stamps' => $timestamps, 61 61 + ); 60 62 } 61 63 62 64 private static function getStartDateTimeObjects( ··· 80 82 } 81 83 return array( 82 84 'today' => $today, 83 83 - 'start_day' => $start_day); 85 85 + 'start_day' => $start_day, 86 86 + ); 84 87 } 85 88 86 89 }

+12 -10

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

reviewed

··· 120 120 'a', 121 121 array( 122 122 'href' => $href, 123 123 - 'class' => 'timestamp' 123 123 + 'class' => 'timestamp', 124 124 ), 125 125 $timestamp); 126 126 ··· 129 129 $message = phutil_tag( 130 130 'td', 131 131 array( 132 132 - 'class' => 'message' 132 132 + 'class' => 'message', 133 133 ), 134 134 array( 135 135 $timestamp, 136 136 - $message)); 136 136 + $message, 137 137 + )); 137 138 138 139 $out[] = phutil_tag( 139 140 'tr', ··· 142 143 ), 143 144 array( 144 145 $author, 145 145 - $message)); 146 146 + $message, 147 147 + )); 146 148 } 147 149 148 150 $links = array(); ··· 210 212 $table = phutil_tag( 211 213 'table', 212 214 array( 213 213 - 'class' => 'phabricator-chat-log' 215 215 + 'class' => 'phabricator-chat-log', 214 216 ), 215 217 $out); 216 218 217 219 $log = phutil_tag( 218 220 'div', 219 221 array( 220 220 - 'class' => 'phabricator-chat-log-panel' 222 222 + 'class' => 'phabricator-chat-log-panel', 221 223 ), 222 224 $table); 223 225 224 226 $jump_link = phutil_tag( 225 227 'a', 226 228 array( 227 227 - 'href' => '#latest' 229 229 + 'href' => '#latest', 228 230 ), 229 231 pht('Jump to Bottom')." \xE2\x96\xBE"); 230 232 231 233 $jump = phutil_tag( 232 234 'div', 233 235 array( 234 234 - 'class' => 'phabricator-chat-log-jump' 236 236 + 'class' => 'phabricator-chat-log-jump', 235 237 ), 236 238 $jump_link); 237 239 238 240 $jump_target = phutil_tag( 239 241 'div', 240 242 array( 241 241 - 'id' => 'latest' 243 243 + 'id' => 'latest', 242 244 )); 243 245 244 246 $content = phutil_tag( 245 247 'div', 246 248 array( 247 247 - 'class' => 'phabricator-chat-log-wrap' 249 249 + 'class' => 'phabricator-chat-log-wrap', 248 250 ), 249 251 array( 250 252 $jump,

+1 -1

src/applications/conduit/controller/PhabricatorConduitAPIController.php

reviewed

··· 279 279 if (!$session_key) { 280 280 return array( 281 281 'ERR-INVALID-SESSION', 282 282 - 'Session key is not present.' 282 282 + 'Session key is not present.', 283 283 ); 284 284 } 285 285

+3 -3

src/applications/config/check/PhabricatorSetupCheckDaemons.php

reviewed

··· 31 31 'a', 32 32 array( 33 33 'href' => $doc_href, 34 34 - 'target' => '_blank' 34 34 + 'target' => '_blank', 35 35 ), 36 36 pht('Managing Daemons with phd'))); 37 37 ··· 100 100 'a', 101 101 array( 102 102 'href' => '/daemon/', 103 103 - 'target' => '_blank' 103 103 + 'target' => '_blank', 104 104 ), 105 105 pht('Daemon Console')), 106 106 phutil_tag( 107 107 'a', 108 108 array( 109 109 'href' => $doc_href, 110 110 - 'target' => '_blank' 110 110 + 'target' => '_blank', 111 111 ), 112 112 pht('Managing Daemons with phd')), 113 113 phutil_tag('tt', array(), 'PHABRICATOR_ENV'),

+8 -4

src/applications/config/controller/PhabricatorConfigDatabaseIssueController.php

reviewed

··· 25 25 null, 26 26 null, 27 27 null, 28 28 - $issue); 28 28 + $issue, 29 29 + ); 29 30 } 30 31 foreach ($database->getTables() as $table_name => $table) { 31 32 foreach ($table->getLocalIssues() as $issue) { ··· 34 35 $table_name, 35 36 null, 36 37 null, 37 37 - $issue); 38 38 + $issue, 39 39 + ); 38 40 } 39 41 foreach ($table->getColumns() as $column_name => $column) { 40 42 foreach ($column->getLocalIssues() as $issue) { ··· 43 45 $table_name, 44 46 'column', 45 47 $column_name, 46 46 - $issue); 48 48 + $issue, 49 49 + ); 47 50 } 48 51 } 49 52 foreach ($table->getKeys() as $key_name => $key) { ··· 53 56 $table_name, 54 57 'key', 55 58 $key_name, 56 56 - $issue); 59 59 + $issue, 60 60 + ); 57 61 } 58 62 } 59 63 }

+1 -1

src/applications/config/controller/PhabricatorConfigDatabaseStatusController.php

reviewed

··· 372 372 null, 373 373 null, 374 374 null, 375 375 - null 375 375 + null, 376 376 )); 377 377 378 378 $key_rows = array();

+1 -1

src/applications/config/controller/PhabricatorConfigListController.php

reviewed

··· 21 21 22 22 $nav->appendChild( 23 23 array( 24 24 - $box 24 24 + $box, 25 25 )); 26 26 27 27 $crumbs = $this

+1 -1

src/applications/config/editor/PhabricatorConfigEditor.php

reviewed

··· 122 122 ->setNewValue( 123 123 array( 124 124 'deleted' => false, 125 125 - 'value' => $value 125 125 + 'value' => $value, 126 126 )); 127 127 128 128 $editor = id(new PhabricatorConfigEditor())

+2 -2

src/applications/config/option/PhabricatorAuthenticationConfigOptions.php

reviewed

··· 17 17 ->setBoolOptions( 18 18 array( 19 19 pht('Require email verification'), 20 20 - pht("Don't require email verification") 20 20 + pht("Don't require email verification"), 21 21 )) 22 22 ->setSummary( 23 23 pht('Require email verification before a user can log in.')) ··· 77 77 ->setBoolOptions( 78 78 array( 79 79 pht('Allow editing'), 80 80 - pht('Prevent editing') 80 80 + pht('Prevent editing'), 81 81 )) 82 82 ->setSummary( 83 83 pht(

+1 -1

src/applications/config/option/PhabricatorCoreConfigOptions.php

reviewed

··· 94 94 ->setBoolOptions( 95 95 array( 96 96 pht('Enable Prototypes'), 97 97 - pht('Disable Prototypes') 97 97 + pht('Disable Prototypes'), 98 98 )) 99 99 ->setSummary( 100 100 pht(

+14 -7

src/applications/config/option/PhabricatorGarbageCollectorConfigOptions.php

reviewed

··· 16 16 $options = array( 17 17 'gcdaemon.ttl.herald-transcripts' => array( 18 18 30, 19 19 - pht('Number of seconds to retain Herald transcripts for.')), 19 19 + pht('Number of seconds to retain Herald transcripts for.'), 20 20 + ), 20 21 'gcdaemon.ttl.daemon-logs' => array( 21 22 7, 22 22 - pht('Number of seconds to retain Daemon logs for.')), 23 23 + pht('Number of seconds to retain Daemon logs for.'), 24 24 + ), 23 25 'gcdaemon.ttl.differential-parse-cache' => array( 24 26 14, 25 25 - pht('Number of seconds to retain Differential parse caches for.')), 27 27 + pht('Number of seconds to retain Differential parse caches for.'), 28 28 + ), 26 29 'gcdaemon.ttl.markup-cache' => array( 27 30 30, 28 28 - pht('Number of seconds to retain Markup cache entries for.')), 31 31 + pht('Number of seconds to retain Markup cache entries for.'), 32 32 + ), 29 33 'gcdaemon.ttl.task-archive' => array( 30 34 14, 31 31 - pht('Number of seconds to retain archived background tasks for.')), 35 35 + pht('Number of seconds to retain archived background tasks for.'), 36 36 + ), 32 37 'gcdaemon.ttl.general-cache' => array( 33 38 30, 34 34 - pht('Number of seconds to retain general cache entries for.')), 39 39 + pht('Number of seconds to retain general cache entries for.'), 40 40 + ), 35 41 'gcdaemon.ttl.conduit-logs' => array( 36 42 180, 37 37 - pht('Number of seconds to retain Conduit call logs for.')) 43 43 + pht('Number of seconds to retain Conduit call logs for.'), 44 44 + ), 38 45 ); 39 46 40 47 $result = array();

+1 -1

src/applications/config/option/PhabricatorSMSConfigOptions.php

reviewed

··· 48 48 ->setDescription(pht('Authorization token from Twilio service.')) 49 49 ->setLocked(true) 50 50 ->setHidden(true) 51 51 - ->addExample('f3jsi4i67wiwt6w54hf2zwvy3fjf5h', pht('30 characters')) 51 51 + ->addExample('f3jsi4i67wiwt6w54hf2zwvy3fjf5h', pht('30 characters')), 52 52 ); 53 53 } 54 54

+2 -2

src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php

reviewed

··· 15 15 return array( 16 16 'title' => 'optional string', 17 17 'message' => 'required string', 18 18 - 'participantPHIDs' => 'required list<phids>' 18 18 + 'participantPHIDs' => 'required list<phids>', 19 19 ); 20 20 } 21 21 ··· 28 28 'ERR_EMPTY_PARTICIPANT_PHIDS' => pht( 29 29 'You must specify participant phids.'), 30 30 'ERR_EMPTY_MESSAGE' => pht( 31 31 - 'You must specify a message.') 31 31 + 'You must specify a message.'), 32 32 ); 33 33 } 34 34

+3 -2

src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php

reviewed

··· 20 20 'ids' => 'optional array<int>', 21 21 'phids' => 'optional array<phids>', 22 22 'limit' => 'optional int', 23 23 - 'offset' => 'optional int' 23 23 + 'offset' => 'optional int', 24 24 ); 25 25 } 26 26 ··· 78 78 'messageCount' => $conpherence->getMessageCount(), 79 79 'recentParticipantPHIDs' => $conpherence->getRecentParticipantPHIDs(), 80 80 'filePHIDs' => $conpherence->getFilePHIDs(), 81 81 - 'conpherenceURI' => $this->getConpherenceURI($conpherence)); 81 81 + 'conpherenceURI' => $this->getConpherenceURI($conpherence), 82 82 + ); 82 83 } 83 84 return $data; 84 85 }

+4 -3

src/applications/conpherence/conduit/ConpherenceQueryTransactionConduitAPIMethod.php

reviewed

··· 20 20 'threadID' => 'optional int', 21 21 'threadPHID' => 'optional phid', 22 22 'limit' => 'optional int', 23 23 - 'offset' => 'optional int' 23 23 + 'offset' => 'optional int', 24 24 ); 25 25 } 26 26 ··· 32 32 return array( 33 33 'ERR_USAGE_NO_THREAD_ID' => pht( 34 34 'You must specify a thread id or thread phid to query transactions '. 35 35 - 'from.') 35 35 + 'from.'), 36 36 ); 37 37 } 38 38 ··· 88 88 'authorPHID' => $transaction->getAuthorPHID(), 89 89 'dateCreated' => $transaction->getDateCreated(), 90 90 'conpherenceID' => $conpherence->getID(), 91 91 - 'conpherencePHID' => $conpherence->getPHID()); 91 91 + 'conpherencePHID' => $conpherence->getPHID(), 92 92 + ); 92 93 } 93 94 return $data; 94 95 }

+2 -2

src/applications/conpherence/conduit/ConpherenceUpdateThreadConduitAPIMethod.php

reviewed

··· 18 18 'title' => 'optional string', 19 19 'message' => 'optional string', 20 20 'addParticipantPHIDs' => 'optional list<phids>', 21 21 - 'removeParticipantPHID' => 'optional phid' 21 21 + 'removeParticipantPHID' => 'optional phid', 22 22 ); 23 23 } 24 24 ··· 36 36 'ERR_USAGE_ONLY_SELF_REMOVE' => pht( 37 37 'Only a user can remove themselves from a thread.'), 38 38 'ERR_USAGE_NO_UPDATES' => pht( 39 39 - 'You must specify data that actually updates the conpherence.') 39 39 + 'You must specify data that actually updates the conpherence.'), 40 40 ); 41 41 } 42 42

+3 -2

src/applications/conpherence/controller/ConpherenceController.php

reviewed

··· 70 70 phutil_tag( 71 71 'div', 72 72 array( 73 73 - 'class' => 'header-loading-mask' 73 73 + 'class' => 'header-loading-mask', 74 74 ), 75 75 ''), 76 76 - $crumbs)); 76 76 + $crumbs, 77 77 + )); 77 78 } 78 79 79 80 protected function renderConpherenceTransactions(

+2 -1

src/applications/conpherence/controller/ConpherenceListController.php

reviewed

··· 140 140 $phids = array_keys($participation); 141 141 $content = array( 142 142 'html' => $thread_html, 143 143 - 'phids' => $phids); 143 143 + 'phids' => $phids, 144 144 + ); 144 145 $response = id(new AphrontAjaxResponse())->setContent($content); 145 146 break; 146 147 case self::UNSELECTED_MODE:

+3 -3

src/applications/conpherence/controller/ConpherenceViewController.php

reviewed

··· 72 72 $content = array( 73 73 'header' => $header, 74 74 'messages' => $messages, 75 75 - 'form' => $form 75 75 + 'form' => $form, 76 76 ); 77 77 } 78 78 ··· 114 114 'sigil' => 'show-older-messages', 115 115 'class' => 'conpherence-show-older-messages', 116 116 'meta' => array( 117 117 - 'oldest_transaction_id' => $oldest_transaction_id 118 118 - ) 117 117 + 'oldest_transaction_id' => $oldest_transaction_id, 118 118 + ), 119 119 ), 120 120 pht('Show Older Messages')); 121 121 }

+24 -22

src/applications/conpherence/controller/ConpherenceWidgetController.php

reviewed

··· 100 100 'class' => 'widgets-body', 101 101 'id' => 'widgets-files', 102 102 'sigil' => 'widgets-files', 103 103 - 'style' => 'display: none;' 103 103 + 'style' => 'display: none;', 104 104 ), 105 105 id(new ConpherenceFileWidgetView()) 106 106 ->setUser($user) ··· 111 111 array( 112 112 'class' => 'widgets-body', 113 113 'id' => 'widgets-calendar', 114 114 - 'style' => 'display: none;' 114 114 + 'style' => 'display: none;', 115 115 ), 116 116 $this->renderCalendarWidgetPaneContent()); 117 117 $widgets[] = phutil_tag( ··· 119 119 array( 120 120 'class' => 'widgets-body', 121 121 'id' => 'widgets-settings', 122 122 - 'style' => 'display: none' 122 122 + 'style' => 'display: none', 123 123 ), 124 124 $this->renderSettingsWidgetPaneContent()); 125 125 ··· 166 166 array( 167 167 'type' => 'hidden', 168 168 'name' => 'action', 169 169 - 'value' => 'notifications' 169 169 + 'value' => 'notifications', 170 170 )), 171 171 phutil_tag( 172 172 'button', ··· 174 174 'type' => 'submit', 175 175 'class' => 'notifications-update', 176 176 ), 177 177 - pht('Save')) 177 177 + pht('Save')), 178 178 ); 179 179 180 180 return phabricator_form( ··· 222 222 $content[] = phutil_tag( 223 223 'div', 224 224 array( 225 225 - 'class' => 'day-header '.$active_class 225 225 + 'class' => 'day-header '.$active_class, 226 226 ), 227 227 array( 228 228 phutil_tag( 229 229 'div', 230 230 array( 231 231 - 'class' => 'day-name' 231 231 + 'class' => 'day-name', 232 232 ), 233 233 $day->format('l')), 234 234 phutil_tag( 235 235 'div', 236 236 array( 237 237 - 'class' => 'day-date' 237 237 + 'class' => 'day-date', 238 238 ), 239 239 - $day->format('m/d/y')))); 239 239 + $day->format('m/d/y')), 240 240 + )); 240 241 } 241 242 242 243 $week_day_number = $day->format('w'); ··· 298 299 phutil_tag( 299 300 'div', 300 301 array( 301 301 - 'class' => 'description' 302 302 + 'class' => 'description', 302 303 ), 303 304 array( 304 305 $status->getTerseSummary($user), 305 306 phutil_tag( 306 307 'div', 307 308 array( 308 308 - 'class' => 'participant' 309 309 + 'class' => 'participant', 309 310 ), 310 310 - $secondary_info))))); 311 311 + $secondary_info), 312 312 + )), 313 313 + )); 311 314 } 312 315 $first_status_of_the_day = false; 313 316 } ··· 332 335 $inner_layout[] = phutil_tag( 333 336 'div', 334 337 array( 335 335 - 'class' => $status->getTextStatus() 338 338 + 'class' => $status->getTextStatus(), 336 339 ), 337 340 ''); 338 341 } else { 339 342 $inner_layout[] = phutil_tag( 340 343 'div', 341 344 array( 342 342 - 'class' => 'present' 345 345 + 'class' => 'present', 343 346 ), 344 347 ''); 345 348 } ··· 348 351 phutil_tag( 349 352 'div', 350 353 array( 351 351 - 'class' => 'day-column'.$active_class 354 354 + 'class' => 'day-column'.$active_class, 352 355 ), 353 356 array( 354 357 phutil_tag( 355 358 'div', 356 359 array( 357 357 - 'class' => 'day-name' 360 360 + 'class' => 'day-name', 358 361 ), 359 362 $day->format('D')), 360 363 phutil_tag( ··· 363 366 'class' => 'day-number', 364 367 ), 365 368 $day->format('j')), 366 366 - $inner_layout 369 369 + $inner_layout, 367 370 ))); 368 371 $calendar_columns++; 369 372 } 370 373 } 371 374 372 372 - return 373 373 - array( 374 374 - $layout, 375 375 - $content 376 376 - ); 375 375 + return array( 376 376 + $layout, 377 377 + $content, 378 378 + ); 377 379 } 378 380 379 381 private function getWidgetURI() {

+1 -1

src/applications/conpherence/query/ConpherenceThreadQuery.php

reviewed

··· 279 279 $widget_data = array( 280 280 'statuses' => $statuses, 281 281 'files' => $conpherence_files, 282 282 - 'files_authors' => $files_authors 282 282 + 'files_authors' => $files_authors, 283 283 ); 284 284 $conpherence->attachWidgetData($widget_data); 285 285 }

+6 -5

src/applications/conpherence/view/ConpherenceFileWidgetView.php

reviewed

··· 15 15 $icon_view = phutil_tag( 16 16 'div', 17 17 array( 18 18 - 'class' => 'file-icon sprite-docs '.$icon_class 18 18 + 'class' => 'file-icon sprite-docs '.$icon_class, 19 19 ), 20 20 ''); 21 21 $file_view = id(new PhabricatorFileLinkView()) ··· 41 41 $who_done_it = phutil_tag( 42 42 'div', 43 43 array( 44 44 - 'class' => 'file-uploaded-by' 44 44 + 'class' => 'file-uploaded-by', 45 45 ), 46 46 pht('%s%s.', $who_done_it_text, $date_text)); 47 47 48 48 $files_html[] = phutil_tag( 49 49 'div', 50 50 array( 51 51 - 'class' => 'file-entry' 51 51 + 'class' => 'file-entry', 52 52 ), 53 53 array( 54 54 $icon_view, 55 55 $file_view, 56 56 - $who_done_it 56 56 + $who_done_it, 57 57 )); 58 58 } 59 59 ··· 62 62 'div', 63 63 array( 64 64 'class' => 'no-files', 65 65 - 'sigil' => 'no-files'), 65 65 + 'sigil' => 'no-files', 66 66 + ), 66 67 pht('No files.')); 67 68 } 68 69

+18 -16

src/applications/conpherence/view/ConpherenceLayoutView.php

reviewed

··· 83 83 'name' => pht('Thread'), 84 84 'icon' => 'fa-comment', 85 85 'deviceOnly' => true, 86 86 - 'hasCreate' => false 86 86 + 'hasCreate' => false, 87 87 ), 88 88 'widgets-people' => array( 89 89 'name' => pht('Participants'), ··· 93 93 'createData' => array( 94 94 'refreshFromResponse' => true, 95 95 'action' => ConpherenceUpdateActions::ADD_PERSON, 96 96 - 'customHref' => null 97 97 - ) 96 96 + 'customHref' => null, 97 97 + ), 98 98 ), 99 99 'widgets-files' => array( 100 100 'name' => pht('Files'), 101 101 'icon' => 'fa-files-o', 102 102 'deviceOnly' => false, 103 103 - 'hasCreate' => false 103 103 + 'hasCreate' => false, 104 104 ), 105 105 'widgets-calendar' => array( 106 106 'name' => pht('Calendar'), ··· 110 110 'createData' => array( 111 111 'refreshFromResponse' => false, 112 112 'action' => ConpherenceUpdateActions::ADD_STATUS, 113 113 - 'customHref' => '/calendar/event/create/' 114 114 - ) 113 113 + 'customHref' => '/calendar/event/create/', 114 114 + ), 115 115 ), 116 116 'widgets-settings' => array( 117 117 'name' => pht('Settings'), 118 118 'icon' => 'fa-wrench', 119 119 'deviceOnly' => false, 120 120 - 'hasCreate' => false 120 120 + 'hasCreate' => false, 121 121 ), 122 122 - ))); 122 122 + ), 123 123 + )); 123 124 124 125 125 126 return javelin_tag( ··· 170 171 phutil_tag( 171 172 'div', 172 173 array( 173 173 - 'class' => 'text' 174 174 + 'class' => 'text', 174 175 ), 175 176 pht('You do not have any messages yet.')), 176 177 javelin_tag( ··· 180 181 'class' => 'button grey', 181 182 'sigil' => 'workflow', 182 183 ), 183 183 - pht('Send a Message')) 184 184 + pht('Send a Message')), 184 185 )), 185 186 javelin_tag( 186 187 'div', ··· 193 194 phutil_tag( 194 195 'div', 195 196 array( 196 196 - 'class' => 'widgets-loading-mask' 197 197 + 'class' => 'widgets-loading-mask', 197 198 ), 198 199 ''), 199 200 javelin_tag( 200 201 'div', 201 202 array( 202 202 - 'sigil' => 'conpherence-widgets-holder' 203 203 + 'sigil' => 'conpherence-widgets-holder', 203 204 ), 204 204 - ''))), 205 205 + ''), 206 206 + )), 205 207 javelin_tag( 206 208 'div', 207 209 array( 208 210 'class' => 'conpherence-message-pane', 209 211 'id' => 'conpherence-message-pane', 210 210 - 'sigil' => 'conpherence-message-pane' 212 212 + 'sigil' => 'conpherence-message-pane', 211 213 ), 212 214 array( 213 215 javelin_tag( ··· 228 230 'div', 229 231 array( 230 232 'id' => 'conpherence-form', 231 231 - 'sigil' => 'conpherence-form' 233 233 + 'sigil' => 'conpherence-form', 232 234 ), 233 233 - nonempty($this->replyForm, '')) 235 235 + nonempty($this->replyForm, '')), 234 236 )), 235 237 )), 236 238 ));

+2 -2

src/applications/conpherence/view/ConpherenceMenuItemView.php

reviewed

··· 77 77 'span', 78 78 array( 79 79 'class' => 'conpherence-menu-item-image', 80 80 - 'style' => 'background-image: url('.$this->imageURI.');' 80 80 + 'style' => 'background-image: url('.$this->imageURI.');', 81 81 ), 82 82 ''); 83 83 } ··· 104 104 $unread_count = phutil_tag( 105 105 'span', 106 106 array( 107 107 - 'class' => 'conpherence-menu-item-unread-count' 107 107 + 'class' => 'conpherence-menu-item-unread-count', 108 108 ), 109 109 (int)$this->unreadCount); 110 110 }

+5 -4

src/applications/conpherence/view/ConpherencePeopleWidgetView.php

reviewed

··· 25 25 'meta' => array( 26 26 'remove_person' => $handle->getPHID(), 27 27 'action' => 'remove_person', 28 28 - ) 28 28 + ), 29 29 ), 30 30 hsprintf('<span class="close-icon">&times;</span>')); 31 31 } 32 32 $body[] = phutil_tag( 33 33 'div', 34 34 array( 35 35 - 'class' => 'person-entry grouped' 35 35 + 'class' => 'person-entry grouped', 36 36 ), 37 37 array( 38 38 phutil_tag( ··· 43 43 phutil_tag( 44 44 'img', 45 45 array( 46 46 - 'src' => $handle->getImageURI() 46 46 + 'src' => $handle->getImageURI(), 47 47 ), 48 48 '')), 49 49 $handle->renderLink(), 50 50 - $remove_html)); 50 50 + $remove_html, 51 51 + )); 51 52 } 52 53 53 54 return $body;

+3 -2

src/applications/conpherence/view/ConpherenceThreadListView.php

reviewed

··· 148 148 'participant_id' => $participant->getID(), 149 149 'conpherence_phid' => $participant->getConpherencePHID(), 150 150 'date_touched' => $participant->getDateTouched(), 151 151 - 'direction' => $direction)); 151 151 + 'direction' => $direction, 152 152 + )); 152 153 return $item; 153 154 } 154 155 ··· 156 157 $message = phutil_tag( 157 158 'div', 158 159 array( 159 159 - 'class' => 'no-conpherences-menu-item' 160 160 + 'class' => 'no-conpherences-menu-item', 160 161 ), 161 162 pht('No conpherences.')); 162 163

+4 -3

src/applications/conpherence/view/ConpherenceTransactionView.php

reviewed

··· 38 38 return phutil_tag( 39 39 'div', 40 40 array( 41 41 - 'class' => 'date-marker' 41 41 + 'class' => 'date-marker', 42 42 ), 43 43 array( 44 44 phutil_tag( ··· 49 49 phabricator_format_local_time( 50 50 $transaction->getDateCreated(), 51 51 $user, 52 52 - 'M jS, Y')))); 52 52 + 'M jS, Y')), 53 53 + )); 53 54 break; 54 55 } 55 56 ··· 92 93 phutil_tag( 93 94 'div', 94 95 array( 95 95 - 'class' => $content_class 96 96 + 'class' => $content_class, 96 97 ), 97 98 $content)); 98 99

+1 -1

src/applications/countdown/application/PhabricatorCountdownApplication.php

reviewed

··· 43 43 => 'PhabricatorCountdownListController', 44 44 '(?P<id>[1-9]\d*)/' => 'PhabricatorCountdownViewController', 45 45 'edit/(?:(?P<id>[1-9]\d*)/)?' => 'PhabricatorCountdownEditController', 46 46 - 'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorCountdownDeleteController' 46 46 + 'delete/(?P<id>[1-9]\d*)/' => 'PhabricatorCountdownDeleteController', 47 47 ), 48 48 ); 49 49 }

+2 -1

src/applications/dashboard/controller/PhabricatorDashboardInstallController.php

reviewed

··· 52 52 53 53 $handles = $this->loadHandles(array( 54 54 $object_phid, 55 55 - $installer_phid)); 55 55 + $installer_phid, 56 56 + )); 56 57 57 58 if ($request->isFormPost()) { 58 59 $dashboard_install = id(new PhabricatorDashboardInstall())

+2 -2

src/applications/dashboard/customfield/PhabricatorDashboardPanelSearchQueryCustomField.php

reviewed

··· 52 52 'options' => $queries, 53 53 'value' => array( 54 54 'key' => strlen($value) ? $value : null, 55 55 - 'name' => $name 56 56 - ) 55 55 + 'name' => $name, 56 56 + ), 57 57 )); 58 58 59 59 return id(new AphrontFormSelectControl())

+6 -3

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

reviewed

··· 193 193 'id' => $id, 194 194 'sigil' => 'dashboard-panel', 195 195 'meta' => array( 196 196 - 'objectPHID' => $panel->getPHID()), 197 197 - 'class' => 'dashboard-panel'), 196 196 + 'objectPHID' => $panel->getPHID(), 197 197 + ), 198 198 + 'class' => 'dashboard-panel', 199 199 + ), 198 200 array( 199 201 $header, 200 200 - $content)); 202 202 + $content, 203 203 + )); 201 204 } 202 205 203 206

+3 -2

src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php

reviewed

··· 120 120 case self::MODE_THIRDS_AND_THIRD: 121 121 return array( 122 122 0 => pht('Left'), 123 123 - 1 => pht('Right')); 123 123 + 1 => pht('Right'), 124 124 + ); 124 125 break; 125 126 case self::MODE_FULL: 126 127 throw new Exception('There is only one column in mode full.'); ··· 156 157 public function toDictionary() { 157 158 return array( 158 159 'layoutMode' => $this->getLayoutMode(), 159 159 - 'panelLocations' => $this->getPanelLocations() 160 160 + 'panelLocations' => $this->getPanelLocations(), 160 161 ); 161 162 } 162 163

+8 -4

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

reviewed

··· 60 60 $installs = id(new PhabricatorDashboardInstall()) 61 61 ->loadAllWhere( 62 62 'objectPHID IN (%Ls) AND dashboardPHID IN (%Ls)', 63 63 - array(PhabricatorHomeApplication::DASHBOARD_DEFAULT, 64 64 - $viewer->getPHID()), 63 63 + array( 64 64 + PhabricatorHomeApplication::DASHBOARD_DEFAULT, 65 65 + $viewer->getPHID(), 66 66 + ), 65 67 array_keys($dashboards)); 66 68 $installs = mpull($installs, null, 'getDashboardPHID'); 67 69 } else { ··· 87 89 if ($install->getObjectPHID() == $viewer->getPHID()) { 88 90 $attrs = array( 89 91 'tip' => pht( 90 90 - 'This dashboard is installed to your personal homepage.')); 92 92 + 'This dashboard is installed to your personal homepage.'), 93 93 + ); 91 94 $item->addIcon('fa-user', pht('Installed'), $attrs); 92 95 } else { 93 96 $attrs = array( 94 97 'tip' => pht( 95 95 - 'This dashboard is the default homepage for all users.')); 98 98 + 'This dashboard is the default homepage for all users.'), 99 99 + ); 96 100 $item->addIcon('fa-globe', pht('Installed'), $attrs); 97 101 } 98 102 }

+1 -1

src/applications/differential/conduit/DifferentialCreateInlineConduitAPIMethod.php

reviewed

··· 33 33 'ERR-BAD-DIFF' => 'Bad diff ID, or diff does not belong to revision.', 34 34 'ERR-NEED-DIFF' => 'Neither revision ID nor diff ID was provided.', 35 35 'ERR-NEED-FILE' => 'A file path was not provided.', 36 36 - 'ERR-BAD-FILE' => "Requested file doesn't exist in this revision." 36 36 + 'ERR-BAD-FILE' => "Requested file doesn't exist in this revision.", 37 37 ); 38 38 } 39 39

+4 -2

src/applications/differential/conduit/DifferentialFinishPostponedLintersConduitAPIMethod.php

reviewed

··· 101 101 array( 102 102 'diff_id' => $diff_id, 103 103 'name' => 'arc:lint', 104 104 - 'data' => json_encode($messages))); 104 104 + 'data' => json_encode($messages), 105 105 + )); 105 106 $call->setForceLocal(true); 106 107 $call->setUser($request->getUser()); 107 108 $call->execute(); ··· 110 111 array( 111 112 'diff_id' => $diff_id, 112 113 'name' => 'arc:lint-postponed', 113 113 - 'data' => json_encode($postponed_linters))); 114 114 + 'data' => json_encode($postponed_linters), 115 115 + )); 114 116 $call->setForceLocal(true); 115 117 $call->setUser($request->getUser()); 116 118 $call->execute();

+1 -1

src/applications/differential/conduit/DifferentialGetRevisionConduitAPIMethod.php

reviewed

··· 94 94 'reviewerPHIDs' => $reviewer_phids, 95 95 'diffs' => $diff_dicts, 96 96 'commits' => $commit_dicts, 97 97 - 'auxiliary' => idx($field_data, $revision->getPHID(), array()) 97 97 + 'auxiliary' => idx($field_data, $revision->getPHID(), array()), 98 98 ); 99 99 100 100 return $dict;

+4 -2

src/applications/differential/conduit/DifferentialUpdateUnitResultsConduitAPIMethod.php

reviewed

··· 115 115 DifferentialUnitTestResult::RESULT_SKIP => 116 116 DifferentialUnitStatus::UNIT_OKAY, 117 117 DifferentialUnitTestResult::RESULT_POSTPONED => 118 118 - DifferentialUnitStatus::UNIT_POSTPONED); 118 118 + DifferentialUnitStatus::UNIT_POSTPONED, 119 119 + ); 119 120 120 121 // These are the relative priorities for the unit test results 121 122 $status_codes_priority = ··· 123 124 DifferentialUnitStatus::UNIT_OKAY => 1, 124 125 DifferentialUnitStatus::UNIT_WARN => 2, 125 126 DifferentialUnitStatus::UNIT_POSTPONED => 3, 126 126 - DifferentialUnitStatus::UNIT_FAIL => 4); 127 127 + DifferentialUnitStatus::UNIT_FAIL => 4, 128 128 + ); 127 129 128 130 // Walk the now-current list of status codes to find the overall diff 129 131 // status

+2 -2

src/applications/differential/controller/DifferentialRevisionLandController.php

reviewed

··· 145 145 $looksoon = new ConduitCall( 146 146 'diffusion.looksoon', 147 147 array( 148 148 - 'callsigns' => array($repository->getCallsign()) 149 149 - )); 148 148 + 'callsigns' => array($repository->getCallsign()), 149 149 + )); 150 150 $looksoon->setUser($request->getUser()); 151 151 $looksoon->execute(); 152 152

+1 -1

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

reviewed

··· 328 328 $row = array( 329 329 $readable_key, 330 330 $oval, 331 331 - $nval 331 331 + $nval, 332 332 ); 333 333 $rows[] = $row; 334 334

+4 -4

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

reviewed

··· 25 25 'td', 26 26 array( 27 27 'colspan' => 6, 28 28 - 'class' => 'show-more' 28 28 + 'class' => 'show-more', 29 29 ), 30 30 pht('Context not available.'))); 31 31 } ··· 302 302 array('class' => $n_classes, 'colspan' => $n_colspan), 303 303 array( 304 304 phutil_tag('span', array('class' => 'zwsp'), $zero_space), 305 305 - $n_text 305 305 + $n_text, 306 306 )), 307 307 $n_cov, 308 308 )); ··· 365 365 $old = phutil_tag( 366 366 'div', 367 367 array( 368 368 - 'class' => 'differential-image-stage' 368 368 + 'class' => 'differential-image-stage', 369 369 ), 370 370 phutil_tag( 371 371 'img', ··· 379 379 $new = phutil_tag( 380 380 'div', 381 381 array( 382 382 - 'class' => 'differential-image-stage' 382 382 + 'class' => 'differential-image-stage', 383 383 ), 384 384 phutil_tag( 385 385 'img',

+1 -1

src/applications/differential/storage/DifferentialDiff.php

reviewed

··· 229 229 'lintStatus' => $this->getLintStatus(), 230 230 'changes' => array(), 231 231 'properties' => array(), 232 232 - 'projectName' => $this->getArcanistProjectName() 232 232 + 'projectName' => $this->getArcanistProjectName(), 233 233 ); 234 234 235 235 $dict['changes'] = $this->buildChangesList();

+2 -1

src/applications/differential/view/DifferentialChangesetDetailView.php

reviewed

··· 215 215 $buttons, 216 216 phutil_tag('h1', 217 217 array( 218 218 - 'class' => 'differential-file-icon-header'), 218 218 + 'class' => 'differential-file-icon-header', 219 219 + ), 219 220 array( 220 221 $icon, 221 222 $display_filename,

+3 -2

src/applications/differential/view/DifferentialChangesetListView.php

reviewed

··· 110 110 Javelin::initBehavior('differential-toggle-files', array( 111 111 'pht' => array( 112 112 'undo' => pht('Undo'), 113 113 - 'collapsed' => pht('This file content has been collapsed.')) 114 114 - )); 113 113 + 'collapsed' => pht('This file content has been collapsed.'), 114 114 + ), 115 115 + )); 115 116 Javelin::initBehavior( 116 117 'differential-dropdown-menus', 117 118 array(

+4 -4

src/applications/differential/view/DifferentialDiffTableOfContentsView.php

reviewed

··· 160 160 $meta = phutil_tag( 161 161 'div', 162 162 array( 163 163 - 'class' => 'differential-toc-meta' 163 163 + 'class' => 'differential-toc-meta', 164 164 ), 165 165 $meta); 166 166 } ··· 176 176 $desc, 177 177 array($link, $lines, $meta), 178 178 $cov, 179 179 - $mcov 179 179 + $mcov, 180 180 ); 181 181 } 182 182 ··· 210 210 $buttons = phutil_tag( 211 211 'div', 212 212 array( 213 213 - 'class' => 'differential-toc-buttons grouped' 213 213 + 'class' => 'differential-toc-buttons grouped', 214 214 ), 215 215 array( 216 216 $editor_link, 217 217 - $reveal_link 217 217 + $reveal_link, 218 218 )); 219 219 220 220 $table = id(new AphrontTableView($rows));

+2 -1

src/applications/differential/view/DifferentialLocalCommitsView.php

reviewed

··· 144 144 $link = phutil_tag( 145 145 'a', 146 146 array( 147 147 - 'href' => $commit_for_link->getURI()), 147 147 + 'href' => $commit_for_link->getURI(), 148 148 + ), 148 149 $commit_hash); 149 150 } else { 150 151 $link = $commit_hash;

+1 -1

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

reviewed

··· 314 314 DifferentialLintStatus::LINT_FAIL => self::STAR_FAIL, 315 315 DifferentialLintStatus::LINT_SKIP => self::STAR_SKIP, 316 316 DifferentialLintStatus::LINT_AUTO_SKIP => self::STAR_SKIP, 317 317 - DifferentialLintStatus::LINT_POSTPONED => self::STAR_SKIP 317 317 + DifferentialLintStatus::LINT_POSTPONED => self::STAR_SKIP, 318 318 ); 319 319 320 320 $star = idx($map, $diff->getLintStatus(), self::STAR_FAIL);

+6 -3

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php

reviewed

··· 81 81 if ($path->getTargetPath()) { 82 82 $old = array( 83 83 $path->getTargetPath(), 84 84 - $path->getTargetCommitIdentifier()); 84 84 + $path->getTargetCommitIdentifier(), 85 85 + ); 85 86 } else { 86 87 $old = array($path->getPath(), $path->getCommitIdentifier() - 1); 87 88 } ··· 99 100 case DifferentialChangeType::TYPE_COPY_HERE: 100 101 $old = array( 101 102 $path->getTargetPath(), 102 102 - $path->getTargetCommitIdentifier()); 103 103 + $path->getTargetCommitIdentifier(), 104 104 + ); 103 105 $new = array($path->getPath(), $path->getCommitIdentifier()); 104 106 $old_name = $path->getTargetPath(); 105 107 $new_name = $path->getPath(); ··· 107 109 case DifferentialChangeType::TYPE_MOVE_AWAY: 108 110 $old = array( 109 111 $path->getPath(), 110 110 - $path->getCommitIdentifier() - 1); 112 112 + $path->getCommitIdentifier() - 1, 113 113 + ); 111 114 $old_name = $path->getPath(); 112 115 $new_name = null; 113 116 $new = null;

+1 -1

src/applications/diffusion/conduit/DiffusionExistsQueryConduitAPIMethod.php

reviewed

··· 17 17 18 18 protected function defineCustomParamTypes() { 19 19 return array( 20 20 - 'commit' => 'required string' 20 20 + 'commit' => 'required string', 21 21 ); 22 22 } 23 23

+2 -1

src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php

reviewed

··· 54 54 'offset' => 0, 55 55 'limit' => $limit, 56 56 'needDirectChanges' => true, 57 57 - 'needChildChanges' => true)); 57 57 + 'needChildChanges' => true, 58 58 + )); 58 59 $history = DiffusionPathChange::newFromConduit( 59 60 $history_result['pathChanges']); 60 61

+2 -1

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

reviewed

··· 119 119 foreach ($lowlevel_commitref->getHashes() as $hash) { 120 120 $dict['hashes'][] = array( 121 121 'type' => $hash->getHashType(), 122 122 - 'value' => $hash->getHashValue()); 122 122 + 'value' => $hash->getHashValue(), 123 123 + ); 123 124 } 124 125 } 125 126

+2 -1

src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php

reviewed

··· 42 42 'ERR-UNKNOWN-VCS-TYPE' => 43 43 pht('Unknown repository VCS type.'), 44 44 'ERR-UNSUPPORTED-VCS' => 45 45 - pht('VCS is not supported for this method.')); 45 45 + pht('VCS is not supported for this method.'), 46 46 + ); 46 47 } 47 48 48 49 /**

+2 -1

src/applications/diffusion/conduit/DiffusionRefsQueryConduitAPIMethod.php

reviewed

··· 49 49 array( 50 50 'action' => 'browse', 51 51 'branch' => $ref, 52 52 - ))); 52 52 + )), 53 53 + ); 53 54 } 54 55 55 56 return $ref_links;

+2 -1

src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php

reviewed

··· 27 27 28 28 protected function defineCustomErrorTypes() { 29 29 return array( 30 30 - 'ERR-GREP-COMMAND' => 'Grep command failed.'); 30 30 + 'ERR-GREP-COMMAND' => 'Grep command failed.', 31 31 + ); 31 32 } 32 33 33 34 protected function getResult(ConduitAPIRequest $request) {

+1 -1

src/applications/diffusion/controller/DiffusionBranchTableController.php

reviewed

··· 22 22 'diffusion.branchquery', 23 23 array( 24 24 'offset' => $pager->getOffset(), 25 25 - 'limit' => $pager->getPageSize() + 1 25 25 + 'limit' => $pager->getPageSize() + 1, 26 26 )); 27 27 $branches = $pager->sliceResults($branches); 28 28

+2 -1

src/applications/diffusion/controller/DiffusionBrowseFileController.php

reviewed

··· 1016 1016 array( 1017 1017 'commit' => $drequest->getCommit(), 1018 1018 'path' => $drequest->getPath(), 1019 1019 - 'againstCommit' => $target_commit)); 1019 1019 + 'againstCommit' => $target_commit, 1020 1020 + )); 1020 1021 $old_line = 0; 1021 1022 $new_line = 0; 1022 1023

+1 -1

src/applications/diffusion/controller/DiffusionChangeController.php

reviewed

··· 43 43 $changeset_view->setVisibleChangesets($changesets); 44 44 $changeset_view->setRenderingReferences( 45 45 array( 46 46 - 0 => $drequest->generateURI(array('action' => 'rendering-ref')) 46 46 + 0 => $drequest->generateURI(array('action' => 'rendering-ref')), 47 47 )); 48 48 49 49 $raw_params = array(

+5 -3

src/applications/diffusion/controller/DiffusionCommitController.php

reviewed

··· 796 796 'aphront-panel-preview aphront-panel-flush', 797 797 array( 798 798 phutil_tag('div', array('id' => 'audit-preview'), $loading), 799 799 - phutil_tag('div', array('id' => 'inline-comment-preview')) 799 799 + phutil_tag('div', array('id' => 'inline-comment-preview')), 800 800 )); 801 801 802 802 // TODO: This is pretty awkward, unify the CSS between Diffusion and ··· 911 911 'diffusion.mergedcommitsquery', 912 912 array( 913 913 'commit' => $drequest->getCommit(), 914 914 - 'limit' => $limit + 1)); 914 914 + 'limit' => $limit + 1, 915 915 + )); 915 916 } catch (ConduitException $ex) { 916 917 if ($ex->getMessage() != 'ERR-UNSUPPORTED-VCS') { 917 918 throw $ex; ··· 1026 1027 'diffusion.rawdiffquery', 1027 1028 array( 1028 1029 'commit' => $drequest->getCommit(), 1029 1029 - 'path' => $drequest->getPath())); 1030 1030 + 'path' => $drequest->getPath(), 1031 1031 + )); 1030 1032 1031 1033 $file = PhabricatorFile::buildFromFileDataOrHash( 1032 1034 $raw_diff,

+2 -1

src/applications/diffusion/controller/DiffusionCommitTagsController.php

reviewed

··· 22 22 'diffusion.tagsquery', 23 23 array( 24 24 'commit' => $request->getCommit(), 25 25 - 'limit' => $tag_limit + 1))); 25 25 + 'limit' => $tag_limit + 1, 26 26 + ))); 26 27 } catch (ConduitException $ex) { 27 28 if ($ex->getMessage() != 'ERR-UNSUPPORTED-VCS') { 28 29 throw $ex;

+2 -1

src/applications/diffusion/controller/DiffusionController.php

reviewed

··· 184 184 $divider = phutil_tag( 185 185 'span', 186 186 array( 187 187 - 'class' => 'phui-header-divider'), 187 187 + 'class' => 'phui-header-divider', 188 188 + ), 188 189 '/'); 189 190 190 191 $links = array();

+4 -2

src/applications/diffusion/controller/DiffusionDiffController.php

reviewed

··· 50 50 'diffusion.diffquery', 51 51 array( 52 52 'commit' => $drequest->getCommit(), 53 53 - 'path' => $drequest->getPath())); 53 53 + 'path' => $drequest->getPath(), 54 54 + )); 54 55 $drequest->updateSymbolicCommit($data['effectiveCommit']); 55 56 $raw_changes = ArcanistDiffChange::newFromConduit($data['changes']); 56 57 $diff = DifferentialDiff::newFromRawChanges($raw_changes); ··· 66 67 $parser->setChangeset($changeset); 67 68 $parser->setRenderingReference($drequest->generateURI( 68 69 array( 69 69 - 'action' => 'rendering-ref'))); 70 70 + 'action' => 'rendering-ref', 71 71 + ))); 70 72 71 73 $parser->setCharacterEncoding($request->getStr('encoding')); 72 74 $parser->setHighlightAs($request->getStr('highlight'));

+2 -1

src/applications/diffusion/controller/DiffusionHistoryController.php

reviewed

··· 19 19 'commit' => $drequest->getCommit(), 20 20 'path' => $drequest->getPath(), 21 21 'offset' => $offset, 22 22 - 'limit' => $page_size + 1); 22 22 + 'limit' => $page_size + 1, 23 23 + ); 23 24 24 25 if (!$request->getBool('copies')) { 25 26 $params['needDirectChanges'] = true;

+6 -4

src/applications/diffusion/controller/DiffusionLastModifiedController.php

reviewed

··· 145 145 if ($lint !== null) { 146 146 $return['lint'] = phutil_tag( 147 147 'a', 148 148 - array('href' => $drequest->generateURI(array( 149 149 - 'action' => 'lint', 150 150 - 'lint' => null, 151 151 - ))), 148 148 + array( 149 149 + 'href' => $drequest->generateURI(array( 150 150 + 'action' => 'lint', 151 151 + 'lint' => null, 152 152 + )), 153 153 + ), 152 154 number_format($lint)); 153 155 } 154 156

+16 -11

src/applications/diffusion/controller/DiffusionLintDetailsController.php

reviewed

··· 17 17 foreach ($messages as $message) { 18 18 $path = phutil_tag( 19 19 'a', 20 20 - array('href' => $drequest->generateURI(array( 21 21 - 'action' => 'lint', 22 22 - 'path' => $message['path'], 23 23 - ))), 20 20 + array( 21 21 + 'href' => $drequest->generateURI(array( 22 22 + 'action' => 'lint', 23 23 + 'path' => $message['path'], 24 24 + )), 25 25 + ), 24 26 substr($message['path'], strlen($drequest->getPath()) + 1)); 25 27 26 28 $line = phutil_tag( 27 29 'a', 28 28 - array('href' => $drequest->generateURI(array( 29 29 - 'action' => 'browse', 30 30 - 'path' => $message['path'], 31 31 - 'line' => $message['line'], 32 32 - 'commit' => $branch->getLintCommit(), 33 33 - ))), 30 30 + array( 31 31 + 'href' => $drequest->generateURI(array( 32 32 + 'action' => 'browse', 33 33 + 'path' => $message['path'], 34 34 + 'line' => $message['line'], 35 35 + 'commit' => $branch->getLintCommit(), 36 36 + )), 37 37 + ), 34 38 $message['line']); 35 39 36 40 $author = $message['authorPHID']; ··· 90 94 array( 91 95 pht('Lint'), 92 96 $drequest->getRepository()->getCallsign(), 93 93 - ))); 97 97 + ), 98 98 + )); 94 99 } 95 100 96 101 private function loadLintMessages(

+2 -1

src/applications/diffusion/controller/DiffusionRepositoryController.php

reviewed

··· 96 96 'commit' => $drequest->getCommit(), 97 97 'path' => $drequest->getPath(), 98 98 'offset' => 0, 99 99 - 'limit' => 15)); 99 99 + 'limit' => 15, 100 100 + )); 100 101 $history = DiffusionPathChange::newFromConduit( 101 102 $history_results['pathChanges']); 102 103

+2 -1

src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php

reviewed

··· 144 144 return $this->buildApplicationPage( 145 145 array( 146 146 $crumbs, 147 147 - $object_box), 147 147 + $object_box, 148 148 + ), 148 149 array( 149 150 'title' => $title, 150 151 ));

+2 -1

src/applications/diffusion/controller/DiffusionRepositoryEditHostingController.php

reviewed

··· 186 186 '%s: This repository is hosted elsewhere, so Phabricator can not '. 187 187 'perform writes. This mode will act like "Read Only" for '. 188 188 'repositories hosted elsewhere.', 189 189 - phutil_tag('strong', array(), 'WARNING'))); 189 189 + phutil_tag('strong', array(), 'WARNING')), 190 190 + ); 190 191 } 191 192 192 193 $ssh_control =

+2 -1

src/applications/diffusion/controller/DiffusionTagListController.php

reviewed

··· 19 19 20 20 $params = array( 21 21 'limit' => $pager->getPageSize() + 1, 22 22 - 'offset' => $pager->getOffset()); 22 22 + 'offset' => $pager->getOffset(), 23 23 + ); 23 24 24 25 if ($drequest->getSymbolicCommit()) { 25 26 $is_commit = true;

+2 -1

src/applications/diffusion/data/DiffusionBrowseResultSet.php

reviewed

··· 64 64 'isValidResults' => $this->isValidResults(), 65 65 'reasonForEmptyResultSet' => $this->getReasonForEmptyResultSet(), 66 66 'existedAtCommit' => $this->getExistedAtCommit(), 67 67 - 'deletedAtCommit' => $this->getDeletedAtCommit()); 67 67 + 'deletedAtCommit' => $this->getDeletedAtCommit(), 68 68 + ); 68 69 } 69 70 70 71 public function getPathDicts() {

+1 -1

src/applications/diffusion/data/DiffusionFileContent.php

reviewed

··· 48 48 'corpus' => $this->getCorpus(), 49 49 'blameDict' => $this->getBlameDict(), 50 50 'revList' => $this->getRevList(), 51 51 - 'textList' => $this->getTextList() 51 51 + 'textList' => $this->getTextList(), 52 52 ); 53 53 } 54 54

+2 -1

src/applications/diffusion/data/DiffusionPathChange.php

reviewed

··· 171 171 'changeType' => $this->getChangeType(), 172 172 'targetPath' => $this->getTargetPath(), 173 173 'targetCommitIdentifier' => $this->getTargetCommitIdentifier(), 174 174 - 'awayPaths' => $this->getAwayPaths()); 174 174 + 'awayPaths' => $this->getAwayPaths(), 175 175 + ); 175 176 } 176 177 177 178 public static function newFromConduit(array $dicts) {

+1 -1

src/applications/diffusion/view/DiffusionBranchTableView.php

reviewed

··· 83 83 array( 84 84 'action' => 'history', 85 85 'branch' => $branch->getShortName(), 86 86 - )) 86 86 + )), 87 87 ), 88 88 pht('History')), 89 89 phutil_tag(

+2 -1

src/applications/diffusion/view/DiffusionHistoryTableView.php

reviewed

··· 171 171 'span', 172 172 array( 173 173 'sigil' => 'has-tooltip', 174 174 - 'meta' => array('tip' => $name)), 174 174 + 'meta' => array('tip' => $name), 175 175 + ), 175 176 $icon_view); 176 177 177 178 Javelin::initBehavior('phabricator-tooltips');

+4 -2

src/applications/diviner/controller/DivinerAtomController.php

reviewed

··· 174 174 $item = array( 175 175 $item, 176 176 " \xE2\x80\x94 ", 177 177 - $atom->getSummary()); 177 177 + $atom->getSummary(), 178 178 + ); 178 179 } 179 180 180 181 $list_items[] = phutil_tag('li', array(), $item); ··· 280 281 $items[] = array( 281 282 $this->renderAtomTag($iface), 282 283 " \xE2\x97\x80 ", 283 283 - $this->renderAtomTag($via)); 284 284 + $this->renderAtomTag($via), 285 285 + ); 284 286 } 285 287 } 286 288

+3 -3

src/applications/diviner/view/DivinerBookItemView.php

reviewed

··· 44 44 $title = phutil_tag( 45 45 'span', 46 46 array( 47 47 - 'class' => 'diviner-book-item-title' 47 47 + 'class' => 'diviner-book-item-title', 48 48 ), 49 49 $this->title); 50 50 51 51 $subtitle = phutil_tag( 52 52 'span', 53 53 array( 54 54 - 'class' => 'diviner-book-item-subtitle' 54 54 + 'class' => 'diviner-book-item-subtitle', 55 55 ), 56 56 $this->subtitle); 57 57 58 58 $type = phutil_tag( 59 59 'span', 60 60 array( 61 61 - 'class' => 'diviner-book-item-type' 61 61 + 'class' => 'diviner-book-item-type', 62 62 ), 63 63 $this->type); 64 64

+3 -2

src/applications/diviner/view/DivinerParameterTableView.php

reviewed

··· 67 67 $table = phutil_tag( 68 68 'table', 69 69 array( 70 70 - 'class' => 'diviner-parameter-table-view'), 70 70 + 'class' => 'diviner-parameter-table-view', 71 71 + ), 71 72 $rows); 72 73 73 74 $header = phutil_tag( 74 75 'span', 75 76 array( 76 76 - 'class' => 'diviner-table-header' 77 77 + 'class' => 'diviner-table-header', 77 78 ), 78 79 $this->header); 79 80

+3 -2

src/applications/diviner/view/DivinerReturnTableView.php

reviewed

··· 61 61 $table = phutil_tag( 62 62 'table', 63 63 array( 64 64 - 'class' => 'diviner-return-table-view'), 64 64 + 'class' => 'diviner-return-table-view', 65 65 + ), 65 66 $rows); 66 67 67 68 $header = phutil_tag( 68 69 'span', 69 70 array( 70 70 - 'class' => 'diviner-table-header' 71 71 + 'class' => 'diviner-table-header', 71 72 ), 72 73 $this->header); 73 74

+2 -2

src/applications/doorkeeper/bridge/__tests__/DoorkeeperBridgeJIRATestCase.php

reviewed

··· 8 8 // Installed at domain root. 9 9 'http://jira.example.com/rest/api/2/issue/1', 10 10 'TP-1', 11 11 - 'http://jira.example.com/browse/TP-1' 11 11 + 'http://jira.example.com/browse/TP-1', 12 12 ), 13 13 array( 14 14 // Installed on path. 15 15 'http://jira.example.com/jira/rest/api/2/issue/1', 16 16 'TP-1', 17 17 - 'http://jira.example.com/jira/browse/TP-1' 17 17 + 'http://jira.example.com/jira/browse/TP-1', 18 18 ), 19 19 array( 20 20 // A URI we don't understand.

+1 -1

src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php

reviewed

··· 30 30 'object in Phabricator comes from. For example, you can add code '. 31 31 'reviews in Asana to a "Differential" project.'. 32 32 "\n\n". 33 33 - 'NOTE: This feature is new and experimental.')) 33 33 + 'NOTE: This feature is new and experimental.')), 34 34 ); 35 35 } 36 36

+4 -2

src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php

reviewed

··· 108 108 'host' => $resource->getAttribute('host'), 109 109 'port' => $resource->getAttribute('port'), 110 110 'credential' => $resource->getAttribute('credential'), 111 111 - 'platform' => $resource->getAttribute('platform'))) 111 111 + 'platform' => $resource->getAttribute('platform'), 112 112 + )) 112 113 ->setWorkingDirectory($lease->getAttribute('path')); 113 114 case 'filesystem': 114 115 return id(new DrydockSFTPFilesystemInterface()) 115 116 ->setConfiguration(array( 116 117 'host' => $resource->getAttribute('host'), 117 118 'port' => $resource->getAttribute('port'), 118 118 - 'credential' => $resource->getAttribute('credential'))); 119 119 + 'credential' => $resource->getAttribute('credential'), 120 120 + )); 119 121 } 120 122 121 123 throw new Exception("No interface of type '{$type}'.");

+1 -1

src/applications/fact/management/PhabricatorFactManagementCursorsWorkflow.php

reviewed

··· 17 17 'param' => 'cursor', 18 18 'repeat' => true, 19 19 'help' => 'Reset cursor __cursor__.', 20 20 - ) 20 20 + ), 21 21 )); 22 22 } 23 23

+1 -1

src/applications/feed/conduit/FeedQueryConduitAPIMethod.php

reviewed

··· 128 128 'authorPHID' => $story_data->getAuthorPHID(), 129 129 'chronologicalKey' => $story_data->getChronologicalKey(), 130 130 'objectPHID' => $story->getPrimaryObjectPHID(), 131 131 - 'text' => $story->renderText() 131 131 + 'text' => $story->renderText(), 132 132 ); 133 133 break; 134 134 default:

+1 -1

src/applications/files/PhabricatorImageTransformer.php

reviewed

··· 215 215 'dx' => $dx, 216 216 'dy' => $dy, 217 217 'sdx' => $sdx, 218 218 - 'sdy' => $sdy 218 218 + 'sdy' => $sdy, 219 219 ); 220 220 } 221 221

+1 -1

src/applications/files/config/PhabricatorFilesConfigOptions.php

reviewed

··· 184 184 ->setBoolOptions( 185 185 array( 186 186 pht('Enable'), 187 187 - pht('Disable') 187 187 + pht('Disable'), 188 188 ))->setDescription( 189 189 pht("This option will enable animated gif images". 190 190 "to be set as profile pictures. The 'convert' binary ".

+3 -2

src/applications/files/controller/PhabricatorFileInfoController.php

reviewed

··· 78 78 array( 79 79 $crumbs, 80 80 $object_box, 81 81 - $timeline 81 81 + $timeline, 82 82 ), 83 83 array( 84 84 'title' => $file->getName(), ··· 126 126 127 127 return array( 128 128 $timeline, 129 129 - $add_comment_form); 129 129 + $add_comment_form, 130 130 + ); 130 131 } 131 132 132 133 private function buildActionView(PhabricatorFile $file) {

+2 -1

src/applications/flag/query/PhabricatorFlagSearchEngine.php

reviewed

··· 116 116 // sort it alphabetically... 117 117 asort($options); 118 118 $default_option = array( 119 119 - 0 => pht('All Object Types')); 119 119 + 0 => pht('All Object Types'), 120 120 + ); 120 121 // ...and stick the default option on front 121 122 $options = array_merge($default_option, $options); 122 123

+6 -3

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

reviewed

··· 299 299 'div', 300 300 array( 301 301 'style' => 'display: none', 302 302 - 'id' => $id), 302 302 + 'id' => $id, 303 303 + ), 303 304 $log_box); 304 305 } 305 306 ··· 377 378 $link_100, 378 379 ' - ', 379 380 $link_0, 380 380 - ' Lines')); 381 381 + ' Lines', 382 382 + )); 381 383 } 382 384 383 385 private function buildActionList(HarbormasterBuild $build) { ··· 440 442 ->setViewer($viewer) 441 443 ->withPHIDs(array( 442 444 $build->getBuildablePHID(), 443 443 - $build->getBuildPlanPHID())) 445 445 + $build->getBuildPlanPHID(), 446 446 + )) 444 447 ->execute(); 445 448 446 449 $properties->addProperty(

+4 -2

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

reviewed

··· 391 391 $note = array( 392 392 phutil_tag('strong', array(), pht('ERROR:')), 393 393 ' ', 394 394 - $error); 394 394 + $error, 395 395 + ); 395 396 } else { 396 397 $note = $bound; 397 398 } ··· 457 458 $note = array( 458 459 phutil_tag('strong', array(), pht('ERROR:')), 459 460 ' ', 460 460 - $error); 461 461 + $error, 462 462 + ); 461 463 } else { 462 464 $note = $bound; 463 465 }

+1 -1

src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php

reviewed

··· 94 94 PhabricatorWorker::scheduleTask( 95 95 'HarbormasterBuildWorker', 96 96 array( 97 97 - 'buildID' => $build->getID() 97 97 + 'buildID' => $build->getID(), 98 98 )); 99 99 } 100 100

+2 -1

src/applications/harbormaster/engine/HarbormasterBuildGraph.php

reviewed

··· 33 33 $results[] = array( 34 34 'node' => $steps_by_phid[$node['node']], 35 35 'depth' => $node['depth'], 36 36 - 'cycle' => $node['cycle']); 36 36 + 'cycle' => $node['cycle'], 37 37 + ); 37 38 } 38 39 39 40 return $results;

+2 -1

src/applications/harbormaster/step/HarbormasterLeaseHostBuildStepImplementation.php

reviewed

··· 37 37 $settings['name'], 38 38 HarbormasterBuildArtifact::TYPE_HOST); 39 39 $artifact->setArtifactData(array( 40 40 - 'drydock-lease' => $lease->getID())); 40 40 + 'drydock-lease' => $lease->getID(), 41 41 + )); 41 42 $artifact->save(); 42 43 } 43 44

+2 -1

src/applications/harbormaster/step/HarbormasterUploadArtifactBuildStepImplementation.php

reviewed

··· 45 45 $settings['name'], 46 46 HarbormasterBuildArtifact::TYPE_FILE); 47 47 $artifact->setArtifactData(array( 48 48 - 'filePHID' => $file->getPHID())); 48 48 + 'filePHID' => $file->getPHID(), 49 49 + )); 49 50 $artifact->save(); 50 51 } 51 52

+1 -1

src/applications/harbormaster/step/HarbormasterWaitForPreviousBuildStepImplementation.php

reviewed

··· 60 60 'diffusion.commitparentsquery', 61 61 array( 62 62 'commit' => $commit->getCommitIdentifier(), 63 63 - 'callsign' => $commit->getRepository()->getCallsign() 63 63 + 'callsign' => $commit->getRepository()->getCallsign(), 64 64 )); 65 65 $call->setUser(PhabricatorUser::getOmnipotentUser()); 66 66 $parents = $call->execute();

+1 -1

src/applications/harbormaster/storage/HarbormasterBuildable.php

reviewed

··· 146 146 PhabricatorWorker::scheduleTask( 147 147 'HarbormasterBuildWorker', 148 148 array( 149 149 - 'buildID' => $build->getID() 149 149 + 'buildID' => $build->getID(), 150 150 )); 151 151 152 152 return $build;

+2 -2

src/applications/harbormaster/view/ShellLogView.php

reviewed

··· 95 95 'div', 96 96 array( 97 97 'class' => 'phabricator-source-code-container', 98 98 - 'style' => 'background-color: black; color: white;' 98 98 + 'style' => 'background-color: black; color: white;', 99 99 ), 100 100 phutil_tag( 101 101 'table', 102 102 array( 103 103 'class' => implode(' ', $classes), 104 104 - 'style' => 'background-color: black' 104 104 + 'style' => 'background-color: black', 105 105 ), 106 106 phutil_implode_html('', $rows))); 107 107 }

+11 -7

src/applications/herald/adapter/HeraldAdapter.php

reviewed

··· 1052 1052 $match_title = phutil_tag( 1053 1053 'p', 1054 1054 array( 1055 1055 - 'class' => 'herald-list-description' 1055 1055 + 'class' => 'herald-list-description', 1056 1056 ), 1057 1057 $match_text); 1058 1058 ··· 1061 1061 $match_list[] = phutil_tag( 1062 1062 'div', 1063 1063 array( 1064 1064 - 'class' => 'herald-list-item' 1064 1064 + 'class' => 'herald-list-item', 1065 1065 ), 1066 1066 array( 1067 1067 $icon, 1068 1068 - $this->renderConditionAsText($condition, $handles))); 1068 1068 + $this->renderConditionAsText($condition, $handles), 1069 1069 + )); 1069 1070 } 1070 1071 1071 1072 $integer_code_for_every = HeraldRepetitionPolicyConfig::toInt( ··· 1082 1083 $action_title = phutil_tag( 1083 1084 'p', 1084 1085 array( 1085 1085 - 'class' => 'herald-list-description' 1086 1086 + 'class' => 'herald-list-description', 1086 1087 ), 1087 1088 $action_text); 1088 1089 ··· 1091 1092 $action_list[] = phutil_tag( 1092 1093 'div', 1093 1094 array( 1094 1094 - 'class' => 'herald-list-item' 1095 1095 + 'class' => 'herald-list-item', 1095 1096 ), 1096 1097 array( 1097 1098 $icon, 1098 1098 - $this->renderActionAsText($action, $handles))); } 1099 1099 + $this->renderActionAsText($action, $handles), 1100 1100 + )); 1101 1101 + } 1099 1102 1100 1103 return array( 1101 1104 $match_title, 1102 1105 $match_list, 1103 1106 $action_title, 1104 1104 - $action_list); 1107 1107 + $action_list, 1108 1108 + ); 1105 1109 } 1106 1110 1107 1111 private function renderConditionAsText(

+1 -1

src/applications/herald/adapter/HeraldCommitAdapter.php

reviewed

··· 141 141 self::ACTION_EMAIL, 142 142 self::ACTION_AUDIT, 143 143 self::ACTION_APPLY_BUILD_PLANS, 144 144 - self::ACTION_NOTHING 144 144 + self::ACTION_NOTHING, 145 145 ), 146 146 parent::getActions($rule_type)); 147 147 case HeraldRuleTypeConfig::RULE_TYPE_PERSONAL:

+2 -2

src/applications/herald/application/PhabricatorHeraldApplication.php

reviewed

··· 56 56 '(?:query/(?P<queryKey>[^/]+)/)?' => 'HeraldTranscriptListController', 57 57 '(?P<id>[1-9]\d*)/(?:(?P<filter>\w+)/)?' 58 58 => 'HeraldTranscriptController', 59 59 - ) 60 60 - ) 59 59 + ), 60 60 + ), 61 61 ); 62 62 } 63 63

+6 -4

src/applications/herald/controller/HeraldRuleController.php

reviewed

··· 177 177 'href' => '#', 178 178 'class' => 'button green', 179 179 'sigil' => 'create-condition', 180 180 - 'mustcapture' => true 180 180 + 'mustcapture' => true, 181 181 ), 182 182 pht('New Condition'))) 183 183 ->setDescription( ··· 186 186 'table', 187 187 array( 188 188 'sigil' => 'rule-conditions', 189 189 - 'class' => 'herald-condition-table' 189 189 + 'class' => 'herald-condition-table', 190 190 ), 191 191 ''))) 192 192 ->appendChild( ··· 494 494 'template' => $this->buildTokenizerTemplates($handles) + array( 495 495 'rules' => $all_rules, 496 496 ), 497 497 - 'author' => array($rule->getAuthorPHID() => 498 498 - $handles[$rule->getAuthorPHID()]->getName()), 497 497 + 'author' => array( 498 498 + $rule->getAuthorPHID() => 499 499 + $handles[$rule->getAuthorPHID()]->getName(), 500 500 + ), 499 501 'info' => $config_info, 500 502 )); 501 503 }

+1 -1

src/applications/herald/storage/__tests__/HeraldRuleTestCase.php

reviewed

··· 32 32 // Global 33 33 1, 34 34 2, 35 35 - 5 35 35 + 5, 36 36 ), 37 37 array_values(mpull($rules, 'getID'))); 38 38 }

+1 -1

src/applications/home/controller/PhabricatorHomeMainController.php

reviewed

··· 327 327 ), 328 328 array( 329 329 phutil_tag('strong', array(), $title.': '), 330 330 - $body 330 330 + $body, 331 331 ))); 332 332 $this->minipanels[] = $panel; 333 333 }

+2 -1

src/applications/legalpad/application/PhabricatorLegalpadApplication.php

reviewed

··· 63 63 'document/' => array( 64 64 'preview/' => 'PhabricatorMarkupPreviewController', 65 65 ), 66 66 - )); 66 66 + ), 67 67 + ); 67 68 } 68 69 69 70 protected function getCustomCapabilities() {

+1 -1

src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php

reviewed

··· 17 17 'metamta.legalpad.subject-prefix', 18 18 'string', 19 19 '[Legalpad]') 20 20 - ->setDescription(pht('Subject prefix for Legalpad email.')) 20 20 + ->setDescription(pht('Subject prefix for Legalpad email.')), 21 21 ); 22 22 } 23 23

+1 -1

src/applications/legalpad/controller/LegalpadDocumentEditController.php

reviewed

··· 218 218 array( 219 219 $crumbs, 220 220 $form_box, 221 221 - $preview 221 221 + $preview, 222 222 ), 223 223 array( 224 224 'title' => $title,

+1 -1

src/applications/macro/config/PhabricatorMacroConfigOptions.php

reviewed

··· 17 17 ->setDescription(pht( 18 18 'As {{metamta.maniphest.reply-handler-domain}}, but affects Macro.')), 19 19 $this->newOption('metamta.macro.subject-prefix', 'string', '[Macro]') 20 20 - ->setDescription(pht('Subject prefix for Macro email.')) 20 20 + ->setDescription(pht('Subject prefix for Macro email.')), 21 21 ); 22 22 } 23 23

+1 -1

src/applications/maniphest/conduit/ManiphestQueryStatusesConduitAPIMethod.php

reviewed

··· 31 31 'openStatuses' => ManiphestTaskStatus::getOpenStatusConstants(), 32 32 'closedStatuses' => ManiphestTaskStatus::getClosedStatusConstants(), 33 33 'allStatuses' => array_keys(ManiphestTaskStatus::getTaskStatusMap()), 34 34 - 'statusMap' => ManiphestTaskStatus::getTaskStatusMap() 34 34 + 'statusMap' => ManiphestTaskStatus::getTaskStatusMap(), 35 35 ); 36 36 return $results; 37 37 }

+1 -1

src/applications/maniphest/controller/ManiphestBatchEditController.php

reviewed

··· 84 84 'cc' => array( 85 85 'src' => $mailable_source->getDatasourceURI(), 86 86 'placeholder' => $mailable_source->getPlaceholderText(), 87 87 - ) 87 87 + ), 88 88 ), 89 89 'input' => 'batch-form-actions', 90 90 'priorityMap' => ManiphestTaskPriority::getTaskPriorityMap(),

+3 -2

src/applications/maniphest/controller/ManiphestReportController.php

reviewed

··· 383 383 $label, 384 384 number_format($info['open']), 385 385 number_format($info['close']), 386 386 - $fmt); 386 386 + $fmt, 387 387 + ); 387 388 } 388 389 389 390 public function renderOpenTasks() { ··· 611 612 'sigil' => 'has-tooltip', 612 613 'meta' => array( 613 614 'tip' => pht('Closed after %s', $edate), 614 614 - 'size' => 260 615 615 + 'size' => 260, 615 616 ), 616 617 ), 617 618 pht('Recently Closed'));

+3 -1

src/applications/maniphest/controller/ManiphestSubpriorityController.php

reviewed

··· 43 43 ->setNewValue(array( 44 44 'newPriority' => $after_pri, 45 45 'newSubpriorityBase' => $after_sub, 46 46 - 'direction' => '>'))); 46 46 + 'direction' => '>', 47 47 + )), 48 48 + ); 47 49 $editor = id(new ManiphestTransactionEditor()) 48 50 ->setActor($user) 49 51 ->setContinueOnMissingFields(true)

+1 -1

src/applications/maniphest/controller/ManiphestTaskDetailController.php

reviewed

··· 525 525 phutil_tag( 526 526 'a', 527 527 array( 528 528 - 'href' => 'mailto:'.$source.'?subject='.$subject 528 528 + 'href' => 'mailto:'.$source.'?subject='.$subject, 529 529 ), 530 530 $source)); 531 531 }

+5 -2

src/applications/maniphest/controller/ManiphestTaskEditController.php

reviewed

··· 246 246 array( 247 247 'new' => array( 248 248 'projectPHID' => $column->getProjectPHID(), 249 249 - 'columnPHIDs' => array($column_phid)), 249 249 + 'columnPHIDs' => array($column_phid), 250 250 + ), 250 251 'old' => array( 251 252 'projectPHID' => $column->getProjectPHID(), 252 252 - 'columnPHIDs' => array())); 253 253 + 'columnPHIDs' => array(), 254 254 + ), 255 255 + ); 253 256 } 254 257 } 255 258 }

+1 -1

src/applications/maniphest/view/ManiphestTaskResultListView.php

reviewed

··· 93 93 $lists[] = phutil_tag( 94 94 'div', 95 95 array( 96 96 - 'class' => 'maniphest-task-group' 96 96 + 'class' => 'maniphest-task-group', 97 97 ), 98 98 array( 99 99 $header,

+1 -1

src/applications/metamta/adapter/PhabricatorMailImplementationTestAdapter.php

reviewed

··· 49 49 $this->guts['attachments'][] = array( 50 50 'data' => $data, 51 51 'filename' => $filename, 52 52 - 'mimetype' => $mimetype 52 52 + 'mimetype' => $mimetype, 53 53 ); 54 54 return $this; 55 55 }

+2 -1

src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php

reviewed

··· 42 42 return array( 43 43 'body' => $body, 44 44 'command' => $command, 45 45 - 'command_value' => $command_value); 45 45 + 'command_value' => $command_value, 46 46 + ); 46 47 } 47 48 48 49 public function stripTextBody($body) {

+2 -1

src/applications/metamta/view/PhabricatorMetaMTAMailBody.php

reviewed

··· 80 80 public function addHTMLSection($header, $html_fragment) { 81 81 $this->htmlSections[] = array( 82 82 phutil_tag('div', array('style' => 'font-weight:800;'), $header), 83 83 - $html_fragment); 83 83 + $html_fragment, 84 84 + ); 84 85 85 86 return $this; 86 87 }

+1 -1

src/applications/notification/controller/PhabricatorNotificationPanelController.php

reviewed

··· 60 60 $connection_ui = phutil_tag( 61 61 'div', 62 62 array( 63 63 - 'class' => 'phabricator-notification-footer' 63 63 + 'class' => 'phabricator-notification-footer', 64 64 ), 65 65 $connection_status); 66 66

+2 -2

src/applications/oauthserver/__tests__/PhabricatorOAuthServerTestCase.php

reviewed

··· 9 9 'http://www.google.com/' => true, 10 10 'http://www.google.com/auth' => true, 11 11 'www.google.com' => false, 12 12 - 'http://www.google.com/auth#invalid' => false 12 12 + 'http://www.google.com/auth#invalid' => false, 13 13 ); 14 14 $server = new PhabricatorOAuthServer(); 15 15 foreach ($map as $input => $expected) { ··· 32 32 'http://www.google.com/?auth' => true, 33 33 'www.google.com' => false, 34 34 'http://www.google.com/auth#invalid' => false, 35 35 - 'http://www.example.com' => false 35 35 + 'http://www.example.com' => false, 36 36 ); 37 37 foreach ($test_domain_map as $input => $expected) { 38 38 $uri = new PhutilURI($input);

+1 -1

src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php

reviewed

··· 196 196 } else { 197 197 $desired_scopes = array( 198 198 PhabricatorOAuthServerScope::SCOPE_WHOAMI => 1, 199 199 - PhabricatorOAuthServerScope::SCOPE_OFFLINE_ACCESS => 1 199 199 + PhabricatorOAuthServerScope::SCOPE_OFFLINE_ACCESS => 1, 200 200 ); 201 201 } 202 202

+1 -1

src/applications/owners/conduit/OwnersQueryConduitAPIMethod.php

reviewed

··· 107 107 'description' => $package->getDescription(), 108 108 'primaryOwner' => $package->getPrimaryOwnerPHID(), 109 109 'owners' => $owners, 110 110 - 'paths' => $paths 110 110 + 'paths' => $paths, 111 111 ); 112 112 } 113 113 return $result;

+1 -1

src/applications/owners/config/PhabricatorOwnersConfigOptions.php

reviewed

··· 20 20 ->setBaseClass('PhabricatorMailReplyHandler') 21 21 ->setDescription(pht('Reply handler for owners mail.')), 22 22 $this->newOption('metamta.package.subject-prefix', 'string', '[Package]') 23 23 - ->setDescription(pht('Subject prefix for Owners email.')) 23 23 + ->setDescription(pht('Subject prefix for Owners email.')), 24 24 ); 25 25 } 26 26

+1 -1

src/applications/owners/controller/PhabricatorOwnersDetailController.php

reviewed

··· 86 86 'callsign' => $repo->getCallsign(), 87 87 'branch' => $repo->getDefaultBranch(), 88 88 'path' => $path->getPath(), 89 89 - 'action' => 'browse' 89 89 + 'action' => 'browse', 90 90 )); 91 91 $repo_name = phutil_tag('strong', array(), $repo->getName()); 92 92 $path_link = phutil_tag(

+1 -1

src/applications/owners/controller/PhabricatorOwnersListController.php

reviewed

··· 310 310 array( 311 311 'href' => '/audit/view/packagecommits/?phid='.$package->getPHID(), 312 312 ), 313 313 - pht('Related Commits')) 313 313 + pht('Related Commits')), 314 314 ); 315 315 } 316 316

+2 -1

src/applications/owners/storage/PhabricatorOwnersPackage.php

reviewed

··· 344 344 array( 345 345 'commit' => $drequest->getCommit(), 346 346 'path' => $path, 347 347 - 'needValidityOnly' => true))); 347 347 + 'needValidityOnly' => true, 348 348 + ))); 348 349 $valid = $results->isValidResults(); 349 350 $is_directory = true; 350 351 if (!$valid) {

+2 -1

src/applications/passphrase/application/PhabricatorPassphraseApplication.php

reviewed

··· 47 47 'public/(?P<id>\d+)/' => 'PassphraseCredentialPublicController', 48 48 'lock/(?P<id>\d+)/' => 'PassphraseCredentialLockController', 49 49 'conduit/(?P<id>\d+)/' => 'PassphraseCredentialConduitController', 50 50 - )); 50 50 + ), 51 51 + ); 51 52 } 52 53 53 54 public function getRemarkupRules() {

+2 -1

src/applications/passphrase/controller/PassphraseCredentialRevealController.php

reviewed

··· 75 75 $type_secret = PassphraseCredentialTransaction::TYPE_LOOKEDATSECRET; 76 76 $xactions = array(id(new PassphraseCredentialTransaction()) 77 77 ->setTransactionType($type_secret) 78 78 - ->setNewValue(true)); 78 78 + ->setNewValue(true), 79 79 + ); 79 80 80 81 $editor = id(new PassphraseCredentialTransactionEditor()) 81 82 ->setActor($viewer)

+1 -1

src/applications/paste/config/PhabricatorPasteConfigOptions.php

reviewed

··· 22 22 'metamta.paste.subject-prefix', 23 23 'string', 24 24 '[Paste]') 25 25 - ->setDescription(pht('Subject prefix for Paste email.')) 25 25 + ->setDescription(pht('Subject prefix for Paste email.')), 26 26 ); 27 27 } 28 28

+2 -1

src/applications/paste/lipsum/PhabricatorPasteTestDataGenerator.php

reviewed

··· 6 6 // Better Support for this in the future 7 7 public $supportedLanguages = array( 8 8 'Java' => 'java', 9 9 - 'PHP' => 'php'); 9 9 + 'PHP' => 'php', 10 10 + ); 10 11 11 12 public function generate() { 12 13 $authorphid = $this->loadPhabrictorUserPHID();

+2 -2

src/applications/paste/view/PasteEmbedView.php

reviewed

··· 37 37 $link = phutil_tag( 38 38 'a', 39 39 array( 40 40 - 'href' => '/P'.$this->paste->getID() 40 40 + 'href' => '/P'.$this->paste->getID(), 41 41 ), 42 42 $this->handle->getFullName()); 43 43 44 44 $head = phutil_tag( 45 45 'div', 46 46 array( 47 47 - 'class' => 'paste-embed-head' 47 47 + 'class' => 'paste-embed-head', 48 48 ), 49 49 $link); 50 50

+1 -1

src/applications/people/conduit/UserFindConduitAPIMethod.php

reviewed

··· 20 20 21 21 public function defineParamTypes() { 22 22 return array( 23 23 - 'aliases' => 'required list<string>' 23 23 + 'aliases' => 'required list<string>', 24 24 ); 25 25 } 26 26

+6 -5

src/applications/people/controller/PhabricatorPeopleCalendarController.php

reviewed

··· 81 81 $crumbs->addTextCrumb($date->format('F Y')); 82 82 83 83 return $this->buildApplicationPage( 84 84 + array( 85 85 + $crumbs, 86 86 + $month_view, 87 87 + ), 84 88 array( 85 85 - $crumbs, 86 86 - $month_view), 87 87 - array( 88 88 - 'title' => pht('Calendar'), 89 89 - )); 89 89 + 'title' => pht('Calendar'), 90 90 + )); 90 91 } 91 92 }

+2 -2

src/applications/people/controller/PhabricatorPeopleProfileController.php

reviewed

··· 150 150 ), 151 151 array( 152 152 $calendar, 153 153 - $feed 153 153 + $feed, 154 154 )); 155 155 156 156 $object_box = id(new PHUIObjectBoxView()) ··· 271 271 $header = phutil_tag( 272 272 'a', 273 273 array( 274 274 - 'href' => $this->getRequest()->getRequestURI().'calendar/' 274 274 + 'href' => $this->getRequest()->getRequestURI().'calendar/', 275 275 ), 276 276 $headertext); 277 277

+2 -1

src/applications/people/controller/PhabricatorPeopleProfilePictureController.php

reviewed

··· 237 237 'name' => 'phid', 238 238 'value' => $phid, 239 239 )), 240 240 - $button); 240 240 + $button, 241 241 + ); 241 242 242 243 $button = phabricator_form( 243 244 $viewer,

+2 -1

src/applications/people/storage/PhabricatorUser.php

reviewed

··· 445 445 PhabricatorUserPreferences::PREFERENCE_TITLES => 'glyph', 446 446 PhabricatorUserPreferences::PREFERENCE_EDITOR => '', 447 447 PhabricatorUserPreferences::PREFERENCE_MONOSPACED => '', 448 448 - PhabricatorUserPreferences::PREFERENCE_DARK_CONSOLE => 0); 448 448 + PhabricatorUserPreferences::PREFERENCE_DARK_CONSOLE => 0, 449 449 + ); 449 450 450 451 $preferences->setPreferences($default_dict); 451 452 }

+1 -1

src/applications/phame/application/PhabricatorPhameApplication.php

reviewed

··· 50 50 'preview/' => 'PhamePostPreviewController', 51 51 'framed/(?P<id>\d+)/' => 'PhamePostFramedController', 52 52 'new/' => 'PhamePostNewController', 53 53 - 'move/(?P<id>\d+)/' => 'PhamePostNewController' 53 53 + 'move/(?P<id>\d+)/' => 'PhamePostNewController', 54 54 ), 55 55 'blog/' => array( 56 56 '(?:(?P<filter>user|all)/)?' => 'PhameBlogListController',

+1 -1

src/applications/phame/controller/blog/PhameBlogEditController.php

reviewed

··· 19 19 ->withIDs(array($this->id)) 20 20 ->requireCapabilities( 21 21 array( 22 22 - PhabricatorPolicyCapability::CAN_EDIT 22 22 + PhabricatorPolicyCapability::CAN_EDIT, 23 23 )) 24 24 ->executeOne(); 25 25 if (!$blog) {

+1 -1

src/applications/phame/controller/blog/PhameBlogFeedController.php

reviewed

··· 39 39 array( 40 40 'rel' => 'self', 41 41 'type' => 'application/atom+xml', 42 42 - 'href' => $blog_uri 42 42 + 'href' => $blog_uri, 43 43 )); 44 44 45 45 $updated = $blog->getDateModified();

+1 -1

src/applications/phame/controller/blog/PhameBlogViewController.php

reviewed

··· 105 105 'meta' => array( 106 106 'tip' => pht('Atom URI does not support custom domains.'), 107 107 'size' => 320, 108 108 - ) 108 108 + ), 109 109 ), 110 110 $feed_uri)); 111 111

+20 -10

src/applications/phame/storage/PhameBlog.php

reviewed

··· 94 94 // so just use it to test if there's a protocol specified 95 95 $uri = new PhutilURI($custom_domain); 96 96 if ($uri->getProtocol()) { 97 97 - return array($label, 97 97 + return array( 98 98 + $label, 98 99 pht( 99 100 'The custom domain should not include a protocol. Just provide '. 100 101 'the bare domain name (for example, "%s").', 101 101 - $example_domain)); 102 102 + $example_domain), 103 103 + ); 102 104 } 103 105 104 106 if ($uri->getPort()) { 105 105 - return array($label, 107 107 + return array( 108 108 + $label, 106 109 pht( 107 110 'The custom domain should not include a port number. Just provide '. 108 111 'the bare domain name (for example, "%s").', 109 109 - $example_domain)); 112 112 + $example_domain), 113 113 + ); 110 114 } 111 115 112 116 if (strpos($custom_domain, '/') !== false) { 113 113 - return array($label, 117 117 + return array( 118 118 + $label, 114 119 pht( 115 120 'The custom domain should not specify a path (hosting a Phame '. 116 121 'blog at a path is currently not supported). Instead, just provide '. 117 122 'the bare domain name (for example, "%s").', 118 118 - $example_domain)); 123 123 + $example_domain), 124 124 + ); 119 125 } 120 126 121 127 if (strpos($custom_domain, '.') === false) { 122 122 - return array($label, 128 128 + return array( 129 129 + $label, 123 130 pht( 124 131 'The custom domain should contain at least one dot (.) because '. 125 132 'some browsers fail to set cookies on domains without a dot. '. 126 133 'Instead, use a normal looking domain name like "%s".', 127 127 - $example_domain)); 134 134 + $example_domain), 135 135 + ); 128 136 } 129 137 130 138 if (!PhabricatorEnv::getEnvConfig('policy.allow-public')) { 131 139 $href = PhabricatorEnv::getProductionURI( 132 140 '/config/edit/policy.allow-public/'); 133 133 - return array(pht('Fix Configuration'), 141 141 + return array( 142 142 + pht('Fix Configuration'), 134 143 pht( 135 144 'For custom domains to work, this Phabricator instance must be '. 136 145 'configured to allow the public access policy. Configure this '. ··· 140 149 phutil_tag( 141 150 'a', 142 151 array('href' => $href), 143 143 - pht('here')))); 152 152 + pht('here'))), 153 153 + ); 144 154 } 145 155 146 156 return null;

+1 -1

src/applications/phame/view/PhamePostView.php

reviewed

··· 203 203 204 204 $disqus_thread = phutil_tag('div', 205 205 array( 206 206 - 'id' => 'disqus_thread' 206 206 + 'id' => 'disqus_thread', 207 207 )); 208 208 209 209 // protip - try some var disqus_developer = 1; action to test locally

+1 -1

src/applications/phlux/storage/PhluxVariable.php

reviewed

··· 14 14 return array( 15 15 self::CONFIG_AUX_PHID => true, 16 16 self::CONFIG_SERIALIZATION => array( 17 17 - 'variableValue' => self::SERIALIZATION_JSON 17 17 + 'variableValue' => self::SERIALIZATION_JSON, 18 18 ), 19 19 self::CONFIG_COLUMN_SCHEMA => array( 20 20 'variableKey' => 'text64',

+1 -1

src/applications/pholio/application/PhabricatorPholioApplication.php

reviewed

··· 49 49 'inline/' => array( 50 50 '(?:(?P<id>\d+)/)?' => 'PholioInlineController', 51 51 'list/(?P<id>\d+)/' => 'PholioInlineListController', 52 52 - 'thumb/(?P<imageid>\d+)/' => 'PholioInlineThumbController' 52 52 + 'thumb/(?P<imageid>\d+)/' => 'PholioInlineThumbController', 53 53 ), 54 54 'image/' => array( 55 55 'upload/' => 'PholioImageUploadController',

+1 -1

src/applications/pholio/config/PhabricatorPholioConfigOptions.php

reviewed

··· 19 19 'Like {{metamta.maniphest.reply-handler-domain}}, but affects '. 20 20 'Pholio.')), 21 21 $this->newOption('metamta.pholio.subject-prefix', 'string', '[Pholio]') 22 22 - ->setDescription(pht('Subject prefix for Pholio email.')) 22 22 + ->setDescription(pht('Subject prefix for Pholio email.')), 23 23 ); 24 24 } 25 25

+2 -1

src/applications/pholio/query/PholioMockSearchEngine.php

reviewed

··· 46 46 $statuses = array( 47 47 '' => pht('Any Status'), 48 48 'closed' => pht('Closed'), 49 49 - 'open' => pht('Open')); 49 49 + 'open' => pht('Open'), 50 50 + ); 50 51 51 52 $status = $saved_query->getParameter('statuses', array()); 52 53 $status = head($status);

+3 -3

src/applications/pholio/view/PholioMockImagesView.php

reviewed

··· 142 142 array( 143 143 'id' => $viewport_id, 144 144 'sigil' => 'mock-viewport', 145 145 - 'class' => 'pholio-mock-image-viewport' 145 145 + 'class' => 'pholio-mock-image-viewport', 146 146 ), 147 147 ''); 148 148 ··· 171 171 array( 172 172 'id' => 'mock-image-description', 173 173 'sigil' => 'mock-image-description', 174 174 - 'class' => 'mock-image-description' 174 174 + 'class' => 'mock-image-description', 175 175 ), 176 176 ''); 177 177 ··· 179 179 'div', 180 180 array( 181 181 'class' => 'pholio-mock-image-container', 182 182 - 'id' => 'pholio-mock-image-container' 182 182 + 'id' => 'pholio-mock-image-container', 183 183 ), 184 184 array($mock_wrapper, $inline_comments_holder)); 185 185

+1 -1

src/applications/phortune/provider/PhortuneWePayPaymentProvider.php

reviewed

··· 152 152 'shipping_fee' => 0, 153 153 'charge_tax' => 0, 154 154 'mode' => 'regular', 155 155 - 'funding_sources' => 'bank,cc' 155 155 + 'funding_sources' => 'bank,cc', 156 156 ); 157 157 158 158 $charge = $cart->willApplyCharge($viewer, $this);

+1 -1

src/applications/phortune/view/PhortuneCreditCardForm.php

reviewed

··· 82 82 'tip' => 'We support Visa, Mastercard, American Express, '. 83 83 'Discover, JCB, and Diners Club.', 84 84 'size' => 440, 85 85 - ) 85 85 + ), 86 86 )))) 87 87 ->appendChild( 88 88 id(new AphrontFormTextControl())

+2 -1

src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php

reviewed

··· 19 19 'src' => '/xhpast/frameset/'.$id.'/', 20 20 'frameborder' => '0', 21 21 'style' => 'width: 100%; height: 800px;', 22 22 - '')), 22 22 + '', 23 23 + )), 23 24 array( 24 25 'title' => 'XHPAST View', 25 26 ));

+6 -3

src/applications/phragment/conduit/PhragmentGetPatchConduitAPIMethod.php

reviewed

··· 83 83 'fileNew' => $files[$file_phid], 84 84 'hashOld' => $hash_caller, 85 85 'hashNew' => $hash_current, 86 86 - 'patchURI' => null); 86 86 + 'patchURI' => null, 87 87 + ); 87 88 } 88 89 } else { 89 90 // We have a record of this as a file, but there is no file ··· 95 96 'fileNew' => null, 96 97 'hashOld' => $hash_caller, 97 98 'hashNew' => PhragmentPatchUtil::EMPTY_HASH, 98 98 - 'patchURI' => null); 99 99 + 'patchURI' => null, 100 100 + ); 99 101 } 100 102 } else { 101 103 // If $mappings[$path] does not exist, then the user has a file, ··· 125 127 'fileNew' => $files[$file_phid], 126 128 'hashOld' => PhragmentPatchUtil::EMPTY_HASH, 127 129 'hashNew' => $hash_current, 128 128 - 'patchURI' => null); 130 130 + 'patchURI' => null, 131 131 + ); 129 132 } else { 130 133 // We have a record of deleting this file, and the caller hasn't 131 134 // reported it, so they've probably deleted it in a previous

+2 -1

src/applications/phragment/conduit/PhragmentQueryFragmentsConduitAPIMethod.php

reviewed

··· 74 74 'path' => $cpath, 75 75 'hash' => $file->getContentHash(), 76 76 'version' => $child->getLatestVersion()->getSequence(), 77 77 - 'uri' => $file->getViewURI()); 77 77 + 'uri' => $file->getViewURI(), 78 78 + ); 78 79 } 79 80 $results[$path] = $result; 80 81 }

+2 -1

src/applications/phragment/controller/PhragmentBrowseController.php

reviewed

··· 88 88 $crumbs, 89 89 $this->renderConfigurationWarningIfRequired(), 90 90 $current_box, 91 91 - $list), 91 91 + $list, 92 92 + ), 92 93 array( 93 94 'title' => pht('Browse Fragments'), 94 95 ));

+2 -1

src/applications/phragment/controller/PhragmentCreateController.php

reviewed

··· 122 122 array( 123 123 $crumbs, 124 124 $this->renderConfigurationWarningIfRequired(), 125 125 - $box), 125 125 + $box, 126 126 + ), 126 127 array( 127 128 'title' => pht('Create Fragment'), 128 129 ));

+2 -1

src/applications/phragment/controller/PhragmentHistoryController.php

reviewed

··· 102 102 $crumbs, 103 103 $this->renderConfigurationWarningIfRequired(), 104 104 $current_box, 105 105 - $list), 105 105 + $list, 106 106 + ), 106 107 array( 107 108 'title' => pht('Fragment History'), 108 109 ));

+2 -1

src/applications/phragment/controller/PhragmentPolicyController.php

reviewed

··· 99 99 array( 100 100 $crumbs, 101 101 $this->renderConfigurationWarningIfRequired(), 102 102 - $box), 102 102 + $box, 103 103 + ), 103 104 array( 104 105 'title' => pht('Edit Fragment Policies'), 105 106 ));

+10 -5

src/applications/phragment/controller/PhragmentSnapshotCreateController.php

reviewed

··· 90 90 array(), 91 91 array( 92 92 phutil_tag('th', array(), 'Fragment'), 93 93 - phutil_tag('th', array(), 'Version'))); 93 93 + phutil_tag('th', array(), 'Version'), 94 94 + )); 94 95 $rows[] = phutil_tag( 95 96 'tr', 96 97 array(), 97 98 array( 98 99 phutil_tag('td', array(), $fragment->getPath()), 99 99 - phutil_tag('td', array(), $fragment_sequence))); 100 100 + phutil_tag('td', array(), $fragment_sequence), 101 101 + )); 100 102 foreach ($children as $child) { 101 103 $sequence = '-'; 102 104 if ($child->getLatestVersion() !== null) { ··· 107 109 array(), 108 110 array( 109 111 phutil_tag('td', array(), $child->getPath()), 110 110 - phutil_tag('td', array(), $sequence))); 112 112 + phutil_tag('td', array(), $sequence), 113 113 + )); 111 114 } 112 115 113 116 $table = phutil_tag( ··· 125 128 pht( 126 129 'The snapshot will contain the following fragments at '. 127 130 'the specified versions: ')), 128 128 - $table)); 131 131 + $table, 132 132 + )); 129 133 130 134 $form = id(new AphrontFormView()) 131 135 ->setUser($viewer) ··· 159 163 array( 160 164 $crumbs, 161 165 $this->renderConfigurationWarningIfRequired(), 162 162 - $box), 166 166 + $box, 167 167 + ), 163 168 array( 164 169 'title' => pht('Create Fragment'), 165 170 ));

+2 -1

src/applications/phragment/controller/PhragmentSnapshotDeleteController.php

reviewed

··· 16 16 ->setViewer($viewer) 17 17 ->requireCapabilities(array( 18 18 PhabricatorPolicyCapability::CAN_VIEW, 19 19 - PhabricatorPolicyCapability::CAN_EDIT)) 19 19 + PhabricatorPolicyCapability::CAN_EDIT, 20 20 + )) 20 21 ->withIDs(array($this->id)) 21 22 ->executeOne(); 22 23 if ($snapshot === null) {

+6 -3

src/applications/phragment/controller/PhragmentSnapshotPromoteController.php

reviewed

··· 25 25 ->setViewer($viewer) 26 26 ->requireCapabilities(array( 27 27 PhabricatorPolicyCapability::CAN_VIEW, 28 28 - PhabricatorPolicyCapability::CAN_EDIT)) 28 28 + PhabricatorPolicyCapability::CAN_EDIT, 29 29 + )) 29 30 ->withPaths(array($this->dblob)) 30 31 ->executeOne(); 31 32 if ($this->targetFragment === null) { ··· 45 46 ->setViewer($viewer) 46 47 ->requireCapabilities(array( 47 48 PhabricatorPolicyCapability::CAN_VIEW, 48 48 - PhabricatorPolicyCapability::CAN_EDIT)) 49 49 + PhabricatorPolicyCapability::CAN_EDIT, 50 50 + )) 49 51 ->withIDs(array($this->id)) 50 52 ->executeOne(); 51 53 if ($this->targetSnapshot === null) { ··· 55 57 $this->snapshots = id(new PhragmentSnapshotQuery()) 56 58 ->setViewer($viewer) 57 59 ->withPrimaryFragmentPHIDs(array( 58 58 - $this->targetSnapshot->getPrimaryFragmentPHID())) 60 60 + $this->targetSnapshot->getPrimaryFragmentPHID(), 61 61 + )) 59 62 ->execute(); 60 63 } 61 64

+2 -1

src/applications/phragment/controller/PhragmentSnapshotViewController.php

reviewed

··· 76 76 $crumbs, 77 77 $this->renderConfigurationWarningIfRequired(), 78 78 $box, 79 79 - $list), 79 79 + $list, 80 80 + ), 80 81 array( 81 82 'title' => pht('View Snapshot'), 82 83 ));

+2 -1

src/applications/phragment/controller/PhragmentUpdateController.php

reviewed

··· 73 73 array( 74 74 $crumbs, 75 75 $this->renderConfigurationWarningIfRequired(), 76 76 - $box), 76 76 + $box, 77 77 + ), 77 78 array( 78 79 'title' => pht('Update Fragment'), 79 80 ));

+2 -1

src/applications/phragment/controller/PhragmentVersionController.php

reviewed

··· 82 82 $crumbs, 83 83 $this->renderConfigurationWarningIfRequired(), 84 84 $box, 85 85 - $this->renderPreviousVersionList($version)), 85 85 + $this->renderPreviousVersionList($version), 86 86 + ), 86 87 array( 87 88 'title' => pht('View Version'), 88 89 ));

+1 -1

src/applications/phragment/storage/PhragmentFragmentVersion.php

reviewed

··· 53 53 54 54 public function getCapabilities() { 55 55 return array( 56 56 - PhabricatorPolicyCapability::CAN_VIEW 56 56 + PhabricatorPolicyCapability::CAN_VIEW, 57 57 ); 58 58 } 59 59

+1 -1

src/applications/phragment/storage/PhragmentSnapshotChild.php

reviewed

··· 62 62 63 63 public function getCapabilities() { 64 64 return array( 65 65 - PhabricatorPolicyCapability::CAN_VIEW 65 65 + PhabricatorPolicyCapability::CAN_VIEW, 66 66 ); 67 67 } 68 68

+1 -1

src/applications/phrequent/application/PhabricatorPhrequentApplication.php

reviewed

··· 41 41 '/phrequent/' => array( 42 42 '(?:query/(?P<queryKey>[^/]+)/)?' => 'PhrequentListController', 43 43 'track/(?P<verb>[a-z]+)/(?P<phid>[^/]+)/' 44 44 - => 'PhrequentTrackController' 44 44 + => 'PhrequentTrackController', 45 45 ), 46 46 ); 47 47 }

+1 -1

src/applications/phrequent/conduit/PhrequentPopConduitAPIMethod.php

reviewed

··· 18 18 return array( 19 19 'objectPHID' => 'phid', 20 20 'stopTime' => 'int', 21 21 - 'note' => 'string' 21 21 + 'note' => 'string', 22 22 ); 23 23 } 24 24

+1 -1

src/applications/phrequent/conduit/PhrequentPushConduitAPIMethod.php

reviewed

··· 19 19 public function defineParamTypes() { 20 20 return array( 21 21 'objectPHID' => 'required phid', 22 22 - 'startTime' => 'int' 22 22 + 'startTime' => 'int', 23 23 ); 24 24 } 25 25

+4 -2

src/applications/phrequent/query/PhrequentUserTimeQuery.php

reviewed

··· 239 239 return array( 240 240 self::ENDED_ALL => pht('All'), 241 241 self::ENDED_NO => pht('No'), 242 242 - self::ENDED_YES => pht('Yes')); 242 242 + self::ENDED_YES => pht('Yes'), 243 243 + ); 243 244 } 244 245 245 246 public static function getOrderSearchOptions() { ··· 249 250 self::ORDER_ENDED_ASC => pht('by furthest end date'), 250 251 self::ORDER_ENDED_DESC => pht('by nearest end date'), 251 252 self::ORDER_DURATION_ASC => pht('by smallest duration'), 252 252 - self::ORDER_DURATION_DESC => pht('by largest duration')); 253 253 + self::ORDER_DURATION_DESC => pht('by largest duration'), 254 254 + ); 253 255 } 254 256 255 257 public static function getUserTotalObjectsTracked(

+1 -1

src/applications/phrequent/storage/__tests__/PhrequentTimeBlockTestCase.php

reviewed

··· 255 255 array( 256 256 'T1' => array( 257 257 array(1, 100), 258 258 - array(900, null) 258 258 + array(900, null), 259 259 ), 260 260 ), 261 261 $ranges);

+5 -3

src/applications/phriction/controller/PhrictionDocumentController.php

reviewed

··· 40 40 $project = id(new PhabricatorProjectQuery()) 41 41 ->setViewer($user) 42 42 ->withPhrictionSlugs(array( 43 43 - PhrictionDocument::getProjectSlugIdentifier($slug))) 43 43 + PhrictionDocument::getProjectSlugIdentifier($slug), 44 44 + )) 44 45 ->executeOne(); 45 46 if (!$project) { 46 47 return new Aphront404Response(); ··· 222 223 $core_page = phutil_tag( 223 224 'div', 224 225 array( 225 225 - 'class' => 'phriction-offset' 226 226 + 'class' => 'phriction-offset', 226 227 ), 227 228 array( 228 229 $page_content, ··· 256 257 $project = id(new PhabricatorProjectQuery()) 257 258 ->setViewer($viewer) 258 259 ->withPhrictionSlugs(array( 259 259 - PhrictionDocument::getProjectSlugIdentifier($slug))) 260 260 + PhrictionDocument::getProjectSlugIdentifier($slug), 261 261 + )) 260 262 ->executeOne(); 261 263 if ($project) { 262 264 $project_phid = $project->getPHID();

+2 -1

src/applications/phriction/controller/PhrictionEditController.php

reviewed

··· 66 66 $project = id(new PhabricatorProjectQuery()) 67 67 ->setViewer($user) 68 68 ->withPhrictionSlugs(array( 69 69 - PhrictionDocument::getProjectSlugIdentifier($slug))) 69 69 + PhrictionDocument::getProjectSlugIdentifier($slug), 70 70 + )) 70 71 ->executeOne(); 71 72 if (!$project) { 72 73 return new Aphront404Response();

+2 -1

src/applications/phriction/controller/PhrictionNewController.php

reviewed

··· 34 34 $project = id(new PhabricatorProjectQuery()) 35 35 ->setViewer($user) 36 36 ->withPhrictionSlugs(array( 37 37 - PhrictionDocument::getProjectSlugIdentifier($slug))) 37 37 + PhrictionDocument::getProjectSlugIdentifier($slug), 38 38 + )) 38 39 ->executeOne(); 39 40 if (!$project) { 40 41 $dialog = new AphrontDialogView();

+2 -1

src/applications/phriction/editor/PhrictionDocumentEditor.php

reviewed

··· 243 243 $project = id(new PhabricatorProjectQuery()) 244 244 ->setViewer($this->requireActor()) 245 245 ->withPhrictionSlugs(array( 246 246 - PhrictionDocument::getProjectSlugIdentifier($slug))) 246 246 + PhrictionDocument::getProjectSlugIdentifier($slug), 247 247 + )) 247 248 ->executeOne(); 248 249 if ($project) { 249 250 $project_phid = $project->getPHID();

+2 -1

src/applications/policy/config/PhabricatorPolicyConfigOptions.php

reviewed

··· 17 17 ->setBoolOptions( 18 18 array( 19 19 pht('Allow Public Visibility'), 20 20 - pht('Require Login'))) 20 20 + pht('Require Login'), 21 21 + )) 21 22 ->setSummary(pht('Allow users to set object visibility to public.')) 22 23 ->setDescription( 23 24 pht(

+2 -2

src/applications/policy/controller/PhabricatorPolicyEditController.php

reviewed

··· 162 162 'href' => '#', 163 163 'class' => 'button green', 164 164 'sigil' => 'create-rule', 165 165 - 'mustcapture' => true 165 165 + 'mustcapture' => true, 166 166 ), 167 167 pht('New Rule'))) 168 168 ->setDescription( ··· 171 171 'table', 172 172 array( 173 173 'sigil' => 'rules', 174 174 - 'class' => 'policy-rules-table' 174 174 + 'class' => 'policy-rules-table', 175 175 ), 176 176 ''))) 177 177 ->appendChild(

+1 -1

src/applications/policy/storage/PhabricatorPolicy.php

reviewed

··· 245 245 } 246 246 } 247 247 248 248 - public function renderDescription($icon=false) { 248 248 + public function renderDescription($icon = false) { 249 249 $img = null; 250 250 if ($icon) { 251 251 $img = id(new PHUIIconView())

+1 -1

src/applications/ponder/controller/PonderQuestionViewController.php

reviewed

··· 64 64 $object_box, 65 65 $question_xactions, 66 66 $answers, 67 67 - $answer_add_panel 67 67 + $answer_add_panel, 68 68 ), 69 69 array( 70 70 'title' => 'Q'.$question->getID().' '.$question->getTitle(),

+1 -1

src/applications/ponder/storage/PonderQuestion.php

reviewed

··· 87 87 ->withEdgeTypes( 88 88 array( 89 89 PhabricatorEdgeConfig::TYPE_VOTING_USER_HAS_QUESTION, 90 90 - PhabricatorEdgeConfig::TYPE_VOTING_USER_HAS_ANSWER 90 90 + PhabricatorEdgeConfig::TYPE_VOTING_USER_HAS_ANSWER, 91 91 )) 92 92 ->needEdgeData(true) 93 93 ->execute();

+1 -1

src/applications/project/controller/PhabricatorProjectBoardViewController.php

reviewed

··· 300 300 $header_link = phutil_tag( 301 301 'a', 302 302 array( 303 303 - 'href' => $this->getApplicationURI('view/'.$project->getID().'/') 303 303 + 'href' => $this->getApplicationURI('view/'.$project->getID().'/'), 304 304 ), 305 305 $project->getName()); 306 306

+4 -2

src/applications/project/controller/PhabricatorProjectColumnHideController.php

reviewed

··· 35 35 ->requireCapabilities( 36 36 array( 37 37 PhabricatorPolicyCapability::CAN_VIEW, 38 38 - PhabricatorPolicyCapability::CAN_EDIT)) 38 38 + PhabricatorPolicyCapability::CAN_EDIT, 39 39 + )) 39 40 ->executeOne(); 40 41 if (!$column) { 41 42 return new Aphront404Response(); ··· 67 68 $type_status = PhabricatorProjectColumnTransaction::TYPE_STATUS; 68 69 $xactions = array(id(new PhabricatorProjectColumnTransaction()) 69 70 ->setTransactionType($type_status) 70 70 - ->setNewValue($new_status)); 71 71 + ->setNewValue($new_status), 72 72 + ); 71 73 72 74 $editor = id(new PhabricatorProjectColumnTransactionEditor()) 73 75 ->setActor($viewer)

+1 -1

src/applications/project/controller/PhabricatorProjectEditIconController.php

reviewed

··· 71 71 'sigil' => 'has-tooltip', 72 72 'meta' => array( 73 73 'tip' => $label, 74 74 - ) 74 74 + ), 75 75 ), 76 76 array( 77 77 $aural,

+2 -1

src/applications/project/controller/PhabricatorProjectEditPictureController.php

reviewed

··· 167 167 'name' => 'phid', 168 168 'value' => $phid, 169 169 )), 170 170 - $button); 170 170 + $button, 171 171 + ); 171 172 172 173 $button = phabricator_form( 173 174 $viewer,

+4 -2

src/applications/project/controller/PhabricatorProjectMoveController.php

reviewed

··· 128 128 ->setNewValue(array( 129 129 'newPriority' => $after_pri, 130 130 'newSubpriorityBase' => $after_sub, 131 131 - 'direction' => '>')); 131 131 + 'direction' => '>', 132 132 + )); 132 133 133 134 } else if ($b_task && 134 135 (($b_task->getPriority() > $object->getPriority()) || ··· 143 144 ->setNewValue(array( 144 145 'newPriority' => $before_pri, 145 146 'newSubpriorityBase' => $before_sub, 146 146 - 'direction' => '<')); 147 147 + 'direction' => '<', 148 148 + )); 147 149 } 148 150 } 149 151

+2 -1

src/applications/project/events/PhabricatorProjectUIEventListener.php

reviewed

··· 80 80 81 81 $annotations[$project_phid] = array( 82 82 ' ', 83 83 - $column_link); 83 83 + $column_link, 84 84 + ); 84 85 } 85 86 } 86 87

+2 -2

src/applications/project/query/PhabricatorProjectSearchEngine.php

reviewed

··· 219 219 $workboards_url = phutil_tag( 220 220 'a', 221 221 array( 222 222 - 'href' => $workboards_uri 222 222 + 'href' => $workboards_uri, 223 223 ), 224 224 pht('Workboards')); 225 225 226 226 $members_url = phutil_tag( 227 227 'a', 228 228 array( 229 229 - 'href' => $members_uri 229 229 + 'href' => $members_uri, 230 230 ), 231 231 pht('Members')); 232 232

+1 -1

src/applications/releeph/application/PhabricatorReleephApplication.php

reviewed

··· 74 74 'comment/(?P<requestID>[1-9]\d*)/' 75 75 => 'ReleephRequestCommentController', 76 76 ), 77 77 - ) 77 77 + ), 78 78 ); 79 79 } 80 80

+1 -1

src/applications/releeph/commitfinder/ReleephCommitFinder.php

reviewed

··· 69 69 } else { 70 70 $dr_data = array( 71 71 'callsign' => $repository->getCallsign(), 72 72 - 'commit' => $partial_string 72 72 + 'commit' => $partial_string, 73 73 ); 74 74 } 75 75

+1 -1

src/applications/releeph/conduit/ReleephQueryRequestsConduitAPIMethod.php

reviewed

··· 15 15 public function defineParamTypes() { 16 16 return array( 17 17 'revisionPHIDs' => 'optional list<phid>', 18 18 - 'requestedCommitPHIDs' => 'optional list<phid>' 18 18 + 'requestedCommitPHIDs' => 'optional list<phid>', 19 19 ); 20 20 } 21 21

+1 -1

src/applications/releeph/controller/branch/ReleephBranchEditController.php

reviewed

··· 81 81 ->setLabel(pht('Created By')) 82 82 ->setValue($handles[$creator_phid]->renderLink())) 83 83 ->appendChild( 84 84 - id(new AphrontFormTextControl) 84 84 + id(new AphrontFormTextControl()) 85 85 ->setLabel(pht('Symbolic Name')) 86 86 ->setName('symbolicName') 87 87 ->setValue($symbolic_name)

+2 -1

src/applications/releeph/controller/request/ReleephRequestActionController.php

reviewed

··· 44 44 case 'pass': 45 45 static $action_map = array( 46 46 'want' => ReleephRequest::INTENT_WANT, 47 47 - 'pass' => ReleephRequest::INTENT_PASS); 47 47 + 'pass' => ReleephRequest::INTENT_PASS, 48 48 + ); 48 49 $intent = $action_map[$action]; 49 50 $xactions[] = id(new ReleephRequestTransaction()) 50 51 ->setTransactionType(ReleephRequestTransaction::TYPE_USER_INTENT)

+1 -1

src/applications/releeph/controller/request/ReleephRequestDifferentialCreateController.php

reviewed

··· 93 93 } 94 94 } 95 95 96 96 - return id(new AphrontDialogResponse) 96 96 + return id(new AphrontDialogResponse()) 97 97 ->setDialog($dialog); 98 98 } 99 99

+1 -1

src/applications/releeph/controller/request/ReleephRequestEditController.php

reviewed

··· 208 208 hsprintf( 209 209 'Requested %s by %s', 210 210 $age_string, 211 211 - $handles[$pull->getRequestUserPHID()]->renderLink()) 211 211 + $handles[$pull->getRequestUserPHID()]->renderLink()), 212 212 ); 213 213 $notice_view = id(new AphrontErrorView()) 214 214 ->setSeverity(AphrontErrorView::SEVERITY_NOTICE)

+5 -3

src/applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php

reviewed

··· 65 65 'meta' => array( 66 66 'tip' => $test_blurb, 67 67 'align' => 'E', 68 68 - 'size' => 'auto'), 69 69 - 'style' => ''), 68 68 + 'size' => 'auto', 69 69 + ), 70 70 + 'style' => '', 71 71 + ), 70 72 ' + tests'); 71 73 } 72 74 ··· 107 109 'tests' => array( 108 110 'lines' => $test_lines, 109 111 'paths' => array_unique($test_paths_touched), 110 110 - ) 112 112 + ), 111 113 ); 112 114 } 113 115 }

+1 -1

src/applications/releeph/storage/ReleephProject.php

reviewed

··· 55 55 $components = array( 56 56 '/releeph/product', 57 57 $this->getID(), 58 58 - $path 58 58 + $path, 59 59 ); 60 60 return implode('/', $components); 61 61 }

+1 -1

src/applications/releeph/view/branch/ReleephBranchPreviewView.php

reviewed

··· 46 46 'params' => array( 47 47 'static' => $this->statics, 48 48 'dynamic' => $this->dynamics, 49 49 - ) 49 49 + ), 50 50 )); 51 51 52 52 return phutil_tag(

+1 -1

src/applications/releeph/view/request/ReleephRequestTypeaheadControl.php

reviewed

··· 51 51 'callsign' => $this->repo->getCallsign(), 52 52 'since' => $this->startTime, 53 53 'limit' => 16, 54 54 - ) 54 54 + ), 55 55 )); 56 56 57 57 return $div;

+1 -1

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

reviewed

··· 151 151 PhabricatorRepositoryStatusMessage::TYPE_INIT, 152 152 $code, 153 153 array( 154 154 - 'message' => $message 154 154 + 'message' => $message, 155 155 )); 156 156 } 157 157

+2 -1

src/applications/repository/storage/PhabricatorRepositoryPushLog.php

reviewed

··· 61 61 PhabricatorRepositoryPushLog::CHANGEFLAG_REWRITE => 62 62 pht('change rewrites ref'), 63 63 PhabricatorRepositoryPushLog::CHANGEFLAG_DANGEROUS => 64 64 - pht('dangerous change')); 64 64 + pht('dangerous change'), 65 65 + ); 65 66 } 66 67 67 68 public function getConfiguration() {

+2 -2

src/applications/repository/worker/commitchangeparser/PhabricatorOwnersPackagePathValidator.php

reviewed

··· 60 60 'packageID' => $package->getID(), 61 61 'repositoryPHID' => $pkg_path->getRepositoryPHID(), 62 62 'path' => str_replace($pkg_path->getPath(), $old_path, 63 63 - $move_map[$old_path]) 63 63 + $move_map[$old_path]), 64 64 ); 65 65 $path_changed = true; 66 66 } ··· 89 89 'user' => PhabricatorUser::getOmnipotentUser(), 90 90 'initFromConduit' => false, 91 91 'repository' => $repository, 92 92 - 'commit' => $commit->getCommitIdentifier() 92 92 + 'commit' => $commit->getCommitIdentifier(), 93 93 ); 94 94 $drequest = DiffusionRequest::newFromDictionary($data); 95 95 $change_query =

+4 -2

src/applications/search/controller/PhabricatorSearchAttachController.php

reviewed

··· 81 81 ->setMetadataValue('edge:type', $edge_type) 82 82 ->setNewValue(array( 83 83 '+' => array_fuse($add_phids), 84 84 - '-' => array_fuse($rem_phids))); 84 84 + '-' => array_fuse($rem_phids), 85 85 + )); 85 86 $txn_editor->applyTransactions( 86 87 $object->getApplicationTransactionObject(), 87 88 array($txn_template)); ··· 160 161 $cc_vector[] = $target->getCCPHIDs(); 161 162 $cc_vector[] = array( 162 163 $target->getAuthorPHID(), 163 163 - $target->getOwnerPHID()); 164 164 + $target->getOwnerPHID(), 165 165 + ); 164 166 165 167 $merged_into_txn = id(new ManiphestTransaction()) 166 168 ->setTransactionType(ManiphestTransaction::TYPE_MERGED_INTO)

+1 -1

src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php

reviewed

··· 75 75 array( 76 76 'class' => 'button small grey', 77 77 'href' => $uri->alter('delete', $email->getID()), 78 78 - 'sigil' => 'workflow' 78 78 + 'sigil' => 'workflow', 79 79 ), 80 80 pht('Remove')); 81 81

+2 -1

src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php

reviewed

··· 146 146 foreach ($editors as $editor) { 147 147 $tag_groups[] = array( 148 148 $editor->getEditorObjectsDescription(), 149 149 - array_diff_key($editor->getMailTagsMap(), $common_tags)); 149 149 + array_diff_key($editor->getMailTagsMap(), $common_tags), 150 150 + ); 150 151 } 151 152 152 153 // Sort them, then put "Common" at the top.

+2 -1

src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php

reviewed

··· 65 65 return id(new AphrontAjaxResponse()) 66 66 ->setContent(array( 67 67 'pollID' => $poll->getID(), 68 68 - 'contentHTML' => $embed->render())); 68 68 + 'contentHTML' => $embed->render(), 69 69 + )); 69 70 } 70 71 71 72 if (!$request->isFormPost()) {

+9 -6

src/applications/slowvote/view/SlowvoteEmbedView.php

reviewed

··· 48 48 require_celerity_resource('javelin-behavior-slowvote-embed'); 49 49 50 50 $config = array( 51 51 - 'pollID' => $poll->getID()); 51 51 + 'pollID' => $poll->getID(), 52 52 + ); 52 53 Javelin::initBehavior('slowvote-embed', $config); 53 54 54 55 $user_choices = $poll->getViewerChoices($this->getUser()); ··· 63 64 $link_to_slowvote = phutil_tag( 64 65 'a', 65 66 array( 66 66 - 'href' => '/V'.$poll->getID() 67 67 + 'href' => '/V'.$poll->getID(), 67 68 ), 68 69 $poll->getQuestion()); 69 70 ··· 83 84 array( 84 85 'V'.$poll->getID(), 85 86 ' ', 86 86 - $link_to_slowvote))); 87 87 + $link_to_slowvote, 88 88 + ))); 87 89 88 90 $description = null; 89 91 if ($poll->getDescription()) { ··· 102 104 103 105 $header = array( 104 106 $header, 105 105 - $description); 107 107 + $description, 108 108 + ); 106 109 } 107 110 108 111 $vis = $poll->getResponseVisibility(); ··· 171 174 'class' => 'slowvote-embed', 172 175 'sigil' => 'slowvote-embed', 173 176 'meta' => array( 174 174 - 'pollID' => $poll->getID() 175 175 - ) 177 177 + 'pollID' => $poll->getID(), 178 178 + ), 176 179 ), 177 180 array($header, $body)); 178 181 }

+1 -1

src/applications/subscriptions/view/SubscriptionListStringBuilder.php

reviewed

··· 69 69 'a', 70 70 array( 71 71 'href' => $list_uri, 72 72 - 'sigil' => 'workflow' 72 72 + 'sigil' => 'workflow', 73 73 ), 74 74 $not_shown_txt); 75 75

+1 -1

src/applications/tokens/controller/PhabricatorTokenGiveController.php

reviewed

··· 90 90 'sigil' => 'has-tooltip', 91 91 'meta' => array( 92 92 'tip' => $token->getName(), 93 93 - ) 93 93 + ), 94 94 ), 95 95 array( 96 96 $aural,

+5 -4

src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php

reviewed

··· 99 99 $details[] = phutil_tag( 100 100 'p', 101 101 array( 102 102 - 'class' => 'policy-transaction-detail-intro' 102 102 + 'class' => 'policy-transaction-detail-intro', 103 103 ), 104 104 pht('These rules are processed in order:')); 105 105 ··· 123 123 } 124 124 $details[] = phutil_tag('div', 125 125 array( 126 126 - 'class' => 'policy-transaction-detail-row' 126 126 + 'class' => 'policy-transaction-detail-row', 127 127 ), 128 128 array( 129 129 $icon, 130 130 - $value)); 130 130 + $value, 131 131 + )); 131 132 } 132 133 133 134 $details[] = phutil_tag( 134 135 'p', 135 136 array( 136 136 - 'class' => 'policy-transaction-detail-end' 137 137 + 'class' => 'policy-transaction-detail-end', 137 138 ), 138 139 pht( 139 140 'If no rules match, %s all other users.',

+1 -1

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

reviewed

··· 92 92 'a', 93 93 array( 94 94 'class' => 'login-to-comment button', 95 95 - 'href' => $uri 95 95 + 'href' => $uri, 96 96 ), 97 97 pht('Login to Comment'))); 98 98 }

+2 -2

src/applications/uiexample/examples/JavelinReactorExample.php

reviewed

··· 24 24 'Reactive checkbox generates a boolean dynamic value', 25 25 'ReactorCheckboxExample', 26 26 'phabricator-uiexample-reactor-checkbox', 27 27 - array('checked' => true) 27 27 + array('checked' => true), 28 28 ), 29 29 array( 30 30 'Reactive focus detector generates a boolean dynamic value', ··· 60 60 'sendclass makes the class of an element a string dynamic value', 61 61 'ReactorSendClassExample', 62 62 'phabricator-uiexample-reactor-sendclass', 63 63 - array() 63 63 + array(), 64 64 ), 65 65 array( 66 66 'sendproperties makes some properties of an object into dynamic values',

+1 -1

src/applications/uiexample/examples/PHUIActionHeaderExample.php

reviewed

··· 264 264 $title3, 265 265 $wrap3, 266 266 $title4, 267 267 - $wrap4 267 267 + $wrap4, 268 268 )); 269 269 } 270 270 }

+6 -3

src/applications/uiexample/examples/PHUIBoxExample.php

reviewed

··· 23 23 id(new PHUIBoxView()) 24 24 ->appendChild($content2), 25 25 id(new PHUIBoxView()) 26 26 - ->appendChild($content3)); 26 26 + ->appendChild($content3), 27 27 + ); 27 28 28 29 29 30 $layout2 = ··· 38 39 id(new PHUIBoxView()) 39 40 ->appendChild($content3) 40 41 ->addMargin(PHUI::MARGIN_LARGE_LEFT) 41 41 - ->addMargin(PHUI::MARGIN_LARGE_TOP)); 42 42 + ->addMargin(PHUI::MARGIN_LARGE_TOP), 43 43 + ); 42 44 43 45 $layout3 = 44 46 array( ··· 56 58 ->appendChild($content3) 57 59 ->setBorder(true) 58 60 ->addPadding(PHUI::PADDING_LARGE) 59 59 - ->addMargin(PHUI::MARGIN_LARGE_BOTTOM)); 61 61 + ->addMargin(PHUI::MARGIN_LARGE_BOTTOM), 62 62 + ); 60 63 61 64 $image = id(new PHUIIconView()) 62 65 ->setIconFont('fa-heart');

+2 -1

src/applications/uiexample/examples/PHUIButtonBarExample.php

reviewed

··· 19 19 'Go Back' => 'fa-chevron-left bluegrey', 20 20 'Choose Date' => 'fa-calendar bluegrey', 21 21 'Edit View' => 'fa-pencil bluegrey', 22 22 - 'Go Forward' => 'fa-chevron-right bluegrey'); 22 22 + 'Go Forward' => 'fa-chevron-right bluegrey', 23 23 + ); 23 24 $button_bar = new PHUIButtonBarView(); 24 25 foreach ($icons as $text => $icon) { 25 26 $image = id(new PHUIIconView())

+12 -8

src/applications/uiexample/examples/PHUIButtonExample.php

reviewed

··· 48 48 $column3[] = phutil_tag( 49 49 'a', 50 50 array( 51 51 - 'class' => $color.' button dropdown' 51 51 + 'class' => $color.' button dropdown', 52 52 ), 53 53 array( 54 54 phutil_utf8_ucwords($color.' Dropdown'), ··· 67 67 // PHUIButtonView 68 68 69 69 $colors = array(null, 70 70 - PHUIButtonView::GREEN, 71 71 - PHUIButtonView::GREY, 72 72 - PHUIButtonView::BLACK, 73 73 - PHUIButtonView::DISABLED); 70 70 + PHUIButtonView::GREEN, 71 71 + PHUIButtonView::GREY, 72 72 + PHUIButtonView::BLACK, 73 73 + PHUIButtonView::DISABLED, 74 74 + ); 74 75 $sizes = array(null, PHUIButtonView::SMALL); 75 76 $column = array(); 76 77 foreach ($colors as $color) { ··· 106 107 'Comment' => 'fa-comment', 107 108 'Give Token' => 'fa-trophy', 108 109 'Reverse Time' => 'fa-clock-o', 109 109 - 'Implode Earth' => 'fa-exclamation-triangle red'); 110 110 + 'Implode Earth' => 'fa-exclamation-triangle red', 111 111 + ); 110 112 foreach ($icons as $text => $icon) { 111 113 $image = id(new PHUIIconView()) 112 114 ->setIconFont($icon); ··· 121 123 $column2 = array(); 122 124 $icons = array( 123 125 'Subscribe' => 'fa-check-circle bluegrey', 124 124 - 'Edit' => 'fa-pencil bluegrey'); 126 126 + 'Edit' => 'fa-pencil bluegrey', 127 127 + ); 125 128 foreach ($icons as $text => $icon) { 126 129 $image = id(new PHUIIconView()) 127 130 ->setIconFont($icon); ··· 195 198 ->addMargin(PHUI::MARGIN_LARGE); 196 199 197 200 return array($head1, $wrap1, $head2, $wrap2, $head3, $wrap3, 198 198 - $head4, $wrap4); 201 201 + $head4, $wrap4, 202 202 + ); 199 203 } 200 204 }

+11 -7

src/applications/uiexample/examples/PHUIColorPalletteExample.php

reviewed

··· 28 28 'c6539d' => 'Base Indigo {$indigo}', 29 29 'f5e2ef' => '83% Indigo {$lightindigo}', 30 30 '8e44ad' => 'Base Violet {$violet}', 31 31 - 'ecdff1' => '83% Violet {$lightviolet}' 31 31 + 'ecdff1' => '83% Violet {$lightviolet}', 32 32 ); 33 33 34 34 $greys = array( ··· 61 61 'div', 62 62 array( 63 63 'style' => 'background-color: #'.$color.';', 64 64 - 'class' => 'pl'), 64 64 + 'class' => 'pl', 65 65 + ), 65 66 $name.' #'.$color); 66 67 } 67 68 ··· 71 72 'div', 72 73 array( 73 74 'style' => 'background-color: #'.$color.';', 74 74 - 'class' => 'pl'), 75 75 + 'class' => 'pl', 76 76 + ), 75 77 $name.' #'.$color); 76 78 } 77 79 ··· 84 86 'div', 85 87 array( 86 88 'style' => 'background-color: #'.$color.';', 87 87 - 'class' => 'pl'), 89 89 + 'class' => 'pl', 90 90 + ), 88 91 $name.' #'.$color); 89 92 } 90 93 ··· 92 95 'a', 93 96 array( 94 97 'href' => 'http://color.hailpixel.com/#'.implode(',', $url), 95 95 - 'class' => 'button grey mlb'), 98 98 + 'class' => 'button grey mlb', 99 99 + ), 96 100 'Color Palette'); 97 101 98 102 $wrap1 = id(new PHUIObjectBoxView()) ··· 113 117 array( 114 118 $wrap1, 115 119 $wrap2, 116 116 - $wrap3 120 120 + $wrap3, 117 121 )); 118 118 - } 122 122 + } 119 123 }

+1 -1

src/applications/uiexample/examples/PHUIDocumentExample.php

reviewed

··· 48 48 ->setIcon('fa-plus-circle') 49 49 ->setType(PHUIListItemView::TYPE_LINK); 50 50 51 51 - $divider = id(new PHUIListItemView) 51 51 + $divider = id(new PHUIListItemView()) 52 52 ->setType(PHUIListItemView::TYPE_DIVIDER); 53 53 54 54 $header = id(new PHUIHeaderView())

+15 -8

src/applications/uiexample/examples/PHUIFeedStoryExample.php

reviewed

··· 32 32 'like-1', 33 33 'like-2', 34 34 'heart-1', 35 35 - 'heart-2'); 35 35 + 'heart-2', 36 36 + ); 36 37 $tokenview = array(); 37 38 foreach ($tokens as $token) { 38 39 $tokenview[] = ··· 152 153 id(new PHUIBoxView()) 153 154 ->appendChild($story1) 154 155 ->addMargin(PHUI::MARGIN_MEDIUM) 155 155 - ->addPadding(PHUI::PADDING_SMALL)); 156 156 + ->addPadding(PHUI::PADDING_SMALL), 157 157 + ); 156 158 157 159 $wrap2 = 158 160 array( 159 161 id(new PHUIBoxView()) 160 162 ->appendChild($story2) 161 163 ->addMargin(PHUI::MARGIN_MEDIUM) 162 162 - ->addPadding(PHUI::PADDING_SMALL)); 164 164 + ->addPadding(PHUI::PADDING_SMALL), 165 165 + ); 163 166 164 167 $wrap3 = 165 168 array( 166 169 id(new PHUIBoxView()) 167 170 ->appendChild($story3) 168 171 ->addMargin(PHUI::MARGIN_MEDIUM) 169 169 - ->addPadding(PHUI::PADDING_SMALL)); 172 172 + ->addPadding(PHUI::PADDING_SMALL), 173 173 + ); 170 174 171 175 $wrap4 = 172 176 array( 173 177 id(new PHUIBoxView()) 174 178 ->appendChild($story4) 175 179 ->addMargin(PHUI::MARGIN_MEDIUM) 176 176 - ->addPadding(PHUI::PADDING_SMALL)); 180 180 + ->addPadding(PHUI::PADDING_SMALL), 181 181 + ); 177 182 178 183 $wrap5 = 179 184 array( 180 185 id(new PHUIBoxView()) 181 186 ->appendChild($story5) 182 187 ->addMargin(PHUI::MARGIN_MEDIUM) 183 183 - ->addPadding(PHUI::PADDING_SMALL)); 188 188 + ->addPadding(PHUI::PADDING_SMALL), 189 189 + ); 184 190 185 191 $wrap6 = 186 192 array( 187 193 id(new PHUIBoxView()) 188 194 ->appendChild($story6) 189 195 ->addMargin(PHUI::MARGIN_MEDIUM) 190 190 - ->addPadding(PHUI::PADDING_SMALL)); 196 196 + ->addPadding(PHUI::PADDING_SMALL), 197 197 + ); 191 198 192 199 return phutil_tag( 193 200 'div', ··· 204 211 $head5, 205 212 $wrap5, 206 213 $head6, 207 207 - $wrap6 214 214 + $wrap6, 208 215 )); 209 216 } 210 217 }

+7 -5

src/applications/uiexample/examples/PHUIIconExample.php

reviewed

··· 109 109 'like-1', 110 110 'like-2', 111 111 'heart-1', 112 112 - 'heart-2'); 112 112 + 'heart-2', 113 113 + ); 113 114 $tokenview = array(); 114 115 foreach ($tokens as $token) { 115 116 $tokenview[] = ··· 122 123 'Asana', 123 124 'Dropbox', 124 125 'Google', 125 125 - 'Github'); 126 126 + 'Github', 127 127 + ); 126 128 $loginview = array(); 127 129 foreach ($logins as $login) { 128 130 $loginview[] = ··· 163 165 $fa_link = phutil_tag( 164 166 'a', 165 167 array( 166 166 - 'href' => 'http://fontawesome.io' 168 168 + 'href' => 'http://fontawesome.io', 167 169 ), 168 170 'http://fontawesome.io'); 169 171 $fa_text = pht('Font Awesome by Dave Gandy - %s', $fa_link); ··· 203 205 $wrap2, 204 206 $wrap3, 205 207 $wrap4, 206 206 - $wrap5 208 208 + $wrap5, 207 209 )); 208 208 - } 210 210 + } 209 211 }

+1 -1

src/applications/uiexample/examples/PHUIImageMaskExample.php

reviewed

··· 82 82 $box2, 83 83 $box3, 84 84 $box4, 85 85 - $box5 85 85 + $box5, 86 86 )); 87 87 } 88 88 }

+2 -2

src/applications/uiexample/examples/PHUIInfoPanelExample.php

reviewed

··· 133 133 $head1, 134 134 $wrap1, 135 135 $head2, 136 136 - $wrap2 136 136 + $wrap2, 137 137 )); 138 138 - } 138 138 + } 139 139 }

+13 -8

src/applications/uiexample/examples/PHUIListExample.php

reviewed

··· 84 84 ->setHref('#') 85 85 ->setType(PHUIListItemView::TYPE_LINK); 86 86 87 87 - $divider = id(new PHUIListItemView) 87 87 + $divider = id(new PHUIListItemView()) 88 88 ->setType(PHUIListItemView::TYPE_DIVIDER); 89 89 90 90 $sidenav = id(new PHUIListView()) ··· 211 211 ->appendChild($unstyled) 212 212 ->addMargin(PHUI::MARGIN_MEDIUM) 213 213 ->addPadding(PHUI::PADDING_SMALL) 214 214 - ->setBorder(true)); 214 214 + ->setBorder(true), 215 215 + ); 215 216 216 217 $layout2 = 217 218 array( 218 219 id(new PHUIBoxView()) 219 220 ->appendChild($sidenav) 220 221 ->addMargin(PHUI::MARGIN_MEDIUM) 221 221 - ->setBorder(true)); 222 222 + ->setBorder(true), 223 223 + ); 222 224 223 225 $layout3 = 224 226 array( 225 227 id(new PHUIBoxView()) 226 228 ->appendChild($topnav) 227 229 ->addMargin(PHUI::MARGIN_MEDIUM) 228 228 - ->setBorder(true)); 230 230 + ->setBorder(true), 231 231 + ); 229 232 230 233 $layout4 = 231 234 array( 232 235 id(new PHUIBoxView()) 233 236 ->appendChild($actionmenu) 234 237 ->addMargin(PHUI::MARGIN_MEDIUM) 235 235 - ->setBorder(true)); 238 238 + ->setBorder(true), 239 239 + ); 236 240 237 241 $layout5 = 238 242 array( 239 243 id(new PHUIBoxView()) 240 244 ->appendChild($statustabs) 241 245 ->addMargin(PHUI::MARGIN_MEDIUM) 242 242 - ->setBorder(true)); 246 246 + ->setBorder(true), 247 247 + ); 243 248 244 249 $head1 = id(new PHUIHeaderView()) 245 250 ->setHeader(pht('Unstyled')); ··· 291 296 $head5, 292 297 $wrap5, 293 298 $head4, 294 294 - $wrap4 299 299 + $wrap4, 295 300 )); 296 296 - } 301 301 + } 297 302 }

+6 -4

src/applications/uiexample/examples/PHUITextExample.php

reviewed

··· 54 54 ->addClass(PHUI::TEXT_WHITE), 55 55 id(new PHUITextView()) 56 56 ->setText($color9) 57 57 - ->addClass(PHUI::TEXT_BLACK)); 57 57 + ->addClass(PHUI::TEXT_BLACK), 58 58 + ); 58 59 59 60 $content2 = 60 61 array( ··· 66 67 ->addClass(PHUI::TEXT_UPPERCASE), 67 68 id(new PHUITextView()) 68 69 ->setText($text3) 69 69 - ->addClass(PHUI::TEXT_STRIKE)); 70 70 + ->addClass(PHUI::TEXT_STRIKE), 71 71 + ); 70 72 71 73 $layout1 = id(new PHUIBoxView()) 72 74 ->appendChild($content) ··· 99 101 $head1, 100 102 $wrap1, 101 103 $head2, 102 102 - $wrap2 104 104 + $wrap2, 103 105 )); 104 104 - } 106 106 + } 105 107 }

+9 -9

src/applications/uiexample/examples/PhabricatorMultiColumnExample.php

reviewed

··· 19 19 'div', 20 20 array( 21 21 'class' => 'pm', 22 22 - 'style' => 'border: 1px solid green;' 22 22 + 'style' => 'border: 1px solid green;', 23 23 ), 24 24 'Bruce Campbell'); 25 25 ··· 27 27 'div', 28 28 array( 29 29 'class' => 'pm', 30 30 - 'style' => 'border: 1px solid blue;' 30 30 + 'style' => 'border: 1px solid blue;', 31 31 ), 32 32 'Army of Darkness'); 33 33 ··· 165 165 $wrap1 = phutil_tag( 166 166 'div', 167 167 array( 168 168 - 'class' => 'ml' 168 168 + 'class' => 'ml', 169 169 ), 170 170 $layout1); 171 171 172 172 $wrap2 = phutil_tag( 173 173 'div', 174 174 array( 175 175 - 'class' => 'ml' 175 175 + 'class' => 'ml', 176 176 ), 177 177 $layout2); 178 178 179 179 $wrap3 = phutil_tag( 180 180 'div', 181 181 array( 182 182 - 'class' => 'ml' 182 182 + 'class' => 'ml', 183 183 ), 184 184 $layout3); 185 185 186 186 $wrap4 = phutil_tag( 187 187 'div', 188 188 array( 189 189 - 'class' => 'ml' 189 189 + 'class' => 'ml', 190 190 ), 191 191 $layout4); 192 192 193 193 $wrap5 = phutil_tag( 194 194 'div', 195 195 array( 196 196 - 'class' => 'ml' 196 196 + 'class' => 'ml', 197 197 ), 198 198 $layout5); 199 199 200 200 $wrap6 = phutil_tag( 201 201 'div', 202 202 array( 203 203 - 'class' => 'ml' 203 203 + 'class' => 'ml', 204 204 ), 205 205 $layout6); 206 206 ··· 219 219 $head5, 220 220 $wrap5, 221 221 $head6, 222 222 - $wrap6 222 222 + $wrap6, 223 223 )); 224 224 } 225 225 }

+5 -5

src/applications/uiexample/examples/PhabricatorTwoColumnExample.php

reviewed

··· 15 15 $main = phutil_tag( 16 16 'div', 17 17 array( 18 18 - 'style' => 'border: 1px solid blue; padding: 20px;' 18 18 + 'style' => 'border: 1px solid blue; padding: 20px;', 19 19 ), 20 20 'Mary, mary quite contrary.'); 21 21 22 22 $side = phutil_tag( 23 23 'div', 24 24 array( 25 25 - 'style' => 'border: 1px solid red; padding: 20px;' 25 25 + 'style' => 'border: 1px solid red; padding: 20px;', 26 26 ), 27 27 'How does your garden grow?'); 28 28 29 29 30 30 - $content = id(new AphrontTwoColumnView) 31 31 - ->setMainColumn($main) 32 32 - ->setSideColumn($side); 30 30 + $content = id(new AphrontTwoColumnView()) 31 31 + ->setMainColumn($main) 32 32 + ->setSideColumn($side); 33 33 34 34 return $content; 35 35 }

+2 -1

src/infrastructure/celerity/CelerityStaticResourceResponse.php

reviewed

··· 206 206 207 207 $behavior_groups = array( 208 208 $higher_priority_behaviors, 209 209 - $behaviors); 209 209 + $behaviors, 210 210 + ); 210 211 211 212 foreach ($behavior_groups as $group) { 212 213 if (!$group) {

+2 -1

src/infrastructure/daemon/bot/adapter/PhabricatorBotFlowdockProtocolAdapter.php

reviewed

··· 76 76 array( 77 77 'flow' => $flow->getName(), 78 78 'event' => 'message', 79 79 - 'content' => $body)); 79 79 + 'content' => $body, 80 80 + )); 80 81 } 81 82 82 83 public function __destruct() {

+3 -1

src/infrastructure/daemon/bot/adapter/PhabricatorCampfireProtocolAdapter.php

reviewed

··· 92 92 array( 93 93 'message' => array( 94 94 'type' => $type, 95 95 - 'body' => $message))); 95 95 + 'body' => $message, 96 96 + ), 97 97 + )); 96 98 } 97 99 98 100 public function __destruct() {

+6 -3

src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php

reviewed

··· 20 20 21 21 // Hash map of command translations 22 22 public static $commandTranslations = array( 23 23 - 'PRIVMSG' => 'MESSAGE'); 23 23 + 'PRIVMSG' => 'MESSAGE', 24 24 + ); 24 25 25 26 public function connect() { 26 27 $nick = $this->getConfig('nick', 'phabot'); ··· 246 247 247 248 return array( 248 249 $target, 249 249 - rtrim($matches[2], "\r\n")); 250 250 + rtrim($matches[2], "\r\n"), 251 251 + ); 250 252 } 251 253 break; 252 254 } ··· 254 256 // By default we assume there is no target, only a body 255 257 return array( 256 258 null, 257 257 - $data); 259 259 + $data, 260 260 + ); 258 261 } 259 262 260 263 public function disconnect() {

+1 -1

src/infrastructure/daemon/bot/handler/PhabricatorBotWhatsNewHandler.php

reviewed

··· 30 30 'feed.query', 31 31 array( 32 32 'limit' => 5, 33 33 - 'view' => 'text' 33 33 + 'view' => 'text', 34 34 )); 35 35 36 36 foreach ($latest as $feed_item) {

+4 -2

src/infrastructure/diff/view/PhabricatorInlineSummaryView.php

reviewed

··· 26 26 'phabricator-inline-summary', 27 27 array( 28 28 $icon, 29 29 - pht('Inline Comments'))); 29 29 + pht('Inline Comments'), 30 30 + )); 30 31 return $header; 31 32 } 32 33 ··· 101 102 'class' => 'inline-summary-content', 102 103 'colspan' => $colspan, 103 104 ), 104 104 - phutil_tag_div('phabricator-remarkup', $item['content'])))); 105 105 + phutil_tag_div('phabricator-remarkup', $item['content'])), 106 106 + )); 105 107 } 106 108 } 107 109

+6 -6

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

reviewed

··· 375 375 '%s added %d blocking task(s): %s.' => array( 376 376 array( 377 377 '%s added a blocking task: %3$s.', 378 378 - '%s added blocking tasks: %3$s.' 378 378 + '%s added blocking tasks: %3$s.', 379 379 ), 380 380 ), 381 381 382 382 '%s added %d blocked task(s): %s.' => array( 383 383 array( 384 384 '%s added a blocked task: %3$s.', 385 385 - '%s added blocked tasks: %3$s.' 386 386 - ) 385 385 + '%s added blocked tasks: %3$s.', 386 386 + ), 387 387 ), 388 388 389 389 '%s removed %d blocking task(s): %s.' => array( 390 390 array( 391 391 '%s removed a blocking task: %3$s.', 392 392 - '%s removed blocking tasks: %3$s.' 392 392 + '%s removed blocking tasks: %3$s.', 393 393 ), 394 394 ), 395 395 396 396 '%s removed %d blocked task(s): %s.' => array( 397 397 array( 398 398 '%s removed a blocked task: %3$s.', 399 399 - '%s removed blocked tasks: %3$s.' 400 400 - ) 399 399 + '%s removed blocked tasks: %3$s.', 400 400 + ), 401 401 ), 402 402 403 403 '%s edited answer(s), added %d: %s; removed %d: %s.' =>

+2 -1

src/infrastructure/sms/adapter/PhabricatorSMSImplementationTestBlackholeAdapter.php

reviewed

··· 17 17 public function getSMSDataFromResult($result) { 18 18 return array( 19 19 Filesystem::readRandomCharacters(40), 20 20 - PhabricatorSMS::STATUS_SENT); 20 20 + PhabricatorSMS::STATUS_SENT, 21 21 + ); 21 22 } 22 23 23 24 public function pollSMSSentStatus(PhabricatorSMS $sms) {

+2 -1

src/infrastructure/sms/worker/PhabricatorSMSDemultiplexWorker.php

reviewed

··· 23 23 $this->queueTask( 24 24 'PhabricatorSMSSendWorker', 25 25 array( 26 26 - 'smsID' => $sms->getID())); 26 26 + 'smsID' => $sms->getID(), 27 27 + )); 27 28 } 28 29 } 29 30

+1 -1

src/infrastructure/storage/lisk/__tests__/LiskChunkTestCase.php

reviewed

··· 23 23 24 24 25 25 $fragments = array( 26 26 - 'a', 'a', 'a', 'XX', 'a', 'a', 'a', 'a' 26 26 + 'a', 'a', 'a', 'XX', 'a', 'a', 'a', 'a', 27 27 ); 28 28 29 29 $this->assertEqual(

+2 -1

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php

reviewed

··· 14 14 'name' => 'unittest-fixtures', 15 15 'help' => 'Restrict **destroy** operations to databases created '. 16 16 'by PhabricatorTestCase test fixtures.', 17 17 - ))); 17 17 + ), 18 18 + )); 18 19 } 19 20 20 21 public function execute(PhutilArgumentParser $args) {

+5 -3

src/view/AphrontDialogView.php

reviewed

··· 262 262 'type' => 'hidden', 263 263 'name' => $key, 264 264 'value' => $value, 265 265 - 'sigil' => 'aphront-dialog-application-input' 265 265 + 'sigil' => 'aphront-dialog-application-input', 266 266 )); 267 267 } 268 268 ··· 270 270 $buttons = array(phabricator_form( 271 271 $this->user, 272 272 $form_attributes, 273 273 - array_merge($hidden_inputs, $buttons))); 273 273 + array_merge($hidden_inputs, $buttons)), 274 274 + ); 274 275 } 275 276 276 277 $children = $this->renderChildren(); ··· 288 289 if ($errors) { 289 290 $children = array( 290 291 id(new AphrontErrorView())->setErrors($errors), 291 291 - $children); 292 292 + $children, 293 293 + ); 292 294 } 293 295 294 296 $header = new PHUIActionHeaderView();

+2 -1

src/view/control/AphrontTokenizerTemplateView.php

reviewed

··· 83 83 array( 84 84 'class' => 'phui-icon-view phui-font-fa bluetext '.$icon, 85 85 )), 86 86 - $value); 86 86 + $value, 87 87 + ); 87 88 } 88 89 89 90 return phutil_tag(

+1 -1

src/view/form/control/AphrontFormCheckboxControl.php

reviewed

··· 40 40 $box['label']); 41 41 $rows[] = phutil_tag('tr', array(), array( 42 42 phutil_tag('td', array(), $checkbox), 43 43 - phutil_tag('th', array(), $label) 43 43 + phutil_tag('th', array(), $label), 44 44 )); 45 45 } 46 46 return phutil_tag(

+3 -3

src/view/form/control/AphrontFormCropControl.php

reviewed

··· 32 32 return phutil_tag( 33 33 'img', 34 34 array( 35 35 - 'src' => PhabricatorUser::getDefaultProfileImageURI() 35 35 + 'src' => PhabricatorUser::getDefaultProfileImageURI(), 36 36 ), 37 37 ''); 38 38 } ··· 61 61 'id' => $c_id, 62 62 'sigil' => 'crop-box', 63 63 'mustcapture' => true, 64 64 - 'class' => 'crop-box' 64 64 + 'class' => 'crop-box', 65 65 ), 66 66 array( 67 67 javelin_tag( ··· 69 69 array( 70 70 'src' => $file->getBestURI(), 71 71 'class' => 'crop-image', 72 72 - 'sigil' => 'crop-image' 72 72 + 'sigil' => 'crop-image', 73 73 ), 74 74 ''), 75 75 javelin_tag(

+1 -1

src/view/form/control/AphrontFormTextControl.php

reviewed

··· 48 48 'autocomplete' => $this->getDisableAutocomplete() ? 'off' : null, 49 49 'id' => $this->getID(), 50 50 'sigil' => $this->getSigil(), 51 51 - 'placeholder' => $this->getPlaceholder() 51 51 + 'placeholder' => $this->getPlaceholder(), 52 52 )); 53 53 } 54 54

+1 -1

src/view/form/control/AphrontFormTextWithSubmitControl.php

reviewed

··· 49 49 array( 50 50 'type' => 'submit', 51 51 'class' => 'text-with-submit-control-submit grey', 52 52 - 'value' => coalesce($this->getSubmitLabel(), pht('Submit')) 52 52 + 'value' => coalesce($this->getSubmitLabel(), pht('Submit')), 53 53 ))), 54 54 )); 55 55 }

+1 -1

src/view/layout/AphrontListFilterView.php

reviewed

··· 110 110 return phutil_tag( 111 111 'div', 112 112 array( 113 113 - 'class' => 'aphront-list-filter-wrap' 113 113 + 'class' => 'aphront-list-filter-wrap', 114 114 ), 115 115 $content); 116 116 }

+7 -4

src/view/layout/AphrontMultiColumnView.php

reviewed

··· 31 31 'column' => $column, 32 32 'class' => $class, 33 33 'sigil' => $sigil, 34 34 - 'metadata' => $metadata); 34 34 + 'metadata' => $metadata, 35 35 + ); 35 36 return $this; 36 37 } 37 38 ··· 95 96 array( 96 97 'class' => implode(' ', $column_class), 97 98 'sigil' => $column_sigil, 98 98 - 'meta' => $column_metadata), 99 99 + 'meta' => $column_metadata, 100 100 + ), 99 101 $column); 100 102 $columns[] = phutil_tag( 101 103 'div', 102 104 array( 103 103 - 'class' => implode(' ', $outer_class)), 105 105 + 'class' => implode(' ', $outer_class), 106 106 + ), 104 107 $column_inner); 105 108 } 106 109 ··· 127 130 $board = phutil_tag( 128 131 'div', 129 132 array( 130 130 - 'class' => implode(' ', $classes) 133 133 + 'class' => implode(' ', $classes), 131 134 ), 132 135 $view); 133 136

+1 -1

src/view/layout/AphrontSideNavFilterView.php

reviewed

··· 294 294 array( 295 295 $crumbs, 296 296 $this->renderChildren(), 297 297 - )) 297 297 + )), 298 298 )); 299 299 } 300 300

+3 -3

src/view/layout/AphrontTwoColumnView.php

reviewed

··· 33 33 $main = phutil_tag( 34 34 'div', 35 35 array( 36 36 - 'class' => 'aphront-main-column' 36 36 + 'class' => 'aphront-main-column', 37 37 ), 38 38 $this->mainColumn); 39 39 40 40 $side = phutil_tag( 41 41 'div', 42 42 array( 43 43 - 'class' => 'aphront-side-column' 43 43 + 'class' => 'aphront-side-column', 44 44 ), 45 45 $this->sideColumn); 46 46 ··· 56 56 return phutil_tag( 57 57 'div', 58 58 array( 59 59 - 'class' => implode(' ', $classes) 59 59 + 'class' => implode(' ', $classes), 60 60 ), 61 61 array( 62 62 $main,

+1 -1

src/view/layout/PhabricatorActionListView.php

reviewed

··· 57 57 'ul', 58 58 array( 59 59 'class' => 'phabricator-action-list-view', 60 60 - 'id' => $this->id 60 60 + 'id' => $this->id, 61 61 ), 62 62 $actions); 63 63 }

+4 -4

src/view/layout/PhabricatorCrumbsView.php

reviewed

··· 63 63 $name = phutil_tag( 64 64 'span', 65 65 array( 66 66 - 'class' => 'phabricator-crumbs-action-name' 66 66 + 'class' => 'phabricator-crumbs-action-name', 67 67 ), 68 68 $action->getName()); 69 69 ··· 84 84 'href' => $action->getHref(), 85 85 'class' => implode(' ', $action_classes), 86 86 'sigil' => implode(' ', $action_sigils), 87 87 - 'style' => $action->getStyle() 87 87 + 'style' => $action->getStyle(), 88 88 ), 89 89 array( 90 90 $icon, ··· 99 99 $name = phutil_tag( 100 100 'span', 101 101 array( 102 102 - 'class' => 'phabricator-crumbs-action-name' 102 102 + 'class' => 'phabricator-crumbs-action-name', 103 103 ), 104 104 pht('Actions')); 105 105 ··· 114 114 'meta' => array( 115 115 'map' => array( 116 116 $this->actionListID => 'phabricator-action-list-toggle', 117 117 - $icon_id => 'phabricator-crumbs-action-menu-open' 117 117 + $icon_id => 'phabricator-crumbs-action-menu-open', 118 118 ), 119 119 ), 120 120 ),

+6 -5

src/view/layout/PhabricatorSourceCodeView.php

reviewed

··· 77 77 $tag_number = javelin_tag( 78 78 'a', 79 79 array( 80 80 - 'href' => $line_href 80 80 + 'href' => $line_href, 81 81 ), 82 82 $line_number); 83 83 } else { ··· 95 95 'th', 96 96 array( 97 97 'class' => 'phabricator-source-line', 98 98 - 'sigil' => 'phabricator-source-line' 98 98 + 'sigil' => 'phabricator-source-line', 99 99 ), 100 100 $tag_number), 101 101 phutil_tag( 102 102 'td', 103 103 array( 104 104 - 'class' => 'phabricator-source-code' 104 104 + 'class' => 'phabricator-source-code', 105 105 ), 106 106 - $content_line))); 106 106 + $content_line), 107 107 + )); 107 108 108 109 if ($hit_limit) { 109 110 break; ··· 123 124 'table', 124 125 array( 125 126 'class' => implode(' ', $classes), 126 126 - 'sigil' => 'phabricator-source' 127 127 + 'sigil' => 'phabricator-source', 127 128 ), 128 129 phutil_implode_html('', $rows))); 129 130 }

+2 -2

src/view/page/PhabricatorBarePageView.php

reviewed

··· 79 79 'link', 80 80 array( 81 81 'rel' => 'apple-touch-icon', 82 82 - 'href' => celerity_get_resource_uri('/rsrc/image/apple-touch-icon.png') 82 82 + 'href' => celerity_get_resource_uri('/rsrc/image/apple-touch-icon.png'), 83 83 )); 84 84 85 85 $apple_tag = phutil_tag( 86 86 'meta', 87 87 array( 88 88 'name' => 'apple-mobile-web-app-status-bar-style', 89 89 - 'content' => 'black-translucent' 89 89 + 'content' => 'black-translucent', 90 90 )); 91 91 92 92 $referrer_tag = phutil_tag(

+4 -3

src/view/page/menu/PhabricatorMainMenuView.php

reviewed

··· 314 314 'span', 315 315 array( 316 316 'id' => $message_count_id, 317 317 - 'class' => 'phabricator-main-menu-message-count' 317 317 + 'class' => 'phabricator-main-menu-message-count', 318 318 ), 319 319 $message_count_number); 320 320 ··· 398 398 'span', 399 399 array( 400 400 'id' => $count_id, 401 401 - 'class' => 'phabricator-main-menu-alert-count' 401 401 + 'class' => 'phabricator-main-menu-alert-count', 402 402 ), 403 403 $count_number); 404 404 ··· 447 447 448 448 $dropdowns = array( 449 449 $notification_dropdown, 450 450 - $message_notification_dropdown); 450 450 + $message_notification_dropdown, 451 451 + ); 451 452 452 453 $applications = PhabricatorApplication::getAllInstalledApplications(); 453 454 foreach ($applications as $application) {

+9 -8

src/view/phui/PHUIActionHeaderView.php

reviewed

··· 99 99 $action_list[] = phutil_tag( 100 100 'li', 101 101 array( 102 102 - 'class' => 'phui-action-header-icon-item' 102 102 + 'class' => 'phui-action-header-icon-item', 103 103 ), 104 104 $action); 105 105 } ··· 109 109 $action_list[] = phutil_tag( 110 110 'li', 111 111 array( 112 112 - 'class' => 'phui-action-header-icon-item' 112 112 + 'class' => 'phui-action-header-icon-item', 113 113 ), 114 114 $this->tag); 115 115 } ··· 126 126 array( 127 127 'class' => 'phui-action-header-link', 128 128 'href' => $this->headerHref, 129 129 - 'sigil' => implode(' ', $this->headerSigils) 129 129 + 'sigil' => implode(' ', $this->headerSigils), 130 130 ), 131 131 $this->headerTitle); 132 132 } ··· 134 134 $header = phutil_tag( 135 135 'h3', 136 136 array( 137 137 - 'class' => 'phui-action-header-title' 137 137 + 'class' => 'phui-action-header-title', 138 138 ), 139 139 array( 140 140 $header_icon, 141 141 - $header_title)); 141 141 + $header_title, 142 142 + )); 142 143 143 144 $icons = ''; 144 145 if (nonempty($action_list)) { 145 146 $icons = phutil_tag( 146 147 'ul', 147 148 array( 148 148 - 'class' => 'phui-action-header-icon-list' 149 149 + 'class' => 'phui-action-header-icon-list', 149 150 ), 150 151 $action_list); 151 152 } ··· 153 154 return phutil_tag( 154 155 'div', 155 156 array( 156 156 - 'class' => implode(' ', $classes) 157 157 + 'class' => implode(' ', $classes), 157 158 ), 158 159 array( 159 160 $header, 160 160 - $icons 161 161 + $icons, 161 162 )); 162 163 } 163 164 }

+8 -7

src/view/phui/PHUIDocumentView.php

reviewed

··· 95 95 $sidenav = phutil_tag( 96 96 'div', 97 97 array( 98 98 - 'class' => 'phui-document-sidenav' 98 98 + 'class' => 'phui-document-sidenav', 99 99 ), 100 100 $this->sidenav); 101 101 } ··· 105 105 $book = phutil_tag( 106 106 'div', 107 107 array( 108 108 - 'class' => 'phui-document-bookname grouped' 108 108 + 'class' => 'phui-document-bookname grouped', 109 109 ), 110 110 array( 111 111 phutil_tag( ··· 115 115 phutil_tag( 116 116 'span', 117 117 array('class' => 'bookdescription'), 118 118 - $this->bookdescription))); 118 118 + $this->bookdescription), 119 119 + )); 119 120 } 120 121 121 122 $topnav = null; ··· 123 124 $topnav = phutil_tag( 124 125 'div', 125 126 array( 126 126 - 'class' => 'phui-document-topnav' 127 127 + 'class' => 'phui-document-topnav', 127 128 ), 128 129 $this->topnav); 129 130 } ··· 133 134 $crumbs = phutil_tag( 134 135 'div', 135 136 array( 136 136 - 'class' => 'phui-document-crumbs' 137 137 + 'class' => 'phui-document-crumbs', 137 138 ), 138 139 $this->bookName); 139 140 } ··· 142 143 $main_content = phutil_tag( 143 144 'div', 144 145 array( 145 145 - 'class' => 'phui-font-'.$this->fontKit 146 146 + 'class' => 'phui-font-'.$this->fontKit, 146 147 ), 147 148 $this->renderChildren()); 148 149 } else { ··· 159 160 $this->header, 160 161 $topnav, 161 162 $main_content, 162 162 - $crumbs 163 163 + $crumbs, 163 164 )); 164 165 165 166 if ($this->mobileview == self::NAV_BOTTOM) {

+11 -8

src/view/phui/PHUIFeedStoryView.php

reviewed

··· 104 104 ), 105 105 array( 106 106 $title, 107 107 - $text)); 107 107 + $text, 108 108 + )); 108 109 $this->appendChild($copy); 109 110 return $this; 110 111 } ··· 127 128 $foot = phutil_tag( 128 129 'span', 129 130 array( 130 130 - 'class' => 'phabricator-notification-date'), 131 131 + 'class' => 'phabricator-notification-date', 132 132 + ), 131 133 $foot); 132 134 } else { 133 135 $foot = null; ··· 201 203 $action_list[] = phutil_tag( 202 204 'li', 203 205 array( 204 204 - 'class' => 'phui-feed-story-action-item' 205 205 - ), 206 206 - $action); 206 206 + 'class' => 'phui-feed-story-action-item', 207 207 + ), 208 208 + $action); 207 209 } 208 210 if (!empty($action_list)) { 209 211 $icons = phutil_tag( 210 212 'ul', 211 213 array( 212 212 - 'class' => 'phui-feed-story-action-list' 214 214 + 'class' => 'phui-feed-story-action-list', 213 215 ), 214 216 $action_list); 215 217 } ··· 229 231 $tokenview = phutil_tag( 230 232 'div', 231 233 array( 232 232 - 'class' => 'phui-feed-token-bar' 234 234 + 'class' => 'phui-feed-token-bar', 233 235 ), 234 236 $this->tokenBar); 235 237 $this->appendChild($tokenview); ··· 249 251 if ($this->tags) { 250 252 $tags = array( 251 253 " \xC2\xB7 ", 252 252 - $this->tags); 254 254 + $this->tags, 255 255 + ); 253 256 } 254 257 255 258 $foot = phutil_tag(

+2 -1

src/view/phui/PHUIObjectItemListView.php

reviewed

··· 114 114 $items = phutil_tag( 115 115 'li', 116 116 array( 117 117 - 'class' => 'phui-object-item-empty'), 117 117 + 'class' => 'phui-object-item-empty', 118 118 + ), 118 119 $string); 119 120 120 121 }

+1 -1

src/view/phui/PHUIPropertyListView.php

reviewed

··· 64 64 return $this; 65 65 } 66 66 67 67 - public function addSectionHeader($name, $icon=null) { 67 67 + public function addSectionHeader($name, $icon = null) { 68 68 $this->parts[] = array( 69 69 'type' => 'section', 70 70 'name' => $name,

+1 -1

src/view/phui/PHUITimelineEventView.php

reviewed

··· 148 148 return $this; 149 149 } 150 150 151 151 - public function setToken($token, $removed=false) { 151 151 + public function setToken($token, $removed = false) { 152 152 $this->token = $token; 153 153 $this->tokenRemoved = $removed; 154 154 return $this;

+3 -3

src/view/phui/PHUIWorkboardView.php

reviewed

··· 43 43 $items[] = phutil_tag( 44 44 'li', 45 45 array( 46 46 - 'class' => 'phui-workboard-action-item' 46 46 + 'class' => 'phui-workboard-action-item', 47 47 ), 48 48 $action); 49 49 } 50 50 $action_list = phutil_tag( 51 51 'ul', 52 52 array( 53 53 - 'class' => 'phui-workboard-action-list' 53 53 + 'class' => 'phui-workboard-action-list', 54 54 ), 55 55 $items); 56 56 } ··· 70 70 $board = phutil_tag( 71 71 'div', 72 72 array( 73 73 - 'class' => 'phui-workboard-view-shadow' 73 73 + 'class' => 'phui-workboard-view-shadow', 74 74 ), 75 75 $view); 76 76

+2 -2

src/view/phui/PHUIWorkpanelView.php

reviewed

··· 66 66 $footer = phutil_tag( 67 67 'ul', 68 68 array( 69 69 - 'class' => 'phui-workpanel-footer-action mst ps' 69 69 + 'class' => 'phui-workpanel-footer-action mst ps', 70 70 ), 71 71 $footer_tag); 72 72 } ··· 92 92 $body = phutil_tag( 93 93 'div', 94 94 array( 95 95 - 'class' => 'phui-workpanel-body' 95 95 + 'class' => 'phui-workpanel-body', 96 96 ), 97 97 $this->cards); 98 98

+12 -8

src/view/phui/calendar/PHUICalendarListView.php

reviewed

··· 48 48 $dot = phutil_tag( 49 49 'span', 50 50 array( 51 51 - 'class' => 'phui-calendar-list-dot'), 51 51 + 'class' => 'phui-calendar-list-dot', 52 52 + ), 52 53 ''); 53 54 $title = phutil_tag( 54 55 'span', 55 56 array( 56 56 - 'class' => 'phui-calendar-list-title'), 57 57 + 'class' => 'phui-calendar-list-title', 58 58 + ), 57 59 $this->renderEventLink($event, $allday)); 58 60 $time = phutil_tag( 59 61 'span', 60 62 array( 61 61 - 'class' => 'phui-calendar-list-time'), 63 63 + 'class' => 'phui-calendar-list-time', 64 64 + ), 62 65 $timelabel); 63 66 64 67 $singletons[] = phutil_tag( 65 68 'li', 66 69 array( 67 67 - 'class' => 'phui-calendar-list-item phui-calendar-'.$color 70 70 + 'class' => 'phui-calendar-list-item phui-calendar-'.$color, 68 71 ), 69 72 array( 70 73 $dot, 71 74 $title, 72 72 - $time)); 75 75 + $time, 76 76 + )); 73 77 } 74 78 75 79 if (empty($singletons)) { 76 80 $singletons[] = phutil_tag( 77 81 'li', 78 82 array( 79 79 - 'class' => 'phui-calendar-list-item-empty' 80 80 - ), 83 83 + 'class' => 'phui-calendar-list-item-empty', 84 84 + ), 81 85 pht('Clear sailing ahead.')); 82 86 } 83 87 84 88 $list = phutil_tag( 85 89 'ul', 86 90 array( 87 87 - 'class' => 'phui-calendar-list' 91 91 + 'class' => 'phui-calendar-list', 88 92 ), 89 93 $singletons); 90 94

+2 -1

src/view/phui/calendar/PHUICalendarMonthView.php

reviewed

··· 150 150 $cells[] = phutil_tag( 151 151 'td', 152 152 array( 153 153 - 'class' => 'phui-calendar-month-weekstart'), 153 153 + 'class' => 'phui-calendar-month-weekstart', 154 154 + ), 154 155 $cell); 155 156 } else { 156 157 $cells[] = phutil_tag('td', array(), $cell);

+2 -2

src/view/widget/bars/AphrontGlyphBarView.php

reviewed

··· 90 90 phutil_tag( 91 91 'div', 92 92 array(), 93 93 - $bg_glyphs) 93 93 + $bg_glyphs), 94 94 )), 95 95 phutil_tag( 96 96 'div', 97 97 array('class' => 'caption'), 98 98 - $this->getCaption()) 98 98 + $this->getCaption()), 99 99 )); 100 100 } 101 101

+2 -1

src/view/widget/bars/AphrontProgressBarView.php

reviewed

··· 51 51 phutil_tag( 52 52 'span', 53 53 array(), 54 54 - $this->getCaption()))); 54 54 + $this->getCaption()), 55 55 + )); 55 56 } 56 57 57 58 }

+16 -15

src/view/widget/hovercard/PhabricatorHovercardView.php

reviewed

··· 108 108 $body = phutil_tag( 109 109 'div', 110 110 array( 111 111 - 'class' => 'phabricator-hovercard-body-image'), 112 112 - phutil_tag( 113 113 - 'div', 114 114 - array( 115 115 - 'class' => 'profile-header-picture-frame', 116 116 - 'style' => 'background-image: url('.$handle->getImageURI().');', 117 117 - ), 118 118 - '')) 119 119 - ->appendHTML( 120 120 - phutil_tag( 121 121 - 'div', 122 122 - array( 123 123 - 'class' => 'phabricator-hovercard-body-details', 124 124 - ), 125 125 - $body)); 111 111 + 'class' => 'phabricator-hovercard-body-image', 112 112 + ), 113 113 + phutil_tag( 114 114 + 'div', 115 115 + array( 116 116 + 'class' => 'profile-header-picture-frame', 117 117 + 'style' => 'background-image: url('.$handle->getImageURI().');', 118 118 + ), 119 119 + '')) 120 120 + ->appendHTML( 121 121 + phutil_tag( 122 122 + 'div', 123 123 + array( 124 124 + 'class' => 'phabricator-hovercard-body-details', 125 125 + ), 126 126 + $body)); 126 127 } 127 128 128 129 $buttons = array();

+2 -1

support/PhabricatorStartup.php

reviewed

··· 400 400 // Replace superglobals with unfiltered versions, disrespect php.ini (we 401 401 // filter ourselves) 402 402 $filter = array(INPUT_GET, INPUT_POST, 403 403 - INPUT_SERVER, INPUT_ENV, INPUT_COOKIE); 403 403 + INPUT_SERVER, INPUT_ENV, INPUT_COOKIE, 404 404 + ); 404 405 foreach ($filter as $type) { 405 406 $filtered = filter_input_array($type, FILTER_UNSAFE_RAW); 406 407 if (!is_array($filtered)) {

+2 -1

webroot/index.php

reviewed

··· 124 124 'z-index: 200000;'. 125 125 'position: relative;'. 126 126 'padding: 8px;'. 127 127 - 'font-family: monospace'), 127 127 + 'font-family: monospace', 128 128 + ), 128 129 $unexpected_output); 129 130 } 130 131 }