@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Setup Checks: Add a comment about mbstring.func_overload removal
Summary:
Once Phorge requires PHP 8 the check for mbstring.func_overload can be removed:
* https://www.php.net/manual/en/mbstring.configuration.php#ini.mbstring.func-overload
* https://www.php.net/manual/en/mbstring.overload.php
Document that so future maintainers can find this when running grep.
Test Plan: None; it's a comment only.
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26283
+4
+4
src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
+4
src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php
···
62
62
}
63
63
}
64
64
65
+
// Remove this check once Phorge requires PHP 8. mbstring.func_overload
66
+
// got deprecated in PHP 7.2.0 and removed in PHP 8.0.0.
65
67
$overload_option = 'mbstring.func_overload';
66
68
$func_overload = ini_get($overload_option);
67
69
if ($func_overload) {
68
70
$message = pht(
69
71
"You have '%s' enabled in your PHP configuration.\n\n".
72
+
'This feature is "highly discouraged" by PHP\'s developers, and '.
73
+
'has been removed entirely in PHP8.'.
70
74
"This option is not compatible with this software. Disable ".
71
75
"'%s' in your PHP configuration to continue.",
72
76
$overload_option,