@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
[Redesign] Better Headers, more options
Summary: Ref T8099, Adds ability to set header as "tall" and provide better control over height of actual header text. Also fixed some color issues with multiple object boxes.
Test Plan: Review a commit, review dashboards, review a diff, review home.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D13077
+44
-61
+9
-9
resources/celerity/map.php
+9
-9
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'b6b5fe6c',
10
+
'core.pkg.css' => 'db211713',
11
11
'core.pkg.js' => 'fbf1d615',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '7d01bee8',
···
26
26
'rsrc/css/aphront/pager-view.css' => '2e3539af',
27
27
'rsrc/css/aphront/panel-view.css' => '8427b78d',
28
28
'rsrc/css/aphront/phabricator-nav-view.css' => '0ecd30a1',
29
-
'rsrc/css/aphront/table-view.css' => '15fedf7a',
29
+
'rsrc/css/aphront/table-view.css' => '4f2ed0bf',
30
30
'rsrc/css/aphront/tokenizer.css' => '04875312',
31
31
'rsrc/css/aphront/tooltip.css' => '7672b60f',
32
32
'rsrc/css/aphront/two-column.css' => '16ab3ad2',
···
129
129
'rsrc/css/phui/phui-box.css' => 'a5bb366d',
130
130
'rsrc/css/phui/phui-button.css' => 'b995182d',
131
131
'rsrc/css/phui/phui-crumbs-view.css' => 'ce840ec2',
132
-
'rsrc/css/phui/phui-document.css' => '8be7a5e3',
132
+
'rsrc/css/phui/phui-document.css' => '88f0c90b',
133
133
'rsrc/css/phui/phui-feed-story.css' => '92f55311',
134
134
'rsrc/css/phui/phui-fontkit.css' => 'b664ac96',
135
135
'rsrc/css/phui/phui-form-view.css' => 'a0e8f168',
136
136
'rsrc/css/phui/phui-form.css' => 'f535f938',
137
-
'rsrc/css/phui/phui-header-view.css' => '47b8f221',
137
+
'rsrc/css/phui/phui-header-view.css' => '7716c613',
138
138
'rsrc/css/phui/phui-icon.css' => '88ba9081',
139
139
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
140
140
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
141
141
'rsrc/css/phui/phui-info-view.css' => '33e54618',
142
142
'rsrc/css/phui/phui-list.css' => 'e448b6ba',
143
-
'rsrc/css/phui/phui-object-box.css' => '59db5c05',
143
+
'rsrc/css/phui/phui-object-box.css' => '92f2ddcf',
144
144
'rsrc/css/phui/phui-object-item-list-view.css' => '29ded459',
145
145
'rsrc/css/phui/phui-pinboard-view.css' => '55b27bc3',
146
146
'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb',
···
483
483
'aphront-multi-column-view-css' => 'fd18389d',
484
484
'aphront-pager-view-css' => '2e3539af',
485
485
'aphront-panel-view-css' => '8427b78d',
486
-
'aphront-table-view-css' => '15fedf7a',
486
+
'aphront-table-view-css' => '4f2ed0bf',
487
487
'aphront-tokenizer-control-css' => '04875312',
488
488
'aphront-tooltip-css' => '7672b60f',
489
489
'aphront-two-column-view-css' => '16ab3ad2',
···
763
763
'phui-calendar-list-css' => 'c1c7f338',
764
764
'phui-calendar-month-css' => '476be7e0',
765
765
'phui-crumbs-view-css' => 'ce840ec2',
766
-
'phui-document-view-css' => '8be7a5e3',
766
+
'phui-document-view-css' => '88f0c90b',
767
767
'phui-feed-story-css' => '92f55311',
768
768
'phui-font-icon-base-css' => '3dad2ae3',
769
769
'phui-fontkit-css' => 'b664ac96',
770
770
'phui-form-css' => 'f535f938',
771
771
'phui-form-view-css' => 'a0e8f168',
772
-
'phui-header-view-css' => '47b8f221',
772
+
'phui-header-view-css' => '7716c613',
773
773
'phui-icon-view-css' => '88ba9081',
774
774
'phui-image-mask-css' => '5a8b09c8',
775
775
'phui-info-panel-css' => '27ea50a1',
776
776
'phui-info-view-css' => '33e54618',
777
777
'phui-inline-comment-view-css' => 'aa16f165',
778
778
'phui-list-view-css' => 'e448b6ba',
779
-
'phui-object-box-css' => '59db5c05',
779
+
'phui-object-box-css' => '92f2ddcf',
780
780
'phui-object-item-list-view-css' => '29ded459',
781
781
'phui-pinboard-view-css' => '55b27bc3',
782
782
'phui-property-list-view-css' => '1baf23eb',
+1
src/applications/diffusion/controller/DiffusionCommitController.php
+1
src/applications/diffusion/controller/DiffusionCommitController.php
+3
-16
src/view/phui/PHUIDocumentView.php
+3
-16
src/view/phui/PHUIDocumentView.php
···
24
24
}
25
25
26
26
public function setHeader(PHUIHeaderView $header) {
27
+
$header->setTall(true);
27
28
$this->header = $header;
28
29
return $this;
29
30
}
···
111
112
112
113
$book = null;
113
114
if ($this->bookname) {
114
-
$book = phutil_tag(
115
-
'div',
116
-
array(
117
-
'class' => 'phui-document-bookname grouped',
118
-
),
119
-
array(
120
-
phutil_tag(
121
-
'span',
122
-
array('class' => 'bookname'),
123
-
$this->bookname),
124
-
phutil_tag(
125
-
'span',
126
-
array('class' => 'bookdescription'),
127
-
$this->bookdescription),
128
-
));
115
+
$book = pht('%s (%s)', $this->bookname, $this->bookdescription);
129
116
}
130
117
131
118
$topnav = null;
···
159
146
$main_content = $this->renderChildren();
160
147
}
161
148
149
+
$this->header->setSubheader($book);
162
150
$content_inner = phutil_tag(
163
151
'div',
164
152
array(
165
153
'class' => 'phui-document-inner',
166
154
),
167
155
array(
168
-
$book,
169
156
$this->header,
170
157
$topnav,
171
158
$main_content,
+14
-2
src/view/phui/PHUIHeaderView.php
+14
-2
src/view/phui/PHUIHeaderView.php
···
13
13
private $headerIcon;
14
14
private $noBackground;
15
15
private $bleedHeader;
16
+
private $tall;
16
17
private $properties = array();
17
18
private $actionLinks = array();
18
19
private $buttonBar = null;
···
32
33
33
34
public function setNoBackground($nada) {
34
35
$this->noBackground = $nada;
36
+
return $this;
37
+
}
38
+
39
+
public function setTall($tall) {
40
+
$this->tall = $tall;
35
41
return $this;
36
42
}
37
43
···
147
153
$classes[] = 'phui-bleed-header';
148
154
}
149
155
150
-
if ($this->properties || $this->policyObject || $this->subheader) {
156
+
if ($this->properties || $this->policyObject ||
157
+
$this->subheader || $this->tall) {
151
158
$classes[] = 'phui-header-tall';
152
159
}
153
160
···
230
237
->setIconFont($this->headerIcon);
231
238
$left[] = $icon;
232
239
}
233
-
$left[] = $this->header;
240
+
$left[] = phutil_tag(
241
+
'span',
242
+
array(
243
+
'class' => 'phui-header-header',
244
+
),
245
+
$this->header);
234
246
235
247
if ($this->objectName) {
236
248
array_unshift(
+1
-2
webroot/rsrc/css/aphront/table-view.css
+1
-2
webroot/rsrc/css/aphront/table-view.css
+4
-22
webroot/rsrc/css/phui/phui-document.css
+4
-22
webroot/rsrc/css/phui/phui-document.css
···
10
10
11
11
.phui-document-view .phui-header-shell {
12
12
padding: 16px;
13
+
background-color: #F5F7FA;
13
14
}
14
15
15
16
.phui-document-content {
···
47
48
.device-phone .phui-document-sidenav {
48
49
position: static;
49
50
width: auto;
50
-
border-top: 1px solid #d7d7d7;
51
-
border-bottom: 1px solid #d7d7d7;
51
+
border-top: 1px solid {$thinblueborder};
52
+
border-bottom: 1px solid {$thinblueborder};
52
53
}
53
54
54
55
.device-phone .phui-sidenav-view .phui-document-inner {
···
57
58
58
59
.phui-sidenav-view .phui-document-inner {
59
60
margin-right: 200px;
60
-
border-right: 1px solid #e7e7e7;
61
+
border-right: 1px solid {$thinblueborder};
61
62
background: #fff;
62
-
}
63
-
64
-
.phui-document-bookname {
65
-
padding: 8px 16px;
66
-
color: #9ca5b5;
67
-
background-color: #fff;
68
-
border-bottom: 1px solid {$lightblueborder};
69
-
}
70
-
71
-
.device-phone .phui-document-bookname {
72
-
padding: 8px;
73
-
}
74
-
75
-
.phui-document-bookname .bookname {
76
-
float: left;
77
-
}
78
-
79
-
.phui-document-bookname .bookdescription {
80
-
float: right;
81
63
}
82
64
83
65
.phui-document-content .phui-header-shell {
+12
-6
webroot/rsrc/css/phui/phui-header-view.css
+12
-6
webroot/rsrc/css/phui/phui-header-view.css
···
64
64
}
65
65
66
66
.phui-header-view {
67
-
font-size: 16px;
67
+
position: relative;
68
+
font-size: 13px;
69
+
}
70
+
71
+
.phui-header-header {
68
72
color: #000;
73
+
font-size: 15px;
69
74
font-weight: 500;
70
-
position: relative;
75
+
line-height: 20px;
71
76
}
72
77
73
-
.device-phone .phui-header-view {
78
+
.device-phone .phui-header-header {
74
79
font-size: 14px;
75
80
}
76
81
77
-
.phui-object-box .phui-header-tall h1.phui-header-view,
78
-
.phui-document-view .phui-header-tall h1.phui-header-view {
82
+
.phui-object-box .phui-header-tall .phui-header-header,
83
+
.phui-document-view .phui-header-tall .phui-header-header {
79
84
font-size: 18px;
80
85
font-weight: 500;
81
86
}
82
87
83
-
.phui-header-view .phui-header-col2 > a {
88
+
.phui-header-view .phui-header-header a {
84
89
color: #000;
85
90
}
86
91
···
90
95
91
96
.phui-object-box .phui-header-view .phui-header-action-links {
92
97
margin-right: 4px;
98
+
font-size: 13px;
93
99
}
94
100
95
101
.device-phone .phui-object-box .phui-header-view .phui-header-action-links {