recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a commit hook issue where pushing dangerous changes would fatal before hitting the dragon bureaucrats

Summary: See <https://discourse.phabricator-community.org/t/php-fatal-when-using-git-push-d/1317>. The behavioral changes for Herald on initial import from D19265 could leave `$all_updates` undefined if we throw early enough.

Test Plan: Pushed a dangerous change, saw dragon bureaucrats again.

Differential Revision: https://secure.phabricator.com/D19297

epriestley 3de002c8 e70c9f72

+1
+1
src/applications/diffusion/engine/DiffusionCommitHookEngine.php
··· 126 126 127 127 public function execute() { 128 128 $ref_updates = $this->findRefUpdates(); 129 + $all_updates = $ref_updates; 129 130 130 131 $caught = null; 131 132 try {