@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix PHP8.1 strlen(null) error in DivinerArticleAtomizer.php
Summary:
Fix the strlen(null) error in DivinerArticleAtomizer.php
Fixes T16012
Test Plan:
Create Test.book and test.md as per T16012, then run:
```
/phorge/bin/diviner generate --book Test.book
```
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T16012
Differential Revision: https://we.phorge.it/D25907
+1
-1
+1
-1
src/applications/diviner/atomizer/DivinerArticleAtomizer.php
+1
-1
src/applications/diviner/atomizer/DivinerArticleAtomizer.php
···
14
14
$meta = $atom->getDocblockMeta();
15
15
16
16
$title = idx($meta, 'title');
17
-
if (!strlen($title)) {
17
+
if (!phutil_nonempty_string($title)) {
18
18
$title = pht('Untitled Article "%s"', basename($file_name));
19
19
$atom->addWarning(pht('Article has no %s!', '@title'));
20
20
$atom->setDocblockMetaValue('title', $title);