recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Break logo/name into replaceable parts

Summary: Ref T4214, this breaks the 'eye' out as a separate image 40px x 40px. We also now show the eye on mobile, as we have enough room for both currently.

Test Plan: Tested default and nightmaremoon colors, tested mobile, tablet and desktop layouts.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T4214

Differential Revision: https://secure.phabricator.com/D10794

Chad Little 3ea31c92 351f4722

+51 -30
+7 -7
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => '33952f78', 10 + 'core.pkg.css' => 'f933e4df', 11 11 'core.pkg.js' => 'cbdbd552', 12 12 'darkconsole.pkg.js' => 'df001cab', 13 13 'differential.pkg.css' => '8af45893', ··· 35 35 'rsrc/css/aphront/two-column.css' => '16ab3ad2', 36 36 'rsrc/css/aphront/typeahead.css' => 'a989b5b3', 37 37 'rsrc/css/application/auth/auth.css' => '1e655982', 38 - 'rsrc/css/application/base/main-menu-view.css' => 'aceca0e9', 38 + 'rsrc/css/application/base/main-menu-view.css' => 'cebeecc4', 39 39 'rsrc/css/application/base/notification-menu.css' => '6aa0a74b', 40 40 'rsrc/css/application/base/phabricator-application-launch-view.css' => '5d71008f', 41 41 'rsrc/css/application/base/standard-page-view.css' => '3f5b9311', ··· 152 152 'rsrc/css/sprite-gradient.css' => '4bdb98a7', 153 153 'rsrc/css/sprite-login.css' => 'a355d921', 154 154 'rsrc/css/sprite-main-header.css' => '92720ee2', 155 - 'rsrc/css/sprite-menu.css' => '28281e16', 155 + 'rsrc/css/sprite-menu.css' => '1e5b7537', 156 156 'rsrc/css/sprite-payments.css' => 'cc085d44', 157 157 'rsrc/css/sprite-projects.css' => '7578fa56', 158 158 'rsrc/css/sprite-tokens.css' => '1706b943', ··· 324 324 'rsrc/image/sprite-login-X2.png' => '5ae6de3a', 325 325 'rsrc/image/sprite-login.png' => '07f2c67c', 326 326 'rsrc/image/sprite-main-header.png' => '83521873', 327 - 'rsrc/image/sprite-menu-X2.png' => '39d78f97', 328 - 'rsrc/image/sprite-menu.png' => '259dab45', 327 + 'rsrc/image/sprite-menu-X2.png' => '162d7d2b', 328 + 'rsrc/image/sprite-menu.png' => '3734edad', 329 329 'rsrc/image/sprite-payments.png' => 'd8576309', 330 330 'rsrc/image/sprite-projects-X2.png' => '218fdc8b', 331 331 'rsrc/image/sprite-projects.png' => '631ff9a7', ··· 717 717 'phabricator-hovercard-view-css' => '893f4783', 718 718 'phabricator-keyboard-shortcut' => '1ae869f2', 719 719 'phabricator-keyboard-shortcut-manager' => 'ad7a69ca', 720 - 'phabricator-main-menu-view' => 'aceca0e9', 720 + 'phabricator-main-menu-view' => 'cebeecc4', 721 721 'phabricator-nav-view-css' => '9283c2df', 722 722 'phabricator-notification' => '0c6946e7', 723 723 'phabricator-notification-css' => '9c279160', ··· 814 814 'sprite-gradient-css' => '4bdb98a7', 815 815 'sprite-login-css' => 'a355d921', 816 816 'sprite-main-header-css' => '92720ee2', 817 - 'sprite-menu-css' => '28281e16', 817 + 'sprite-menu-css' => '1e5b7537', 818 818 'sprite-payments-css' => 'cc085d44', 819 819 'sprite-projects-css' => '7578fa56', 820 820 'sprite-tokens-css' => '1706b943',
+7 -2
resources/sprite/manifest/menu.json
··· 31 31 "rule" : ".alert-notifications.message-unread .phabricator-main-menu-message-icon", 32 32 "hash" : "7edd6d68b36f2f46133eb3118f966c6b" 33 33 }, 34 + "eye" : { 35 + "name" : "eye", 36 + "rule" : ".phabricator-main-menu-eye", 37 + "hash" : "35f24014f23142275574136a63dcb73f" 38 + }, 34 39 "info-sm" : { 35 40 "name" : "info-sm", 36 41 "rule" : ".menu-icon-info-sm", ··· 38 43 }, 39 44 "logo" : { 40 45 "name" : "logo", 41 - "rule" : ".phabricator-main-menu-logo-image", 42 - "hash" : "b03901ae5dff3ec840b88f8335819598" 46 + "rule" : ".phabricator-main-menu-logo", 47 + "hash" : "668b04729a4b9460b0c89cb6ef6db4d4" 43 48 }, 44 49 "logout-sm" : { 45 50 "name" : "logout-sm",
resources/sprite/menu_1x/eye.png

This is a binary file and will not be displayed.

resources/sprite/menu_1x/logo.png

This is a binary file and will not be displayed.

resources/sprite/menu_2x/eye.png

This is a binary file and will not be displayed.

resources/sprite/menu_2x/logo.png

This is a binary file and will not be displayed.

+7 -2
src/applications/celerity/CeleritySpriteGenerator.php
··· 85 85 'css' => '.menu-icon-app-blue', 86 86 ), 87 87 'logo' => array( 88 - 'x' => 149, 88 + 'x' => 96, 89 89 'y' => 26, 90 - 'css' => '.phabricator-main-menu-logo-image', 90 + 'css' => '.phabricator-main-menu-logo', 91 + ), 92 + 'eye' => array( 93 + 'x' => 40, 94 + 'y' => 40, 95 + 'css' => '.phabricator-main-menu-eye', 91 96 ), 92 97 'conf-off' => array( 93 98 'x' => 18,
+8 -3
src/view/page/menu/PhabricatorMainMenuView.php
··· 238 238 } 239 239 240 240 private function renderPhabricatorLogo() { 241 - $class = 'phabricator-main-menu-logo-image'; 242 241 243 242 return phutil_tag( 244 243 'a', 245 244 array( 246 - 'class' => 'phabricator-main-menu-logo', 245 + 'class' => 'phabricator-main-menu-brand', 247 246 'href' => '/', 248 247 ), 249 248 array( ··· 256 255 phutil_tag( 257 256 'span', 258 257 array( 259 - 'class' => 'sprite-menu menu-logo-image '.$class, 258 + 'class' => 'sprite-menu phabricator-main-menu-eye', 259 + ), 260 + ''), 261 + phutil_tag( 262 + 'span', 263 + array( 264 + 'class' => 'sprite-menu phabricator-main-menu-logo', 260 265 ), 261 266 ''), 262 267 ));
+16 -14
webroot/rsrc/css/application/base/main-menu-view.css
··· 38 38 float: left; 39 39 } 40 40 41 - .phabricator-main-menu-logo { 41 + .phabricator-main-menu-brand { 42 42 display: inline-block; 43 - width: 149px; 43 + width: 148px; 44 44 height: 44px; 45 45 float: left; 46 46 margin-right: 6px; 47 - padding-right: 6px; 47 + padding-right: 4px; 48 48 padding-left: 6px; 49 49 } 50 50 51 - .menu-logo-image { 51 + .phabricator-main-menu-logo { 52 52 position: absolute; 53 - width: 149px; 53 + width: 96px; 54 54 height: 26px; 55 + left: 52px; 55 56 top: 9px; 56 57 } 57 58 58 - .device-phone .phabricator-main-menu-logo { 59 - margin-left: -45px; 59 + .phabricator-main-menu-eye { 60 + position: absolute; 61 + width: 40px; 62 + height: 40px; 63 + top: 2px; 60 64 } 61 65 62 - .device .phabricator-main-menu-logo:hover { 63 - background-color: transparent; 66 + .device .phabricator-main-menu-brand:hover { 67 + background-color: rgba(0,0,0,.6); 68 + cursor: hand; 64 69 } 65 70 66 71 /* - Expand/Collapse Button ---------------------------------------------------- ··· 385 390 } 386 391 387 392 .device-desktop .main-header-dark .phabricator-application-menu 388 - .core-menu-item.phui-list-item-view:hover, 389 - .device-desktop .main-header-dark .phabricator-main-menu-logo:hover { 393 + .core-menu-item.phui-list-item-view:hover { 390 394 background-color: rgba(0,0,0,.6); 391 395 } 392 396 393 397 .device-desktop .phabricator-application-menu 394 - .core-menu-item.phui-list-item-view:hover, 395 - .device-desktop .phabricator-main-menu-logo:hover { 396 - background-color: rgba(0,0,0,.3); 398 + .core-menu-item.phui-list-item-view:hover { 397 399 box-shadow: inset 0 5px 10px rgba(0,0,0,0.5); 398 400 border-radius: 3px; 399 401 }
+6 -2
webroot/rsrc/css/sprite-menu.css
··· 13 13 only screen and (-webkit-min-device-pixel-ratio: 1.5) { 14 14 .sprite-menu { 15 15 background-image: url(/rsrc/image/sprite-menu-X2.png); 16 - background-size: 150px 151px; 16 + background-size: 116px 192px; 17 17 } 18 18 } 19 19 ··· 78 78 background-position: -35px -119px; 79 79 } 80 80 81 - .phabricator-main-menu-logo-image { 81 + .phabricator-main-menu-logo { 82 82 background-position: 0px -63px; 83 + } 84 + 85 + .phabricator-main-menu-eye { 86 + background-position: 0px -151px; 83 87 } 84 88 85 89 .alert-notifications .phabricator-main-menu-message-icon {
webroot/rsrc/image/sprite-menu-X2.png

This is a binary file and will not be displayed.

webroot/rsrc/image/sprite-menu.png

This is a binary file and will not be displayed.